From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E4BC433B4 for ; Thu, 15 Apr 2021 03:51:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B0AF6128E for ; Thu, 15 Apr 2021 03:51:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbhDODwQ (ORCPT ); Wed, 14 Apr 2021 23:52:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27545 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbhDODwO (ORCPT ); Wed, 14 Apr 2021 23:52:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618458712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XcVd67igXG+x7EhtNoBXYI6tu8yQc7FQQDvtAR2BYPk=; b=MT0TsxFmAuv9lc05PQO/LHko4FJscTDDzHDhxw31T2hYdu/aAFoWOVKSsq94CVGPfRcglF SJaAhNRUsac9kTHIzzwo2QoRbERSAbXporLhbYjz9ej5h1z0JbZsNjXW5btYm7Mo7iYu/v 7AZWOUxo10EQXW5objLwNonyvd4PzMs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-UJ5DRA2FPE6MR6yTLkxMGw-1; Wed, 14 Apr 2021 23:51:49 -0400 X-MC-Unique: UJ5DRA2FPE6MR6yTLkxMGw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C3B210053E6; Thu, 15 Apr 2021 03:51:46 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-220.pek2.redhat.com [10.72.13.220]) by smtp.corp.redhat.com (Postfix) with ESMTP id B61336E50A; Thu, 15 Apr 2021 03:51:27 +0000 (UTC) Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver To: Jie Deng , linux-i2c@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: mst@redhat.com, wsa@kernel.org, wsa+renesas@sang-engineering.com, andriy.shevchenko@linux.intel.com, conghui.chen@intel.com, arnd@arndb.de, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru, rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com, u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org, yu1.wang@intel.com, shuo.a.liu@intel.com, viresh.kumar@linaro.org, stefanha@redhat.com, pbonzini@redhat.com References: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> From: Jason Wang Message-ID: Date: Thu, 15 Apr 2021 11:51:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/3/23 ÏÂÎç10:19, Jie Deng дµÀ: > Add an I2C bus driver for virtio para-virtualization. > > The controller can be emulated by the backend driver in > any device model software by following the virtio protocol. > > The device specification can be found on > https://lists.oasis-open.org/archives/virtio-comment/202101/msg00008.html. > > By following the specification, people may implement different > backend drivers to emulate different controllers according to > their needs. > > Co-developed-by: Conghui Chen > Signed-off-by: Conghui Chen > Signed-off-by: Jie Deng > --- > Changes in v10: > - Fix some typo errors. > - Refined the virtio_i2c_complete_reqs to use less code lines. > > Changes in v9: > - Remove the virtio_adapter and update its members in probe. > - Refined the virtio_i2c_complete_reqs for buf free. > > Changes in v8: > - Make virtio_i2c.adap a pointer. > - Mark members in virtio_i2c_req with ____cacheline_aligned. > > Changes in v7: > - Remove unused headers. > - Update Makefile and Kconfig. > - Add the cleanup after completing reqs. > - Avoid memcpy for data marked with I2C_M_DMA_SAFE. > - Fix something reported by kernel test robot. > > Changes in v6: > - Move struct virtio_i2c_req into the driver. > - Use only one buf in struct virtio_i2c_req. > > Changes in v5: > - The first version based on the acked specification. > > drivers/i2c/busses/Kconfig | 11 ++ > drivers/i2c/busses/Makefile | 3 + > drivers/i2c/busses/i2c-virtio.c | 276 ++++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/virtio_i2c.h | 40 ++++++ > include/uapi/linux/virtio_ids.h | 1 + > 5 files changed, 331 insertions(+) > create mode 100644 drivers/i2c/busses/i2c-virtio.c > create mode 100644 include/uapi/linux/virtio_i2c.h > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 05ebf75..cb8d0d8 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -21,6 +21,17 @@ config I2C_ALI1535 > This driver can also be built as a module. If so, the module > will be called i2c-ali1535. > > +config I2C_VIRTIO > + tristate "Virtio I2C Adapter" > + select VIRTIO > + help > + If you say yes to this option, support will be included for the virtio > + I2C adapter driver. The hardware can be emulated by any device model > + software according to the virtio protocol. > + > + This driver can also be built as a module. If so, the module > + will be called i2c-virtio. > + > config I2C_ALI1563 > tristate "ALI 1563" > depends on PCI > diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile > index 615f35e..efdd3f3 100644 > --- a/drivers/i2c/busses/Makefile > +++ b/drivers/i2c/busses/Makefile > @@ -145,4 +145,7 @@ obj-$(CONFIG_I2C_XGENE_SLIMPRO) += i2c-xgene-slimpro.o > obj-$(CONFIG_SCx200_ACB) += scx200_acb.o > obj-$(CONFIG_I2C_FSI) += i2c-fsi.o > > +# VIRTIO I2C host controller driver > +obj-$(CONFIG_I2C_VIRTIO) += i2c-virtio.o > + > ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG > diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c > new file mode 100644 > index 0000000..99a1e30 > --- /dev/null > +++ b/drivers/i2c/busses/i2c-virtio.c > @@ -0,0 +1,276 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Virtio I2C Bus Driver > + * > + * The Virtio I2C Specification: > + * https://raw.githubusercontent.com/oasis-tcs/virtio-spec/master/virtio-i2c.tex > + * > + * Copyright (c) 2021 Intel Corporation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/** > + * struct virtio_i2c - virtio I2C data > + * @vdev: virtio device for this controller > + * @completion: completion of virtio I2C message > + * @adap: I2C adapter for this controller > + * @lock: lock for virtqueue processing > + * @vq: the virtio virtqueue for communication > + */ > +struct virtio_i2c { > + struct virtio_device *vdev; > + struct completion completion; > + struct i2c_adapter adap; > + struct mutex lock; > + struct virtqueue *vq; > +}; > + > +/** > + * struct virtio_i2c_req - the virtio I2C request structure > + * @out_hdr: the OUT header of the virtio I2C message > + * @buf: the buffer into which data is read, or from which it's written > + * @in_hdr: the IN header of the virtio I2C message > + */ > +struct virtio_i2c_req { > + struct virtio_i2c_out_hdr out_hdr ____cacheline_aligned; > + uint8_t *buf ____cacheline_aligned; > + struct virtio_i2c_in_hdr in_hdr ____cacheline_aligned; > +}; > + > +static void virtio_i2c_msg_done(struct virtqueue *vq) > +{ > + struct virtio_i2c *vi = vq->vdev->priv; > + > + complete(&vi->completion); > +} > + > +static int virtio_i2c_send_reqs(struct virtqueue *vq, > + struct virtio_i2c_req *reqs, > + struct i2c_msg *msgs, int nr) > +{ > + struct scatterlist *sgs[3], out_hdr, msg_buf, in_hdr; > + int i, outcnt, incnt, err = 0; > + > + for (i = 0; i < nr; i++) { > + if (!msgs[i].len) > + break; > + > + /* > + * Only 7-bit mode supported for this moment. For the address format, > + * Please check the Virtio I2C Specification. > + */ > + reqs[i].out_hdr.addr = cpu_to_le16(msgs[i].addr << 1); > + > + if (i != nr - 1) > + reqs[i].out_hdr.flags = cpu_to_le32(VIRTIO_I2C_FLAGS_FAIL_NEXT); > + > + outcnt = incnt = 0; > + sg_init_one(&out_hdr, &reqs[i].out_hdr, sizeof(reqs[i].out_hdr)); > + sgs[outcnt++] = &out_hdr; > + > + reqs[i].buf = i2c_get_dma_safe_msg_buf(&msgs[i], 1); > + if (!reqs[i].buf) > + break; > + > + sg_init_one(&msg_buf, reqs[i].buf, msgs[i].len); > + > + if (msgs[i].flags & I2C_M_RD) > + sgs[outcnt + incnt++] = &msg_buf; > + else > + sgs[outcnt++] = &msg_buf; > + > + sg_init_one(&in_hdr, &reqs[i].in_hdr, sizeof(reqs[i].in_hdr)); > + sgs[outcnt + incnt++] = &in_hdr; > + > + err = virtqueue_add_sgs(vq, sgs, outcnt, incnt, &reqs[i], GFP_KERNEL); > + if (err < 0) { > + pr_err("failed to add msg[%d] to virtqueue.\n", i); > + i2c_put_dma_safe_msg_buf(reqs[i].buf, &msgs[i], false); > + break; > + } > + } > + > + return i; > +} > + > +static int virtio_i2c_complete_reqs(struct virtqueue *vq, > + struct virtio_i2c_req *reqs, > + struct i2c_msg *msgs, int nr, > + bool timeout) > +{ > + struct virtio_i2c_req *req; > + bool failed = timeout; > + unsigned int len; > + int i, j = 0; > + > + for (i = 0; i < nr; i++) { > + /* Detach the ith request from the vq */ > + req = virtqueue_get_buf(vq, &len); > + > + /* > + * Condition (req && req == &reqs[i]) should always meet since > + * we have total nr requests in the vq. So this assumes the requests are completed in order. Is this mandated in the spec? > + */ > + if (!failed && (WARN_ON(!(req && req == &reqs[i])) || > + (req->in_hdr.status != VIRTIO_I2C_MSG_OK))) > + failed = true; > + > + i2c_put_dma_safe_msg_buf(reqs[i].buf, &msgs[i], !failed); > + if (!failed) > + ++j; > + } > + > + return (timeout ? -ETIMEDOUT : j); Checking timeout is fragile, what happens if the request are completed after wait_for_completion() but before virtio_i2c_complete_reqs()? > +} > + > +static int virtio_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) > +{ > + struct virtio_i2c *vi = i2c_get_adapdata(adap); > + struct virtqueue *vq = vi->vq; > + struct virtio_i2c_req *reqs; > + unsigned long time_left; > + int ret, nr; > + > + reqs = kcalloc(num, sizeof(*reqs), GFP_KERNEL); > + if (!reqs) > + return -ENOMEM; > + > + mutex_lock(&vi->lock); > + > + ret = virtio_i2c_send_reqs(vq, reqs, msgs, num); > + if (ret == 0) > + goto err_unlock_free; > + > + nr = ret; > + reinit_completion(&vi->completion); > + virtqueue_kick(vq); > + > + time_left = wait_for_completion_timeout(&vi->completion, adap->timeout); > + if (!time_left) > + dev_err(&adap->dev, "virtio i2c backend timeout.\n"); > + > + ret = virtio_i2c_complete_reqs(vq, reqs, msgs, nr, !time_left); > + > +err_unlock_free: > + mutex_unlock(&vi->lock); > + kfree(reqs); > + return ret; > +} > + > +static void virtio_i2c_del_vqs(struct virtio_device *vdev) > +{ > + vdev->config->reset(vdev); > + vdev->config->del_vqs(vdev); > +} > + > +static int virtio_i2c_setup_vqs(struct virtio_i2c *vi) > +{ > + struct virtio_device *vdev = vi->vdev; > + > + vi->vq = virtio_find_single_vq(vdev, virtio_i2c_msg_done, "msg"); > + return PTR_ERR_OR_ZERO(vi->vq); > +} > + > +static u32 virtio_i2c_func(struct i2c_adapter *adap) > +{ > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > +} > + > +static struct i2c_algorithm virtio_algorithm = { > + .master_xfer = virtio_i2c_xfer, > + .functionality = virtio_i2c_func, > +}; > + > +static int virtio_i2c_probe(struct virtio_device *vdev) > +{ > + struct device *pdev = vdev->dev.parent; > + struct virtio_i2c *vi; > + int ret; > + > + vi = devm_kzalloc(&vdev->dev, sizeof(*vi), GFP_KERNEL); > + if (!vi) > + return -ENOMEM; > + > + vdev->priv = vi; > + vi->vdev = vdev; > + > + mutex_init(&vi->lock); > + init_completion(&vi->completion); > + > + ret = virtio_i2c_setup_vqs(vi); > + if (ret) > + return ret; > + > + vi->adap.owner = THIS_MODULE; > + snprintf(vi->adap.name, sizeof(vi->adap.name), "Virtio I2C Adapter"); > + vi->adap.class = I2C_CLASS_DEPRECATED; > + vi->adap.algo = &virtio_algorithm; > + vi->adap.dev.parent = &vdev->dev; > + vi->adap.timeout = HZ / 10; > + i2c_set_adapdata(&vi->adap, vi); > + > + /* Setup ACPI node for controlled devices which will be probed through ACPI */ > + ACPI_COMPANION_SET(&vi->adap.dev, ACPI_COMPANION(pdev)); > + > + ret = i2c_add_adapter(&vi->adap); > + if (ret) { > + virtio_i2c_del_vqs(vdev); > + dev_err(&vdev->dev, "failed to add virtio-i2c adapter.\n"); > + } > + > + return ret; > +} > + > +static void virtio_i2c_remove(struct virtio_device *vdev) > +{ > + struct virtio_i2c *vi = vdev->priv; > + > + i2c_del_adapter(&vi->adap); > + virtio_i2c_del_vqs(vdev); > +} > + > +static struct virtio_device_id id_table[] = { > + { VIRTIO_ID_I2C_ADAPTER, VIRTIO_DEV_ANY_ID }, > + {} > +}; > +MODULE_DEVICE_TABLE(virtio, id_table); > + > +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) > +{ > + virtio_i2c_del_vqs(vdev); > + return 0; > +} > + > +static int __maybe_unused virtio_i2c_restore(struct virtio_device *vdev) > +{ > + return virtio_i2c_setup_vqs(vdev->priv); > +} > + > +static struct virtio_driver virtio_i2c_driver = { > + .id_table = id_table, > + .probe = virtio_i2c_probe, > + .remove = virtio_i2c_remove, > + .driver = { > + .name = "i2c_virtio", > + }, > +#ifdef CONFIG_PM_SLEEP > + .freeze = virtio_i2c_freeze, > + .restore = virtio_i2c_restore, > +#endif > +}; > +module_virtio_driver(virtio_i2c_driver); > + > +MODULE_AUTHOR("Jie Deng "); > +MODULE_AUTHOR("Conghui Chen "); > +MODULE_DESCRIPTION("Virtio i2c bus driver"); > +MODULE_LICENSE("GPL"); > diff --git a/include/uapi/linux/virtio_i2c.h b/include/uapi/linux/virtio_i2c.h > new file mode 100644 > index 0000000..bbcfb2c > --- /dev/null > +++ b/include/uapi/linux/virtio_i2c.h > @@ -0,0 +1,40 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later WITH Linux-syscall-note */ > +/* > + * Definitions for virtio I2C Adpter > + * > + * Copyright (c) 2021 Intel Corporation. All rights reserved. > + */ > + > +#ifndef _UAPI_LINUX_VIRTIO_I2C_H > +#define _UAPI_LINUX_VIRTIO_I2C_H > + > +#include > + > +/* The bit 0 of the @virtio_i2c_out_hdr.@flags, used to group the requests */ > +#define VIRTIO_I2C_FLAGS_FAIL_NEXT 0x00000001 > + > +/** > + * struct virtio_i2c_out_hdr - the virtio I2C message OUT header > + * @addr: the controlled device address > + * @padding: used to pad to full dword > + * @flags: used for feature extensibility > + */ > +struct virtio_i2c_out_hdr { > + __le16 addr; > + __le16 padding; > + __le32 flags; > +}; > + > +/** > + * struct virtio_i2c_in_hdr - the virtio I2C message IN header > + * @status: the processing result from the backend > + */ > +struct virtio_i2c_in_hdr { > + __u8 status; > +}; > + > +/* The final status written by the device */ > +#define VIRTIO_I2C_MSG_OK 0 > +#define VIRTIO_I2C_MSG_ERR 1 > + > +#endif /* _UAPI_LINUX_VIRTIO_I2C_H */ > diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h > index bc1c062..b89391d 100644 > --- a/include/uapi/linux/virtio_ids.h > +++ b/include/uapi/linux/virtio_ids.h > @@ -54,5 +54,6 @@ > #define VIRTIO_ID_FS 26 /* virtio filesystem */ > #define VIRTIO_ID_PMEM 27 /* virtio pmem */ > #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */ > +#define VIRTIO_ID_I2C_ADAPTER 34 /* virtio i2c adapter */ > > #endif /* _LINUX_VIRTIO_IDS_H */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C4BDC433B4 for ; Thu, 15 Apr 2021 03:51:59 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04ADD6124B for ; Thu, 15 Apr 2021 03:51:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04ADD6124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AF91560AD3; Thu, 15 Apr 2021 03:51:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wiqqQy8Fosxx; Thu, 15 Apr 2021 03:51:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id DB8E16075D; Thu, 15 Apr 2021 03:51:56 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BBF89C000F; Thu, 15 Apr 2021 03:51:56 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 40CDBC000A for ; Thu, 15 Apr 2021 03:51:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2EF54402E9 for ; Thu, 15 Apr 2021 03:51:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2nm9KE6wMFBC for ; Thu, 15 Apr 2021 03:51:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id AB7F8401F4 for ; Thu, 15 Apr 2021 03:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618458713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XcVd67igXG+x7EhtNoBXYI6tu8yQc7FQQDvtAR2BYPk=; b=BKR65zVDp1OIJPmBhWUcv5XRO4rvmoOTG73PUCv5psnoacWq4U/+5DP4XyuYq016FavAoR JbkRXWyoO0ojBQ5n+o5NluukqfVbVcfIuO04CblwX3L8c7E5WaDhBI6DLopjRH4UXYrsfh 19ZF6r4ZgkrANs2FhCX5vuyTpYHyfc8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-UJ5DRA2FPE6MR6yTLkxMGw-1; Wed, 14 Apr 2021 23:51:49 -0400 X-MC-Unique: UJ5DRA2FPE6MR6yTLkxMGw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C3B210053E6; Thu, 15 Apr 2021 03:51:46 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-220.pek2.redhat.com [10.72.13.220]) by smtp.corp.redhat.com (Postfix) with ESMTP id B61336E50A; Thu, 15 Apr 2021 03:51:27 +0000 (UTC) Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver To: Jie Deng , linux-i2c@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> From: Jason Wang Message-ID: Date: Thu, 15 Apr 2021 11:51:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Cc: Sergey.Semin@baikalelectronics.ru, bjorn.andersson@linaro.org, loic.poulain@linaro.org, yu1.wang@intel.com, arnd@arndb.de, mst@redhat.com, viresh.kumar@linaro.org, shuo.a.liu@intel.com, tali.perry1@gmail.com, wsa@kernel.org, wsa+renesas@sang-engineering.com, pbonzini@redhat.com, jarkko.nikula@linux.intel.com, stefanha@redhat.com, u.kleine-koenig@pengutronix.de, kblaiech@mellanox.com, andriy.shevchenko@linux.intel.com, conghui.chen@intel.com, rppt@kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CtTaIDIwMjEvMy8yMyDPws7nMTA6MTksIEppZSBEZW5nINC0tcA6Cj4gQWRkIGFuIEkyQyBidXMg ZHJpdmVyIGZvciB2aXJ0aW8gcGFyYS12aXJ0dWFsaXphdGlvbi4KPgo+IFRoZSBjb250cm9sbGVy IGNhbiBiZSBlbXVsYXRlZCBieSB0aGUgYmFja2VuZCBkcml2ZXIgaW4KPiBhbnkgZGV2aWNlIG1v ZGVsIHNvZnR3YXJlIGJ5IGZvbGxvd2luZyB0aGUgdmlydGlvIHByb3RvY29sLgo+Cj4gVGhlIGRl dmljZSBzcGVjaWZpY2F0aW9uIGNhbiBiZSBmb3VuZCBvbgo+IGh0dHBzOi8vbGlzdHMub2FzaXMt b3Blbi5vcmcvYXJjaGl2ZXMvdmlydGlvLWNvbW1lbnQvMjAyMTAxL21zZzAwMDA4Lmh0bWwuCj4K PiBCeSBmb2xsb3dpbmcgdGhlIHNwZWNpZmljYXRpb24sIHBlb3BsZSBtYXkgaW1wbGVtZW50IGRp ZmZlcmVudAo+IGJhY2tlbmQgZHJpdmVycyB0byBlbXVsYXRlIGRpZmZlcmVudCBjb250cm9sbGVy cyBhY2NvcmRpbmcgdG8KPiB0aGVpciBuZWVkcy4KPgo+IENvLWRldmVsb3BlZC1ieTogQ29uZ2h1 aSBDaGVuIDxjb25naHVpLmNoZW5AaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IENvbmdodWkg Q2hlbiA8Y29uZ2h1aS5jaGVuQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKaWUgRGVuZyA8 amllLmRlbmdAaW50ZWwuY29tPgo+IC0tLQo+IENoYW5nZXMgaW4gdjEwOgo+ICAgICAgICAgIC0g Rml4IHNvbWUgdHlwbyBlcnJvcnMuCj4gICAgICAgICAgLSBSZWZpbmVkIHRoZSB2aXJ0aW9faTJj X2NvbXBsZXRlX3JlcXMgdG8gdXNlIGxlc3MgY29kZSBsaW5lcy4KPgo+IENoYW5nZXMgaW4gdjk6 Cj4gICAgICAgICAgLSBSZW1vdmUgdGhlIHZpcnRpb19hZGFwdGVyIGFuZCB1cGRhdGUgaXRzIG1l bWJlcnMgaW4gcHJvYmUuCj4gICAgICAgICAgLSBSZWZpbmVkIHRoZSB2aXJ0aW9faTJjX2NvbXBs ZXRlX3JlcXMgZm9yIGJ1ZiBmcmVlLgo+Cj4gQ2hhbmdlcyBpbiB2ODoKPiAgICAgICAgICAtIE1h a2UgdmlydGlvX2kyYy5hZGFwIGEgcG9pbnRlci4KPiAgICAgICAgICAtIE1hcmsgbWVtYmVycyBp biB2aXJ0aW9faTJjX3JlcSB3aXRoIF9fX19jYWNoZWxpbmVfYWxpZ25lZC4KPgo+IENoYW5nZXMg aW4gdjc6Cj4gICAgICAgICAgLSBSZW1vdmUgdW51c2VkIGhlYWRlcnMuCj4gICAgICAgICAgLSBV cGRhdGUgTWFrZWZpbGUgYW5kIEtjb25maWcuCj4gICAgICAgICAgLSBBZGQgdGhlIGNsZWFudXAg YWZ0ZXIgY29tcGxldGluZyByZXFzLgo+ICAgICAgICAgIC0gQXZvaWQgbWVtY3B5IGZvciBkYXRh IG1hcmtlZCB3aXRoIEkyQ19NX0RNQV9TQUZFLgo+ICAgICAgICAgIC0gRml4IHNvbWV0aGluZyBy ZXBvcnRlZCBieSBrZXJuZWwgdGVzdCByb2JvdC4KPgo+IENoYW5nZXMgaW4gdjY6Cj4gICAgICAg ICAgLSBNb3ZlIHN0cnVjdCB2aXJ0aW9faTJjX3JlcSBpbnRvIHRoZSBkcml2ZXIuCj4gICAgICAg ICAgLSBVc2Ugb25seSBvbmUgYnVmIGluIHN0cnVjdCB2aXJ0aW9faTJjX3JlcS4KPgo+IENoYW5n ZXMgaW4gdjU6Cj4gICAgICAgICAgLSBUaGUgZmlyc3QgdmVyc2lvbiBiYXNlZCBvbiB0aGUgYWNr ZWQgc3BlY2lmaWNhdGlvbi4KPgo+ICAgZHJpdmVycy9pMmMvYnVzc2VzL0tjb25maWcgICAgICB8 ICAxMSArKwo+ICAgZHJpdmVycy9pMmMvYnVzc2VzL01ha2VmaWxlICAgICB8ICAgMyArCj4gICBk cml2ZXJzL2kyYy9idXNzZXMvaTJjLXZpcnRpby5jIHwgMjc2ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiAgIGluY2x1ZGUvdWFwaS9saW51eC92aXJ0aW9faTJjLmgg fCAgNDAgKysrKysrCj4gICBpbmNsdWRlL3VhcGkvbGludXgvdmlydGlvX2lkcy5oIHwgICAxICsK PiAgIDUgZmlsZXMgY2hhbmdlZCwgMzMxIGluc2VydGlvbnMoKykKPiAgIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL2kyYy9idXNzZXMvaTJjLXZpcnRpby5jCj4gICBjcmVhdGUgbW9kZSAxMDA2 NDQgaW5jbHVkZS91YXBpL2xpbnV4L3ZpcnRpb19pMmMuaAo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvaTJjL2J1c3Nlcy9LY29uZmlnIGIvZHJpdmVycy9pMmMvYnVzc2VzL0tjb25maWcKPiBpbmRl eCAwNWViZjc1Li5jYjhkMGQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaTJjL2J1c3Nlcy9LY29u ZmlnCj4gKysrIGIvZHJpdmVycy9pMmMvYnVzc2VzL0tjb25maWcKPiBAQCAtMjEsNiArMjEsMTcg QEAgY29uZmlnIEkyQ19BTEkxNTM1Cj4gICAJICBUaGlzIGRyaXZlciBjYW4gYWxzbyBiZSBidWls dCBhcyBhIG1vZHVsZS4gIElmIHNvLCB0aGUgbW9kdWxlCj4gICAJICB3aWxsIGJlIGNhbGxlZCBp MmMtYWxpMTUzNS4KPiAgIAo+ICtjb25maWcgSTJDX1ZJUlRJTwo+ICsJdHJpc3RhdGUgIlZpcnRp byBJMkMgQWRhcHRlciIKPiArCXNlbGVjdCBWSVJUSU8KPiArCWhlbHAKPiArCSAgSWYgeW91IHNh eSB5ZXMgdG8gdGhpcyBvcHRpb24sIHN1cHBvcnQgd2lsbCBiZSBpbmNsdWRlZCBmb3IgdGhlIHZp cnRpbwo+ICsJICBJMkMgYWRhcHRlciBkcml2ZXIuIFRoZSBoYXJkd2FyZSBjYW4gYmUgZW11bGF0 ZWQgYnkgYW55IGRldmljZSBtb2RlbAo+ICsJICBzb2Z0d2FyZSBhY2NvcmRpbmcgdG8gdGhlIHZp cnRpbyBwcm90b2NvbC4KPiArCj4gKwkgIFRoaXMgZHJpdmVyIGNhbiBhbHNvIGJlIGJ1aWx0IGFz IGEgbW9kdWxlLiBJZiBzbywgdGhlIG1vZHVsZQo+ICsJICB3aWxsIGJlIGNhbGxlZCBpMmMtdmly dGlvLgo+ICsKPiAgIGNvbmZpZyBJMkNfQUxJMTU2Mwo+ICAgCXRyaXN0YXRlICJBTEkgMTU2MyIK PiAgIAlkZXBlbmRzIG9uIFBDSQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2kyYy9idXNzZXMvTWFr ZWZpbGUgYi9kcml2ZXJzL2kyYy9idXNzZXMvTWFrZWZpbGUKPiBpbmRleCA2MTVmMzVlLi5lZmRk M2YzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvaTJjL2J1c3Nlcy9NYWtlZmlsZQo+ICsrKyBiL2Ry aXZlcnMvaTJjL2J1c3Nlcy9NYWtlZmlsZQo+IEBAIC0xNDUsNCArMTQ1LDcgQEAgb2JqLSQoQ09O RklHX0kyQ19YR0VORV9TTElNUFJPKSArPSBpMmMteGdlbmUtc2xpbXByby5vCj4gICBvYmotJChD T05GSUdfU0N4MjAwX0FDQikJKz0gc2N4MjAwX2FjYi5vCj4gICBvYmotJChDT05GSUdfSTJDX0ZT SSkJCSs9IGkyYy1mc2kubwo+ICAgCj4gKyMgVklSVElPIEkyQyBob3N0IGNvbnRyb2xsZXIgZHJp dmVyCj4gK29iai0kKENPTkZJR19JMkNfVklSVElPKQkrPSBpMmMtdmlydGlvLm8KPiArCj4gICBj Y2ZsYWdzLSQoQ09ORklHX0kyQ19ERUJVR19CVVMpIDo9IC1EREVCVUcKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9pMmMvYnVzc2VzL2kyYy12aXJ0aW8uYyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMt dmlydGlvLmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAuLjk5YTFlMzAK PiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy12aXJ0aW8uYwo+ IEBAIC0wLDAgKzEsMjc2IEBACj4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4w LW9yLWxhdGVyCj4gKy8qCj4gKyAqIFZpcnRpbyBJMkMgQnVzIERyaXZlcgo+ICsgKgo+ICsgKiBU aGUgVmlydGlvIEkyQyBTcGVjaWZpY2F0aW9uOgo+ICsgKiBodHRwczovL3Jhdy5naXRodWJ1c2Vy Y29udGVudC5jb20vb2FzaXMtdGNzL3ZpcnRpby1zcGVjL21hc3Rlci92aXJ0aW8taTJjLnRleAo+ ICsgKgo+ICsgKiBDb3B5cmlnaHQgKGMpIDIwMjEgSW50ZWwgQ29ycG9yYXRpb24uIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCj4gKyAqLwo+ICsKPiArI2luY2x1ZGUgPGxpbnV4L2FjcGkuaD4KPiArI2lu Y2x1ZGUgPGxpbnV4L2NvbXBsZXRpb24uaD4KPiArI2luY2x1ZGUgPGxpbnV4L2Vyci5oPgo+ICsj aW5jbHVkZSA8bGludXgvaTJjLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9rZXJuZWwuaD4KPiArI2lu Y2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvdmlydGlvLmg+Cj4gKyNp bmNsdWRlIDxsaW51eC92aXJ0aW9faWRzLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC92aXJ0aW9fY29u ZmlnLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC92aXJ0aW9faTJjLmg+Cj4gKwo+ICsvKioKPiArICog c3RydWN0IHZpcnRpb19pMmMgLSB2aXJ0aW8gSTJDIGRhdGEKPiArICogQHZkZXY6IHZpcnRpbyBk ZXZpY2UgZm9yIHRoaXMgY29udHJvbGxlcgo+ICsgKiBAY29tcGxldGlvbjogY29tcGxldGlvbiBv ZiB2aXJ0aW8gSTJDIG1lc3NhZ2UKPiArICogQGFkYXA6IEkyQyBhZGFwdGVyIGZvciB0aGlzIGNv bnRyb2xsZXIKPiArICogQGxvY2s6IGxvY2sgZm9yIHZpcnRxdWV1ZSBwcm9jZXNzaW5nCj4gKyAq IEB2cTogdGhlIHZpcnRpbyB2aXJ0cXVldWUgZm9yIGNvbW11bmljYXRpb24KPiArICovCj4gK3N0 cnVjdCB2aXJ0aW9faTJjIHsKPiArCXN0cnVjdCB2aXJ0aW9fZGV2aWNlICp2ZGV2Owo+ICsJc3Ry dWN0IGNvbXBsZXRpb24gY29tcGxldGlvbjsKPiArCXN0cnVjdCBpMmNfYWRhcHRlciBhZGFwOwo+ ICsJc3RydWN0IG11dGV4IGxvY2s7Cj4gKwlzdHJ1Y3QgdmlydHF1ZXVlICp2cTsKPiArfTsKPiAr Cj4gKy8qKgo+ICsgKiBzdHJ1Y3QgdmlydGlvX2kyY19yZXEgLSB0aGUgdmlydGlvIEkyQyByZXF1 ZXN0IHN0cnVjdHVyZQo+ICsgKiBAb3V0X2hkcjogdGhlIE9VVCBoZWFkZXIgb2YgdGhlIHZpcnRp byBJMkMgbWVzc2FnZQo+ICsgKiBAYnVmOiB0aGUgYnVmZmVyIGludG8gd2hpY2ggZGF0YSBpcyBy ZWFkLCBvciBmcm9tIHdoaWNoIGl0J3Mgd3JpdHRlbgo+ICsgKiBAaW5faGRyOiB0aGUgSU4gaGVh ZGVyIG9mIHRoZSB2aXJ0aW8gSTJDIG1lc3NhZ2UKPiArICovCj4gK3N0cnVjdCB2aXJ0aW9faTJj X3JlcSB7Cj4gKwlzdHJ1Y3QgdmlydGlvX2kyY19vdXRfaGRyIG91dF9oZHIJX19fX2NhY2hlbGlu ZV9hbGlnbmVkOwo+ICsJdWludDhfdCAqYnVmCQkJCV9fX19jYWNoZWxpbmVfYWxpZ25lZDsKPiAr CXN0cnVjdCB2aXJ0aW9faTJjX2luX2hkciBpbl9oZHIJCV9fX19jYWNoZWxpbmVfYWxpZ25lZDsK PiArfTsKPiArCj4gK3N0YXRpYyB2b2lkIHZpcnRpb19pMmNfbXNnX2RvbmUoc3RydWN0IHZpcnRx dWV1ZSAqdnEpCj4gK3sKPiArCXN0cnVjdCB2aXJ0aW9faTJjICp2aSA9IHZxLT52ZGV2LT5wcml2 Owo+ICsKPiArCWNvbXBsZXRlKCZ2aS0+Y29tcGxldGlvbik7Cj4gK30KPiArCj4gK3N0YXRpYyBp bnQgdmlydGlvX2kyY19zZW5kX3JlcXMoc3RydWN0IHZpcnRxdWV1ZSAqdnEsCj4gKwkJCQlzdHJ1 Y3QgdmlydGlvX2kyY19yZXEgKnJlcXMsCj4gKwkJCQlzdHJ1Y3QgaTJjX21zZyAqbXNncywgaW50 IG5yKQo+ICt7Cj4gKwlzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnc1szXSwgb3V0X2hkciwgbXNnX2J1 ZiwgaW5faGRyOwo+ICsJaW50IGksIG91dGNudCwgaW5jbnQsIGVyciA9IDA7Cj4gKwo+ICsJZm9y IChpID0gMDsgaSA8IG5yOyBpKyspIHsKPiArCQlpZiAoIW1zZ3NbaV0ubGVuKQo+ICsJCQlicmVh azsKPiArCj4gKwkJLyoKPiArCQkgKiBPbmx5IDctYml0IG1vZGUgc3VwcG9ydGVkIGZvciB0aGlz IG1vbWVudC4gRm9yIHRoZSBhZGRyZXNzIGZvcm1hdCwKPiArCQkgKiBQbGVhc2UgY2hlY2sgdGhl IFZpcnRpbyBJMkMgU3BlY2lmaWNhdGlvbi4KPiArCQkgKi8KPiArCQlyZXFzW2ldLm91dF9oZHIu YWRkciA9IGNwdV90b19sZTE2KG1zZ3NbaV0uYWRkciA8PCAxKTsKPiArCj4gKwkJaWYgKGkgIT0g bnIgLSAxKQo+ICsJCQlyZXFzW2ldLm91dF9oZHIuZmxhZ3MgPSBjcHVfdG9fbGUzMihWSVJUSU9f STJDX0ZMQUdTX0ZBSUxfTkVYVCk7Cj4gKwo+ICsJCW91dGNudCA9IGluY250ID0gMDsKPiArCQlz Z19pbml0X29uZSgmb3V0X2hkciwgJnJlcXNbaV0ub3V0X2hkciwgc2l6ZW9mKHJlcXNbaV0ub3V0 X2hkcikpOwo+ICsJCXNnc1tvdXRjbnQrK10gPSAmb3V0X2hkcjsKPiArCj4gKwkJcmVxc1tpXS5i dWYgPSBpMmNfZ2V0X2RtYV9zYWZlX21zZ19idWYoJm1zZ3NbaV0sIDEpOwo+ICsJCWlmICghcmVx c1tpXS5idWYpCj4gKwkJCWJyZWFrOwo+ICsKPiArCQlzZ19pbml0X29uZSgmbXNnX2J1ZiwgcmVx c1tpXS5idWYsIG1zZ3NbaV0ubGVuKTsKPiArCj4gKwkJaWYgKG1zZ3NbaV0uZmxhZ3MgJiBJMkNf TV9SRCkKPiArCQkJc2dzW291dGNudCArIGluY250KytdID0gJm1zZ19idWY7Cj4gKwkJZWxzZQo+ ICsJCQlzZ3Nbb3V0Y250KytdID0gJm1zZ19idWY7Cj4gKwo+ICsJCXNnX2luaXRfb25lKCZpbl9o ZHIsICZyZXFzW2ldLmluX2hkciwgc2l6ZW9mKHJlcXNbaV0uaW5faGRyKSk7Cj4gKwkJc2dzW291 dGNudCArIGluY250KytdID0gJmluX2hkcjsKPiArCj4gKwkJZXJyID0gdmlydHF1ZXVlX2FkZF9z Z3ModnEsIHNncywgb3V0Y250LCBpbmNudCwgJnJlcXNbaV0sIEdGUF9LRVJORUwpOwo+ICsJCWlm IChlcnIgPCAwKSB7Cj4gKwkJCXByX2VycigiZmFpbGVkIHRvIGFkZCBtc2dbJWRdIHRvIHZpcnRx dWV1ZS5cbiIsIGkpOwo+ICsJCQlpMmNfcHV0X2RtYV9zYWZlX21zZ19idWYocmVxc1tpXS5idWYs ICZtc2dzW2ldLCBmYWxzZSk7Cj4gKwkJCWJyZWFrOwo+ICsJCX0KPiArCX0KPiArCj4gKwlyZXR1 cm4gaTsKPiArfQo+ICsKPiArc3RhdGljIGludCB2aXJ0aW9faTJjX2NvbXBsZXRlX3JlcXMoc3Ry dWN0IHZpcnRxdWV1ZSAqdnEsCj4gKwkJCQkgICAgc3RydWN0IHZpcnRpb19pMmNfcmVxICpyZXFz LAo+ICsJCQkJICAgIHN0cnVjdCBpMmNfbXNnICptc2dzLCBpbnQgbnIsCj4gKwkJCQkgICAgYm9v bCB0aW1lb3V0KQo+ICt7Cj4gKwlzdHJ1Y3QgdmlydGlvX2kyY19yZXEgKnJlcTsKPiArCWJvb2wg ZmFpbGVkID0gdGltZW91dDsKPiArCXVuc2lnbmVkIGludCBsZW47Cj4gKwlpbnQgaSwgaiA9IDA7 Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IG5yOyBpKyspIHsKPiArCQkvKiBEZXRhY2ggdGhlIGl0 aCByZXF1ZXN0IGZyb20gdGhlIHZxICovCj4gKwkJcmVxID0gdmlydHF1ZXVlX2dldF9idWYodnEs ICZsZW4pOwo+ICsKPiArCQkvKgo+ICsJCSAqIENvbmRpdGlvbiAocmVxICYmIHJlcSA9PSAmcmVx c1tpXSkgc2hvdWxkIGFsd2F5cyBtZWV0IHNpbmNlCj4gKwkJICogd2UgaGF2ZSB0b3RhbCBuciBy ZXF1ZXN0cyBpbiB0aGUgdnEuCgoKU28gdGhpcyBhc3N1bWVzIHRoZSByZXF1ZXN0cyBhcmUgY29t cGxldGVkIGluIG9yZGVyLiBJcyB0aGlzIG1hbmRhdGVkIGluIAp0aGUgc3BlYz8KCgo+ICsJCSAq Lwo+ICsJCWlmICghZmFpbGVkICYmIChXQVJOX09OKCEocmVxICYmIHJlcSA9PSAmcmVxc1tpXSkp IHx8Cj4gKwkJICAgIChyZXEtPmluX2hkci5zdGF0dXMgIT0gVklSVElPX0kyQ19NU0dfT0spKSkK PiArCQkJZmFpbGVkID0gdHJ1ZTsKPiArCj4gKwkJaTJjX3B1dF9kbWFfc2FmZV9tc2dfYnVmKHJl cXNbaV0uYnVmLCAmbXNnc1tpXSwgIWZhaWxlZCk7Cj4gKwkJaWYgKCFmYWlsZWQpCj4gKwkJCSsr ajsKPiArCX0KPiArCj4gKwlyZXR1cm4gKHRpbWVvdXQgPyAtRVRJTUVET1VUIDogaik7CgoKQ2hl Y2tpbmcgdGltZW91dCBpcyBmcmFnaWxlLCB3aGF0IGhhcHBlbnMgaWYgdGhlIHJlcXVlc3QgYXJl IGNvbXBsZXRlZCAKYWZ0ZXIgd2FpdF9mb3JfY29tcGxldGlvbigpIGJ1dCBiZWZvcmUgdmlydGlv X2kyY19jb21wbGV0ZV9yZXFzKCk/CgoKPiArfQo+ICsKPiArc3RhdGljIGludCB2aXJ0aW9faTJj X3hmZXIoc3RydWN0IGkyY19hZGFwdGVyICphZGFwLCBzdHJ1Y3QgaTJjX21zZyAqbXNncywgaW50 IG51bSkKPiArewo+ICsJc3RydWN0IHZpcnRpb19pMmMgKnZpID0gaTJjX2dldF9hZGFwZGF0YShh ZGFwKTsKPiArCXN0cnVjdCB2aXJ0cXVldWUgKnZxID0gdmktPnZxOwo+ICsJc3RydWN0IHZpcnRp b19pMmNfcmVxICpyZXFzOwo+ICsJdW5zaWduZWQgbG9uZyB0aW1lX2xlZnQ7Cj4gKwlpbnQgcmV0 LCBucjsKPiArCj4gKwlyZXFzID0ga2NhbGxvYyhudW0sIHNpemVvZigqcmVxcyksIEdGUF9LRVJO RUwpOwo+ICsJaWYgKCFyZXFzKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCW11dGV4X2xv Y2soJnZpLT5sb2NrKTsKPiArCj4gKwlyZXQgPSB2aXJ0aW9faTJjX3NlbmRfcmVxcyh2cSwgcmVx cywgbXNncywgbnVtKTsKPiArCWlmIChyZXQgPT0gMCkKPiArCQlnb3RvIGVycl91bmxvY2tfZnJl ZTsKPiArCj4gKwluciA9IHJldDsKPiArCXJlaW5pdF9jb21wbGV0aW9uKCZ2aS0+Y29tcGxldGlv bik7Cj4gKwl2aXJ0cXVldWVfa2ljayh2cSk7Cj4gKwo+ICsJdGltZV9sZWZ0ID0gd2FpdF9mb3Jf Y29tcGxldGlvbl90aW1lb3V0KCZ2aS0+Y29tcGxldGlvbiwgYWRhcC0+dGltZW91dCk7Cj4gKwlp ZiAoIXRpbWVfbGVmdCkKPiArCQlkZXZfZXJyKCZhZGFwLT5kZXYsICJ2aXJ0aW8gaTJjIGJhY2tl bmQgdGltZW91dC5cbiIpOwo+ICsKPiArCXJldCA9IHZpcnRpb19pMmNfY29tcGxldGVfcmVxcyh2 cSwgcmVxcywgbXNncywgbnIsICF0aW1lX2xlZnQpOwo+ICsKPiArZXJyX3VubG9ja19mcmVlOgo+ ICsJbXV0ZXhfdW5sb2NrKCZ2aS0+bG9jayk7Cj4gKwlrZnJlZShyZXFzKTsKPiArCXJldHVybiBy ZXQ7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIHZpcnRpb19pMmNfZGVsX3ZxcyhzdHJ1Y3Qgdmly dGlvX2RldmljZSAqdmRldikKPiArewo+ICsJdmRldi0+Y29uZmlnLT5yZXNldCh2ZGV2KTsKPiAr CXZkZXYtPmNvbmZpZy0+ZGVsX3Zxcyh2ZGV2KTsKPiArfQo+ICsKPiArc3RhdGljIGludCB2aXJ0 aW9faTJjX3NldHVwX3ZxcyhzdHJ1Y3QgdmlydGlvX2kyYyAqdmkpCj4gK3sKPiArCXN0cnVjdCB2 aXJ0aW9fZGV2aWNlICp2ZGV2ID0gdmktPnZkZXY7Cj4gKwo+ICsJdmktPnZxID0gdmlydGlvX2Zp bmRfc2luZ2xlX3ZxKHZkZXYsIHZpcnRpb19pMmNfbXNnX2RvbmUsICJtc2ciKTsKPiArCXJldHVy biBQVFJfRVJSX09SX1pFUk8odmktPnZxKTsKPiArfQo+ICsKPiArc3RhdGljIHUzMiB2aXJ0aW9f aTJjX2Z1bmMoc3RydWN0IGkyY19hZGFwdGVyICphZGFwKQo+ICt7Cj4gKwlyZXR1cm4gSTJDX0ZV TkNfSTJDIHwgSTJDX0ZVTkNfU01CVVNfRU1VTDsKPiArfQo+ICsKPiArc3RhdGljIHN0cnVjdCBp MmNfYWxnb3JpdGhtIHZpcnRpb19hbGdvcml0aG0gPSB7Cj4gKwkubWFzdGVyX3hmZXIgPSB2aXJ0 aW9faTJjX3hmZXIsCj4gKwkuZnVuY3Rpb25hbGl0eSA9IHZpcnRpb19pMmNfZnVuYywKPiArfTsK PiArCj4gK3N0YXRpYyBpbnQgdmlydGlvX2kyY19wcm9iZShzdHJ1Y3QgdmlydGlvX2RldmljZSAq dmRldikKPiArewo+ICsJc3RydWN0IGRldmljZSAqcGRldiA9IHZkZXYtPmRldi5wYXJlbnQ7Cj4g KwlzdHJ1Y3QgdmlydGlvX2kyYyAqdmk7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXZpID0gZGV2bV9r emFsbG9jKCZ2ZGV2LT5kZXYsIHNpemVvZigqdmkpLCBHRlBfS0VSTkVMKTsKPiArCWlmICghdmkp Cj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwo+ICsJdmRldi0+cHJpdiA9IHZpOwo+ICsJdmktPnZk ZXYgPSB2ZGV2Owo+ICsKPiArCW11dGV4X2luaXQoJnZpLT5sb2NrKTsKPiArCWluaXRfY29tcGxl dGlvbigmdmktPmNvbXBsZXRpb24pOwo+ICsKPiArCXJldCA9IHZpcnRpb19pMmNfc2V0dXBfdnFz KHZpKTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwl2aS0+YWRhcC5vd25l ciA9IFRISVNfTU9EVUxFOwo+ICsJc25wcmludGYodmktPmFkYXAubmFtZSwgc2l6ZW9mKHZpLT5h ZGFwLm5hbWUpLCAiVmlydGlvIEkyQyBBZGFwdGVyIik7Cj4gKwl2aS0+YWRhcC5jbGFzcyA9IEky Q19DTEFTU19ERVBSRUNBVEVEOwo+ICsJdmktPmFkYXAuYWxnbyA9ICZ2aXJ0aW9fYWxnb3JpdGht Owo+ICsJdmktPmFkYXAuZGV2LnBhcmVudCA9ICZ2ZGV2LT5kZXY7Cj4gKwl2aS0+YWRhcC50aW1l b3V0ID0gSFogLyAxMDsKPiArCWkyY19zZXRfYWRhcGRhdGEoJnZpLT5hZGFwLCB2aSk7Cj4gKwo+ ICsJLyogU2V0dXAgQUNQSSBub2RlIGZvciBjb250cm9sbGVkIGRldmljZXMgd2hpY2ggd2lsbCBi ZSBwcm9iZWQgdGhyb3VnaCBBQ1BJICovCj4gKwlBQ1BJX0NPTVBBTklPTl9TRVQoJnZpLT5hZGFw LmRldiwgQUNQSV9DT01QQU5JT04ocGRldikpOwo+ICsKPiArCXJldCA9IGkyY19hZGRfYWRhcHRl cigmdmktPmFkYXApOwo+ICsJaWYgKHJldCkgewo+ICsJCXZpcnRpb19pMmNfZGVsX3Zxcyh2ZGV2 KTsKPiArCQlkZXZfZXJyKCZ2ZGV2LT5kZXYsICJmYWlsZWQgdG8gYWRkIHZpcnRpby1pMmMgYWRh cHRlci5cbiIpOwo+ICsJfQo+ICsKPiArCXJldHVybiByZXQ7Cj4gK30KPiArCj4gK3N0YXRpYyB2 b2lkIHZpcnRpb19pMmNfcmVtb3ZlKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICp2ZGV2KQo+ICt7Cj4g KwlzdHJ1Y3QgdmlydGlvX2kyYyAqdmkgPSB2ZGV2LT5wcml2Owo+ICsKPiArCWkyY19kZWxfYWRh cHRlcigmdmktPmFkYXApOwo+ICsJdmlydGlvX2kyY19kZWxfdnFzKHZkZXYpOwo+ICt9Cj4gKwo+ ICtzdGF0aWMgc3RydWN0IHZpcnRpb19kZXZpY2VfaWQgaWRfdGFibGVbXSA9IHsKPiArCXsgVklS VElPX0lEX0kyQ19BREFQVEVSLCBWSVJUSU9fREVWX0FOWV9JRCB9LAo+ICsJe30KPiArfTsKPiAr TU9EVUxFX0RFVklDRV9UQUJMRSh2aXJ0aW8sIGlkX3RhYmxlKTsKPiArCj4gK3N0YXRpYyBpbnQg X19tYXliZV91bnVzZWQgdmlydGlvX2kyY19mcmVlemUoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZk ZXYpCj4gK3sKPiArCXZpcnRpb19pMmNfZGVsX3Zxcyh2ZGV2KTsKPiArCXJldHVybiAwOwo+ICt9 Cj4gKwo+ICtzdGF0aWMgaW50IF9fbWF5YmVfdW51c2VkIHZpcnRpb19pMmNfcmVzdG9yZShzdHJ1 Y3QgdmlydGlvX2RldmljZSAqdmRldikKPiArewo+ICsJcmV0dXJuIHZpcnRpb19pMmNfc2V0dXBf dnFzKHZkZXYtPnByaXYpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgc3RydWN0IHZpcnRpb19kcml2ZXIg dmlydGlvX2kyY19kcml2ZXIgPSB7Cj4gKwkuaWRfdGFibGUJPSBpZF90YWJsZSwKPiArCS5wcm9i ZQkJPSB2aXJ0aW9faTJjX3Byb2JlLAo+ICsJLnJlbW92ZQkJPSB2aXJ0aW9faTJjX3JlbW92ZSwK PiArCS5kcml2ZXIJPSB7Cj4gKwkJLm5hbWUJPSAiaTJjX3ZpcnRpbyIsCj4gKwl9LAo+ICsjaWZk ZWYgQ09ORklHX1BNX1NMRUVQCj4gKwkuZnJlZXplID0gdmlydGlvX2kyY19mcmVlemUsCj4gKwku cmVzdG9yZSA9IHZpcnRpb19pMmNfcmVzdG9yZSwKPiArI2VuZGlmCj4gK307Cj4gK21vZHVsZV92 aXJ0aW9fZHJpdmVyKHZpcnRpb19pMmNfZHJpdmVyKTsKPiArCj4gK01PRFVMRV9BVVRIT1IoIkpp ZSBEZW5nIDxqaWUuZGVuZ0BpbnRlbC5jb20+Iik7Cj4gK01PRFVMRV9BVVRIT1IoIkNvbmdodWkg Q2hlbiA8Y29uZ2h1aS5jaGVuQGludGVsLmNvbT4iKTsKPiArTU9EVUxFX0RFU0NSSVBUSU9OKCJW aXJ0aW8gaTJjIGJ1cyBkcml2ZXIiKTsKPiArTU9EVUxFX0xJQ0VOU0UoIkdQTCIpOwo+IGRpZmYg LS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvdmlydGlvX2kyYy5oIGIvaW5jbHVkZS91YXBpL2xp bnV4L3ZpcnRpb19pMmMuaAo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMC4u YmJjZmIyYwo+IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNsdWRlL3VhcGkvbGludXgvdmlydGlv X2kyYy5oCj4gQEAgLTAsMCArMSw0MCBAQAo+ICsvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjog R1BMLTIuMC1vci1sYXRlciBXSVRIIExpbnV4LXN5c2NhbGwtbm90ZSAqLwo+ICsvKgo+ICsgKiBE ZWZpbml0aW9ucyBmb3IgdmlydGlvIEkyQyBBZHB0ZXIKPiArICoKPiArICogQ29weXJpZ2h0IChj KSAyMDIxIEludGVsIENvcnBvcmF0aW9uLiBBbGwgcmlnaHRzIHJlc2VydmVkLgo+ICsgKi8KPiAr Cj4gKyNpZm5kZWYgX1VBUElfTElOVVhfVklSVElPX0kyQ19ICj4gKyNkZWZpbmUgX1VBUElfTElO VVhfVklSVElPX0kyQ19ICj4gKwo+ICsjaW5jbHVkZSA8bGludXgvdHlwZXMuaD4KPiArCj4gKy8q IFRoZSBiaXQgMCBvZiB0aGUgQHZpcnRpb19pMmNfb3V0X2hkci5AZmxhZ3MsIHVzZWQgdG8gZ3Jv dXAgdGhlIHJlcXVlc3RzICovCj4gKyNkZWZpbmUgVklSVElPX0kyQ19GTEFHU19GQUlMX05FWFQJ MHgwMDAwMDAwMQo+ICsKPiArLyoqCj4gKyAqIHN0cnVjdCB2aXJ0aW9faTJjX291dF9oZHIgLSB0 aGUgdmlydGlvIEkyQyBtZXNzYWdlIE9VVCBoZWFkZXIKPiArICogQGFkZHI6IHRoZSBjb250cm9s bGVkIGRldmljZSBhZGRyZXNzCj4gKyAqIEBwYWRkaW5nOiB1c2VkIHRvIHBhZCB0byBmdWxsIGR3 b3JkCj4gKyAqIEBmbGFnczogdXNlZCBmb3IgZmVhdHVyZSBleHRlbnNpYmlsaXR5Cj4gKyAqLwo+ ICtzdHJ1Y3QgdmlydGlvX2kyY19vdXRfaGRyIHsKPiArCV9fbGUxNiBhZGRyOwo+ICsJX19sZTE2 IHBhZGRpbmc7Cj4gKwlfX2xlMzIgZmxhZ3M7Cj4gK307Cj4gKwo+ICsvKioKPiArICogc3RydWN0 IHZpcnRpb19pMmNfaW5faGRyIC0gdGhlIHZpcnRpbyBJMkMgbWVzc2FnZSBJTiBoZWFkZXIKPiAr ICogQHN0YXR1czogdGhlIHByb2Nlc3NpbmcgcmVzdWx0IGZyb20gdGhlIGJhY2tlbmQKPiArICov Cj4gK3N0cnVjdCB2aXJ0aW9faTJjX2luX2hkciB7Cj4gKwlfX3U4IHN0YXR1czsKPiArfTsKPiAr Cj4gKy8qIFRoZSBmaW5hbCBzdGF0dXMgd3JpdHRlbiBieSB0aGUgZGV2aWNlICovCj4gKyNkZWZp bmUgVklSVElPX0kyQ19NU0dfT0sJMAo+ICsjZGVmaW5lIFZJUlRJT19JMkNfTVNHX0VSUgkxCj4g Kwo+ICsjZW5kaWYgLyogX1VBUElfTElOVVhfVklSVElPX0kyQ19IICovCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvdWFwaS9saW51eC92aXJ0aW9faWRzLmggYi9pbmNsdWRlL3VhcGkvbGludXgvdmly dGlvX2lkcy5oCj4gaW5kZXggYmMxYzA2Mi4uYjg5MzkxZCAxMDA2NDQKPiAtLS0gYS9pbmNsdWRl L3VhcGkvbGludXgvdmlydGlvX2lkcy5oCj4gKysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L3ZpcnRp b19pZHMuaAo+IEBAIC01NCw1ICs1NCw2IEBACj4gICAjZGVmaW5lIFZJUlRJT19JRF9GUwkJCTI2 IC8qIHZpcnRpbyBmaWxlc3lzdGVtICovCj4gICAjZGVmaW5lIFZJUlRJT19JRF9QTUVNCQkJMjcg LyogdmlydGlvIHBtZW0gKi8KPiAgICNkZWZpbmUgVklSVElPX0lEX01BQzgwMjExX0hXU0lNCTI5 IC8qIHZpcnRpbyBtYWM4MDIxMS1od3NpbSAqLwo+ICsjZGVmaW5lIFZJUlRJT19JRF9JMkNfQURB UFRFUgkJMzQgLyogdmlydGlvIGkyYyBhZGFwdGVyICovCj4gICAKPiAgICNlbmRpZiAvKiBfTElO VVhfVklSVElPX0lEU19IICovCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3Jn L21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=