From: "Cédric Le Goater" <firstname.lastname@example.org>
To: Christophe Leroy <email@example.com>,
"heying (H)" <firstname.lastname@example.org>, <email@example.com>,
Cc: firstname.lastname@example.org, email@example.com
Subject: Re: [PATCH] powerpc: Fix missing prototype problems for "arch/powerpc/kernel/setup_64.c"
Date: Mon, 15 Mar 2021 14:14:22 +0100 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On 3/15/21 2:01 PM, Christophe Leroy wrote:
> Le 15/03/2021 à 13:57, Cédric Le Goater a écrit :
>> On 3/15/21 1:48 PM, heying (H) wrote:
>>> 在 2021/3/15 20:17, Christophe Leroy 写道:
>>>> You subject doesn't match the content of the patch.
>>> OK. I'll adapt that.
>>>> Le 15/03/2021 à 13:04, He Ying a écrit :
>>>>> The variables 'uaccess_fulsh' and 'entry_flush' are not referenced
>>>>> outside the file. So define them as static to avoid the warnings.
>>>>> And add a prototype for the function 'panic_smp_self_stop' for the
>>>>> same purpose.
>>>>> Sparse also warns that 'rfi_flush' should be static. However, it's
>>>>> referenced outside the file.
>>>> To clear that warning, you have to include asm/security_features.h, rfi_flush is declared there.
>>> Do you mean that I should include this header in arch/powerpc/kernel/setup_64.c?
>>>>> The warnings about the file reported by sparse are as follows:
>>>>> arch/powerpc/kernel/setup_64.c:422:6: warning: symbol 'panic_smp_self_stop' was not declared. Should it be static?
>>>>> arch/powerpc/kernel/setup_64.c:951:6: warning: symbol 'rfi_flush' was not declared. Should it be static?
>>>>> arch/powerpc/kernel/setup_64.c:952:6: warning: symbol 'entry_flush' was not declared. Should it be static?
>>>>> arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' was not declared. Should it be static?
>>>>> Reported-by: Hulk Robot <email@example.com>
>>>>> Signed-off-by: He Ying <firstname.lastname@example.org>
>>>>> arch/powerpc/kernel/setup_64.c | 6 ++++--
>>>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>>> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
>>>>> index 560ed8b975e7..603aacd8527b 100644
>>>>> --- a/arch/powerpc/kernel/setup_64.c
>>>>> +++ b/arch/powerpc/kernel/setup_64.c
>>>>> @@ -71,6 +71,8 @@
>>>>> #include "setup.h"
>>>>> +extern void panic_smp_self_stop(void);
>>>> For function prototypes 'extern' is unneeded and deprecated.
>>>> And function prototypes should go in an header file.
>>>> panic_smp_self_stop() is called from kernel/panic.c , it should be declared in one of the generic linux header files I think.
>>> Yes, you're right. But I have no idea which header it should be declared in. May I have your suggestions?
>> arch/powerpc/include/asm/bug.h looks like a good place.
> Why declaring it in a powerpc header ?
> It's a weak function defined in core part of kernel (kernel/panic.c).
> I think it should go in a common header, just like for instance arch_thaw_secondary_cpus_begin()
Indeed. include/linux/smp.h is a better place for a common routine.
next prev parent reply other threads:[~2021-03-15 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 12:04 [PATCH] powerpc: Fix missing prototype problems for "arch/powerpc/kernel/setup_64.c" He Ying
2021-03-15 12:17 ` Christophe Leroy
2021-03-15 12:48 ` heying (H)
2021-03-15 12:57 ` Cédric Le Goater
2021-03-15 13:01 ` Christophe Leroy
2021-03-15 13:14 ` Cédric Le Goater [this message]
2021-03-16 2:04 ` heying (H)
2021-03-15 12:57 ` Christophe Leroy
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.