From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942635AbcJZMw0 (ORCPT ); Wed, 26 Oct 2016 08:52:26 -0400 Received: from mail-he1eur01on0105.outbound.protection.outlook.com ([104.47.0.105]:29696 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S942107AbcJZMvh (ORCPT ); Wed, 26 Oct 2016 08:51:37 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dsafonov@virtuozzo.com; Subject: Re: [tip:x86/vdso] x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_* To: Paul Bolle References: <20160905133308.28234-4-dsafonov@virtuozzo.com> <1477485030.1951.13.camel@tiscali.nl> From: Dmitry Safonov CC: , , , , , Message-ID: Date: Wed, 26 Oct 2016 15:49:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477485030.1951.13.camel@tiscali.nl> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: DB5PR10CA0002.EURPRD10.PROD.OUTLOOK.COM (10.165.4.140) To HE1PR0801MB1740.eurprd08.prod.outlook.com (10.168.150.7) X-MS-Office365-Filtering-Correlation-Id: 8cb276a7-a234-4355-80fe-08d3fd9ecfd5 X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1740;2:ila5LKSdfNv/OCSjcMMXsr6kOISQgCH3e3EBXd0CgX/MgJRiMKSIM01D+qadtD+Qq2g5BJ3PXF7eJNTUbDVeE3E4brsp0W98rnTzxn1P1QxxNwJNkGWddaJaiYcT2WiSqCuXD0Go61FuniBhnO79kO8uz+DKp1tltj9LKZW8+EoI29yskRJe/K1d0pyffw3pAYRYr6cO0cpDHj/vlaImVQ==;3:qDrZ+BQ7kqmGaSOQNfeNmRs2nrnO+FuIp+u1oLz2djOt7iTq98I4P75twrxtiTmssHDFmLUT7rZXMfJHGbviOVOP6futpTs3EF+90XwvPBw4Tv6pFLK8SRUDf2q8DOH2LltCRSyftFHu/9j8WgC24Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1740; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1740;25:iQdVXEGMFSkrgAyQixmJrUJ71QypDCvYjGmBdfqLHK7ici3A7/m/6g4j5W22YWhDD7+rBLB/J6OYeGA+vQryIJl6yPSIP27hzNZ6ZQc3Q6ciWCL8qtmzhPvIwiaFg3wYYXCl5EDT1sI7hkICfhYs1QhLVdWHUaTGFxM8jQJbPgyyQXMcjKvAEhvgHRl0lO517lNNZ+IipshsoIgRQaa2yK7lcfBkAsMnSwNmamNuj3RQSdM9n977Bcmney6+4uu65Hf59mJbpTUiSFi2LZwy+XnYlX6mvS9vQXTFmn3Z8rDGGefiQ8BOXUUlAaJs7fTl50X7DbZPu6lYzkOCH63EKBkvpzzSMuVf5zg5jW7Qsq7bvsKCHdykIjFGT+A8NLj2z86U4ap62pqO5A28TYJdAuMcqJARSkUCm0bTgyLiXtuwrkcTlaAyDLOo6Lk+0M7vr/CdblA1GYb8rqSBhOi1hSR2L6UiffK4GVzDQV5tjfdIVBUPwwxkoZtaP4a+TpPtSM0XOv0rR35oPljNQpJcwxO/mhGziL9bljAIf6koSBUoHS8B92CXpf4G9U7M2QPyzMmO6ts9j49RiprFXSB1MVFQu24HnZIPgkLleJ5dWpe7dT2T1OyQg8rKmF7q13WhsKq6rMjV7XEtHEdNARbvPuBCnlhSW4Srg2DiD7fjyCUfE8tvsqZXNzM2of8Dnlomo/xEZ+TgavTiatQfs0/dvUcfRt8iuPa3ddGszztreM6nRgriPe752+/43DVpsjMHh/nGeXNAEJ0wM7JgLdvki+h1OzfqS+/9D7eRIMe1Jd8= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1740;31:B878nsSD+PcirYHndKB7z7agNKnP381NA944LCagqWew9kdzc4cOANkTjUBopRd2ikht63uQhXajdxRj7BY1vnRwbZvxoRu47AXNmJmOAzIpPWVW+jYHZyEju30Iajzrw9cx9Rlynj9XayGWdbfTpJsxxBiz+rMimYAdceFFDRkP8FgAgcaY0g9hYNQOZ+1CrTiNTNvGkJcpHIFA7HmgK5hHiFzSRS0TUhzWYvIC1/URdTgBs4+j3v/fQIczNy8P;4:kDrBsryTkHIWTOCSaeH6+1H5xFgJG2huBNzUXZ69synvy6FPI6hdQZprPZKmfC4zM9aU6kYv0rioIxcphsOeYS3e+mIreZdaBcrjrpKkKML+uDSbOXpzPKFv2F3ICJ3vtj6835wQjzrTtA++33ktGWzL0sWmJCxKmYkCSpDZt/kOMh8ZYLwFjt+i01PXkU/Gyk/yfIYKLA4CCWsaoj+mjR74TNZ5IHVuaL6YyOQIj44Ezci5pTEQQtiW+t2dq87su45bBDv8qcbciCXxOhS79Kw9GLIbh9Az5DX2RqdS32QQxIrEHelBLzhsVRgyLibiNzYPdfO6PxWsZRIErw8xU/DqIXjLALuCsRQ07FIZrcG0NE2prYdLrcjSwuOm3AYtpB+cD9nctpehtXIiXkI0kcY94Umq2Da0kCQqdr8YpCwb6Ttl+Rj10zS2TG+TOOMEt3yKrn2ac2psWWUn98zvSs+md68BCT6aLd5z+xSPp+BLRHjKisa1m8UWhNsGyStlz7bjuDRCshf5f8Wr8FWQjg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42068640409301)(84791874153150); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6043046)(6042046);SRVR:HE1PR0801MB1740;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1740; X-Forefront-PRVS: 0107098B6C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(24454002)(377454003)(43784003)(189002)(377424004)(105586002)(81166006)(106356001)(2906002)(65956001)(575784001)(66066001)(110136003)(65806001)(6116002)(3846002)(86362001)(15975445007)(4326007)(23676002)(77096005)(54356999)(586003)(64126003)(1720100001)(101416001)(50466002)(50986999)(8676002)(83506001)(76176999)(6916009)(305945005)(42186005)(65826007)(31686004)(68736007)(230700001)(7736002)(81156014)(7846002)(31696002)(5660300001)(19580405001)(19580395003)(36756003)(4001350100001)(47776003)(97736004)(92566002)(2950100002)(33646002)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1740;H:[10.30.26.154];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA4MDFNQjE3NDA7MjM6aTZGd3lhMmVSMmhXTWlubFBBUXNIOHhG?= =?utf-8?B?T2Z6bmpaM2ZOVi91ZnZzVGFtblhsSC9TcDA0N3MzbmZybVJybGZLTWRac2lP?= =?utf-8?B?RmtqK1BaOFUwdWVvaXZEZ2puZFFQOTk2SUwrYTNHeW1wU1o1Q0tvcVI4TEph?= =?utf-8?B?RDJlZzFwT3ltN0VHcEFaZlErRWIxVmJzRHFSMUV4T3FLeFRLZENwY3l0V2hs?= =?utf-8?B?a2FQd09KVWtRa2VUcllMcmhvZDZaRmtWNnZKWU9PZjgvYXdUVlJ3WlVlWlp0?= =?utf-8?B?SnByeWF2R0VjTENMbmU5RFBxSmxLRWN3Ukg5d29oZmMvYUJrN2NNMVVSVlpF?= =?utf-8?B?U1UzelVKUVM3RGtNK0V3K1VtZTF6Qm9EcjlWSER3WG1FOW5FU1lzUEtsbWk1?= =?utf-8?B?ZEtjdEQ5cnN3SVo1cC9xaERrb0JiZGxrWHdmMzhwRXFEeHVMVGdBYzRIOWpK?= =?utf-8?B?aDBHR0V1NEVvWkkyZHNxZEFQR2pPOUMrYXZUMDlsUUtvUFFUdFpiMzJrVUlN?= =?utf-8?B?OUFLUUpZamtoRjJoMmdLa0JFUzNTVVAwUStvTlBWU0hNWW53UWNoMGJvZmNk?= =?utf-8?B?dTExaHpPbS9wZVRYcVF0OFJNdjhDU1lLVTFaMGFlKzB0TDFHQmdHblhlbmg5?= =?utf-8?B?TkQvUXdVZVhIc0NrQWJTaDRyK2VUbTA0YXg1RzMxMllzRG13ZVpaSmNaV3Rm?= =?utf-8?B?U2pRdm5zMzBrVnE4VEZrcitTa0oyTW1xNFVQd3FxbGRiQ0dUSHM4cEVlRUhj?= =?utf-8?B?bWo1YnVRczJ3ZzR2SmFVWThQMGtaNW9nc3daVDV5RTRBQmxrNGpyQzZyS0kr?= =?utf-8?B?LytPSTBoeFJ4QjVNNkp2azZTVjljbDM3OWZ0NzlkZWZ6K2tyeGdMUklIczFR?= =?utf-8?B?QkxjRFZyQUxYU21DVDZCTldDeG9sSElIQUNvNnhPR2hJazlLYW1pdll3VDl6?= =?utf-8?B?bnRQZnc3MTNaa2t6NzBPMDAzMmp5dU9qQjVYSHFjbTNMckJVZ01yaHhVZmZr?= =?utf-8?B?RW1VZnArYXZpTHhDYys1TmZxQW9kcXRPaC9vUjZjNGdZTVdTVUpJL0ZGQi9a?= =?utf-8?B?QmNEM1ZMNHlGRXoxWGU2T1k2TG1XRnRMbGJwTmdMZ1Q1TmVaZnZnZEZrTldp?= =?utf-8?B?VWxmd0s4c3RlQ0pMS3BIcVFyTzBPUHZZdExjaXNvK3YzMjNma21QT1Y3bnZv?= =?utf-8?B?S2ZsRXlIM2VRSm1zSmdkd09BN3ZYV0psNzVoZHdOb2xWa252b1kvT0FGajVy?= =?utf-8?B?MkdyVFFmVkpQYzVRTFZOZ2Nwc1RXQTRNL3B5OWNUMEwvUm5GRlZYM3JnSkxm?= =?utf-8?B?TDNBVnpHQm5zME1OaGlHYUNla2pSNEZHbU9YV1BpU2p6VzR4MnlESUlEVFZl?= =?utf-8?B?SUFxYXRvRnhldG9QR3RrOWZjUTBYQkpKOHhyTUFKZ3h3L2poUnpDRmRpYVBG?= =?utf-8?B?TFh2ZktPdnJTaldzQ0NNdXE3VHJHWTNOcS8zVjBkWURXbklqa0tOVmhOQXdL?= =?utf-8?B?Z0JHa0ZnK2JHbkxQcnBEdEhnOCtDMDVvaTdaNldrTlZvUkdvZlJyV1NRby9x?= =?utf-8?B?R1lIMEdrRnE2Z1lpNmpFbVRkc1p2SUF0ODU4Qk1RemhLU2p6eVh3cmhsNktv?= =?utf-8?B?OVRRakh4S2xPdUFGZFFTU2tiZGExaDdINEJpRW5QekQ2Y09NVzhoTWxYaFVx?= =?utf-8?B?blZ4WVNlWE91VjZPNisyYnRmZmJZUFlpckZiazZBV29KVzV5VEJPSGJkZ0VO?= =?utf-8?B?czBRc2I5R2g3dzdNVTU3L3E1L2pSUTZQZ29HeWpPZy8yVmMxTlZ6Rk1hcEdv?= =?utf-8?B?c2NwdEkxZTRteDZZa05DZWhpdUdzSHRkM0JUUi8razBOeVh3NVpYdDc1d1RL?= =?utf-8?B?WHRiRW1FanVxYlpwM1JRcHRveks1bEhUQzEvU05FSE1hVmEwZUJuZ1NGSVhC?= =?utf-8?Q?wamN9AXf77/NcwCsEAI++e3Im2Fjsb5A=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1740;6:ZUi01SdI5VNCA3MY3J/Jm3GatzUBaYXiDn6xdkX6gX0vFHx1PZBMa9HBM+pHlXBcDYL0figF+ixkev4DFO/EHMdQ0OEZqemTqltlvQYPvcWlidOajYRVwd9VeRWjmBbX9RUQ9aFbwDKrNsBZwGLA6/GNv6RVdmYYj/kZOPax/OWXfEhyhII9jlq5MgRQOIN9/Gr6t5DV/KdR+ZhEL+DDKtVoW4kX6tNz58ohRc6RP+7oLn9/qy96i0lq5E/snDLloEb2pTz+PR5a2OxTBICFgP2802oXIGse3sF6FojJNPwu6nk7ZXHUYSyX67CFbdK35Fo2nDs4f5rZVMDO9ENENw==;5:Qq8UURcYvYREMgvCtp55b02YwC6lZFN9uRwK3P5Ampgy/iu/gjzeKhNzXgmHEvkbgiPkiTuzdkfW/wzKV4av1TVv0bx9BTx1AsOjJQ4lhPqn3mjPqC/vZBq4qukgo7wfnk5BziW2k5olE9h9YtBCLw==;24:aOctlxHLzXkaCbZ6CdKTZvBRvp5X4hwyVwknMuhEomW0otxMccfxw8/f4a3Lx8ciRS+795tvCW1ssLyWCGxHGxjcAE6R2/wy22/rA84lkBA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1740;7:HZ5T08+yqXEJkRMbPbuBbbaYeV5dTSXcm0AmgH5U9TFSHmYOjb9GFwLJl3pbcvxz0f3YpAhnkTgoA5yAu8hkqYeVlmJ8xSwmkFolyRkyY+kF3NLArfPFqMox0r2GR76OjfnRZy4YJmIla29bi1R5XBYVBkhQTQ8JlXTX/61fFmUvNnTHoEZ+0J0fVs5JLu2gACxOg03qmqJz8fOlhlM8JFmaf1rY1vLt9bbwiG59u8zj7kIPzD59zSn5PkrLllUNOylJX1rCurU+2ykzkUIM81YpMcYv8d7dZw3u1Ge+NgUxiOkQ8WFyp+OGfziIUhaoZ1bx/sjUDSRyh7+XFpsJpeXMiBD5/o5wrAUiqpj+hqw=;20:vo83ASnovxoUSQMeK0NV0ROcFMuusapBFN0zonnG9KLRDkPpN0aelQtwBa4vyIoRW/jYn1AOlG9evgy/JguBLfmxSVusvoPA5MQ5zhHZBcqncXs3uTTm4JAgbeJgFiO7Tin6g8CeIqGDvwfjtjJLe+QKF4x3X0xsWuPZOAgojHs= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2016 12:51:31.1698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1740 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2016 03:30 PM, Paul Bolle wrote: > This is bit late, but we're still on v4.9-rc2, so anyhow. > > On Wed, 2016-09-14 at 12:34 -0700, tip-bot for Dmitry Safonov wrote: >> Commit-ID: 2eefd8789698e89c4a5d610921dc3c1b66e3bd0d >> Gitweb: http://git.kernel.org/tip/2eefd8789698e89c4a5d610921dc3c1b66e3bd0d >> Author: Dmitry Safonov >> AuthorDate: Mon, 5 Sep 2016 16:33:05 +0300 >> Committer: Thomas Gleixner >> CommitDate: Wed, 14 Sep 2016 21:28:09 +0200 >> >> x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_* >> >> Add API to change vdso blob type with arch_prctl. >> As this is usefull only by needs of CRIU, expose >> this interface under CONFIG_CHECKPOINT_RESTORE. >> >> Signed-off-by: Dmitry Safonov >> Acked-by: Andy Lutomirski >> Cc: 0x7f454c46@gmail.com >> Cc: oleg@redhat.com >> Cc: linux-mm@kvack.org >> Cc: gorcunov@openvz.org >> Cc: xemul@virtuozzo.com >> Link: http://lkml.kernel.org/r/20160905133308.28234-4-dsafonov@virtuozzo.com >> Signed-off-by: Thomas Gleixner > >> --- a/arch/x86/include/uapi/asm/prctl.h >> +++ b/arch/x86/include/uapi/asm/prctl.h > >> #define ARCH_GET_FS 0x1003 >> #define ARCH_GET_GS 0x1004 >> >> +#ifdef CONFIG_CHECKPOINT_RESTORE >> +# define ARCH_MAP_VDSO_X32 0x2001 >> +# define ARCH_MAP_VDSO_32 0x2002 >> +# define ARCH_MAP_VDSO_64 0x2003 >> +#endif >> + >> #endif /* _ASM_X86_PRCTL_H */ > > On my machine this header ends up in /usr/include/asm/prctl.h. But in > userspace CONFIG_CHECKPOINT_RESTORE is meaningless. I think if you > actually want to export these three macros to userspace the guard > should read: > #if defined(CONFIG_CHECKPOINT_RESTORE) || !defined(__KERNEL__) > > And if you don't want to export these macros the guard should read: > #if defined(CONFIG_CHECKPOINT_RESTORE) && defined(__KERNEL__) > > (In that case you're probably better of defining these macros outside > of uapi.) > > I've only lightly tested those two alternatives, so please double > check. > Hi Paul, thanks for noting that! Well, I think, I'll remove ifdeffery around those constants. Let them be always defined, that would be the simplest solution. Somehow I managed to forget that userspace knows nothing about enabled kernel options. Thanks again, Dmitry > > Paul Bolle >