From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932563AbbCQJP2 (ORCPT ); Tue, 17 Mar 2015 05:15:28 -0400 Received: from ip4-83-240-67-251.cust.nbox.cz ([83.240.67.251]:59510 "EHLO ip4-83-240-18-248.cust.nbox.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753770AbbCQImu (ORCPT ); Tue, 17 Mar 2015 04:42:50 -0400 From: Jiri Slaby To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Matthew Thode , "David S. Miller" , Jiri Slaby Subject: [PATCH 3.12 083/175] net: reject creation of netdev names with colons Date: Tue, 17 Mar 2015 09:41:01 +0100 Message-Id: X-Mailer: git-send-email 2.3.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthew Thode 3.12-stable review patch. If anyone has any objections, please let me know. =============== [ Upstream commit a4176a9391868bfa87705bcd2e3b49e9b9dd2996 ] colons are used as a separator in netdev device lookup in dev_ioctl.c Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME Signed-off-by: Matthew Thode Signed-off-by: David S. Miller Signed-off-by: Jiri Slaby --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 249ab7d67254..3ca487e14080 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -935,7 +935,7 @@ bool dev_valid_name(const char *name) return false; while (*name) { - if (*name == '/' || isspace(*name)) + if (*name == '/' || *name == ':' || isspace(*name)) return false; name++; } -- 2.3.0