From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B29DC4167B for ; Thu, 30 Nov 2023 09:18:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF52F10E140; Thu, 30 Nov 2023 09:18:34 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 11BCC10E140; Thu, 30 Nov 2023 09:18:33 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7F191CE1FE7; Thu, 30 Nov 2023 09:18:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30406C433C8; Thu, 30 Nov 2023 09:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701335909; bh=p8D1GXpx9l8qPpfGSEiXAyr1IiaXic8z4jKqVceRF7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r8y9Hm7N8rpgSxmjSHuCKgU8wHhkpVriV7kMUoiVSFSdRiTQ9x95QrSn3ttDM6ajR gwK0prCsKzQunaaOnehpBOz9QHpImxaJkvpjotMXTyBTi/tzNUg/BxwxcoPcAcMBpM VRVl57BqjrR7/gR3H4EWsHc75CA9iQknO0En+ikFiKHxxYkX3yHJQqk7IQTdXIfoEF lefNUHS5dFF8Y+/5+ts0G34SLlWH1a5EZjKGufo73W5nDnnXQNTCqJFezDBBnVnY2e j9hT8j1H6plQ5POFcXM/JSZ3EYUMVs/X8bF8bTN9T49W5TOPdLhrl0hDqSGS8Or0a2 MTtFNYWBzKRYQ== Date: Thu, 30 Nov 2023 10:18:26 +0100 From: Maxime Ripard To: Jani Nikula Subject: Re: [RFC] drm: enable W=1 warnings by default across the subsystem Message-ID: References: <20231129181219.1237887-1-jani.nikula@intel.com> <72248f22-6337-487a-9979-a0d79e37a9ed@amd.com> <874jh362ta.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kkimro66j5g4luvh" Content-Disposition: inline In-Reply-To: <874jh362ta.fsf@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pan@freedesktop.org, Karol Herbst , intel-gfx@lists.freedesktop.org, Xinhui , Abhinav Kumar , dri-devel@lists.freedesktop.org, Nathan Chancellor , Alex Deucher , Danilo Krummrich , Hamza Mahfooz , Thomas Zimmermann , Dmitry Baryshkov , Marijn Suijten , Sean Paul , Christian =?utf-8?B?S8O2bmln?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --kkimro66j5g4luvh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Hamza Mahfooz wrote: > > Cc: Nathan Chancellor > > > > On 11/29/23 13:12, Jani Nikula wrote: > >> At least the i915 and amd drivers enable a bunch more compiler warnings > >> than the kernel defaults. > >>=20 > >> Extend the W=3D1 warnings to the entire drm subsystem by default. Use = the > >> copy-pasted warnings from scripts/Makefile.extrawarn with > >> s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to compare and keep > >> up with them in the future. > >>=20 > >> This is similar to the approach currently used in i915. > >>=20 > >> Some of the -Wextra warnings do need to be disabled, just like in > >> Makefile.extrawarn, but take care to not disable them for W=3D2 or W= =3D3 > >> builds, depending on the warning. > > > > I think this should go in after drm-misc-next has a clean build (for > > COMPILE_TEST builds) with this patch applied. Otherwise, it will break a > > lot of build configs. >=20 > Oh, I'm absolutely not suggesting this should be merged before known > warnings have been addressed one way or another. Either by fixing them > or by disabling said warning in driver local Makefiles, depending on the > case. I'm all for it, but yeah, we need some easy way to opt-in/opt-out. Some drivers are pretty much unmaintained now and are likely to never fix those warnings. Maxime --kkimro66j5g4luvh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZWhTYgAKCRDj7w1vZxhR xR1lAP4r5qbIZphWlaJXg8MBeam0E94KuZ0xhLcr5Rfbvkp6PAEAsDIToV9WXxM4 CUgbJNN3SLGTt1qnWAMytlRRWpzghQ8= =hJW+ -----END PGP SIGNATURE----- --kkimro66j5g4luvh-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DD2FC4167B for ; Thu, 30 Nov 2023 09:18:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47BC310E6C9; Thu, 30 Nov 2023 09:18:35 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 11BCC10E140; Thu, 30 Nov 2023 09:18:33 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7F191CE1FE7; Thu, 30 Nov 2023 09:18:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30406C433C8; Thu, 30 Nov 2023 09:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701335909; bh=p8D1GXpx9l8qPpfGSEiXAyr1IiaXic8z4jKqVceRF7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r8y9Hm7N8rpgSxmjSHuCKgU8wHhkpVriV7kMUoiVSFSdRiTQ9x95QrSn3ttDM6ajR gwK0prCsKzQunaaOnehpBOz9QHpImxaJkvpjotMXTyBTi/tzNUg/BxwxcoPcAcMBpM VRVl57BqjrR7/gR3H4EWsHc75CA9iQknO0En+ikFiKHxxYkX3yHJQqk7IQTdXIfoEF lefNUHS5dFF8Y+/5+ts0G34SLlWH1a5EZjKGufo73W5nDnnXQNTCqJFezDBBnVnY2e j9hT8j1H6plQ5POFcXM/JSZ3EYUMVs/X8bF8bTN9T49W5TOPdLhrl0hDqSGS8Or0a2 MTtFNYWBzKRYQ== Date: Thu, 30 Nov 2023 10:18:26 +0100 From: Maxime Ripard To: Jani Nikula Message-ID: References: <20231129181219.1237887-1-jani.nikula@intel.com> <72248f22-6337-487a-9979-a0d79e37a9ed@amd.com> <874jh362ta.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kkimro66j5g4luvh" Content-Disposition: inline In-Reply-To: <874jh362ta.fsf@intel.com> Subject: Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pan@freedesktop.org, Karol Herbst , intel-gfx@lists.freedesktop.org, Xinhui , Abhinav Kumar , dri-devel@lists.freedesktop.org, Nathan Chancellor , Alex Deucher , Danilo Krummrich , Hamza Mahfooz , Thomas Zimmermann , Dmitry Baryshkov , Marijn Suijten , Christian =?utf-8?B?S8O2bmln?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --kkimro66j5g4luvh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Hamza Mahfooz wrote: > > Cc: Nathan Chancellor > > > > On 11/29/23 13:12, Jani Nikula wrote: > >> At least the i915 and amd drivers enable a bunch more compiler warnings > >> than the kernel defaults. > >>=20 > >> Extend the W=3D1 warnings to the entire drm subsystem by default. Use = the > >> copy-pasted warnings from scripts/Makefile.extrawarn with > >> s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to compare and keep > >> up with them in the future. > >>=20 > >> This is similar to the approach currently used in i915. > >>=20 > >> Some of the -Wextra warnings do need to be disabled, just like in > >> Makefile.extrawarn, but take care to not disable them for W=3D2 or W= =3D3 > >> builds, depending on the warning. > > > > I think this should go in after drm-misc-next has a clean build (for > > COMPILE_TEST builds) with this patch applied. Otherwise, it will break a > > lot of build configs. >=20 > Oh, I'm absolutely not suggesting this should be merged before known > warnings have been addressed one way or another. Either by fixing them > or by disabling said warning in driver local Makefiles, depending on the > case. I'm all for it, but yeah, we need some easy way to opt-in/opt-out. Some drivers are pretty much unmaintained now and are likely to never fix those warnings. Maxime --kkimro66j5g4luvh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZWhTYgAKCRDj7w1vZxhR xR1lAP4r5qbIZphWlaJXg8MBeam0E94KuZ0xhLcr5Rfbvkp6PAEAsDIToV9WXxM4 CUgbJNN3SLGTt1qnWAMytlRRWpzghQ8= =hJW+ -----END PGP SIGNATURE----- --kkimro66j5g4luvh--