All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Zhiqiang Liu <liuzhiqiang26@huawei.com>,
	linfeilong@huawei.com, Yanxiaodan <yanxiaodan@huawei.com>,
	lixiaokeng <lixiaokeng@huawei.com>
Cc: dm-devel@redhat.com
Subject: Re: Recent multipath-tools patches from Huawei
Date: Tue, 11 Aug 2020 11:49:54 +0200	[thread overview]
Message-ID: <eba3738594596c3e7d37ae6b8c2f35e9592864a8.camel@suse.com> (raw)
In-Reply-To: <60d7ea82-22ed-16f5-de7f-8280b90eeb7f@huawei.com>

On Tue, 2020-08-11 at 09:14 +0800, Zhiqiang Liu wrote:
> 
> On 2020/8/10 22:34, Martin Wilck wrote:
> > Hi Liu,
> > 
> > thanks again for your valuable contributions and meticulous code
> > review. I've added your patches in my upstream-queue branch now:
> > 
> > https://github.com/openSUSE/multipath-tools/commits/upstream-queue
> > 
> > Not applied yet: 
> > 
> >  - libmultipath: free pp if store_path fails in disassemble_map:
> >    As noted before, this will be merged with my series for
> >    disassemble_map().
> >  - libmultipath: fix a memory leak in set_ble_device:
> >    Please fix minor issues I mentioned
> >  - vector: return null when realloc fails in vector_alloc_slot func
> >    Needs improvement
> > 
> > Please double-check if I've missed anything. 
> > 
> > Next time, please send your patches as a series. That makes it
> > much easier for others to make sure they don't miss any.
> > And please, don't add "[dm-devel]" explicitly in your email
> > subject, mailman will take care of that.
> > 
> > Regards
> > Martin
> > 
> Thanks for your advise.
> I have checked recent patches. The following patch may be missed.
> - libmultipath: free pgp if add_pathgroup fails in disassemble_map
> func

Right. Sorry for overlooking it, I pushed it now.

Regards,
Martin

      reply	other threads:[~2020-08-11  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 14:34 Recent multipath-tools patches from Huawei Martin Wilck
2020-08-11  1:14 ` Zhiqiang Liu
2020-08-11  9:49   ` Martin Wilck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eba3738594596c3e7d37ae6b8c2f35e9592864a8.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=dm-devel@redhat.com \
    --cc=linfeilong@huawei.com \
    --cc=liuzhiqiang26@huawei.com \
    --cc=lixiaokeng@huawei.com \
    --cc=yanxiaodan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.