From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h= content-transfer-encoding:content-language:content-type :content-type:mime-version:date:date:message-id:subject:subject :from:from:received; s=mail20150812; t=1595848466; bh=5x8M8g63dn 3o0gLiE2COiLzYAfEE8faDFKh+iOQRzxs=; b=icwmiq0yPgIkuWPQ4knETgZ4I+ a1kGha87sw1ZsNYNkt1n5p0j/sF6kOt0eKULoF56cfQ//No8uYREHQMHRVe/IMfR FAvGLmYolriAHt2Gvw7pSISB7LV6HJy2STSUJL5k33OJ9no6kRtHkCUaSMT7Zieu Jngcd1rlQHk4txhzDKf6IZxqgrLaNff17qo5X9mqGgPDUf0z8/cs1WlvJA8zrSbx u1b+WDEGzdkNhR5hRWmWwKb+JxBtdxecMAoeOZC56PHy+uHg/u0zMvSYmMdLK/iQ xpY9qCvWg30I4L0n0GhB4CcncBAjtKvzFXJVd6kgyqqFAsWSj4MSlxM1rg6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1595848468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=svC+m5MtsuV2OMeRFvJHUX6UVg3pWHWi26zpD/OkDG0=; b=T5I5DfCuzp45gU9xtQUOJPb6pYRnRrv/tYSwVYIEa7VJjouNex8y4ciQtTErPRzVuUeauq C7wPn0++yreayIjSO8pYc0dHfknM4DPWMRkGcB2IwBDFBmF4JszDd2waS3/Qt5KuSppdHL z2E7vfC7ZL/vNZ5se7ZqIRZZCcvQ+gaEak+5RPkN4ObwSJ+6elmCxKIga2o48vlLYkRWm9 E1IEDCe1mVRDHoiP7zMpo4SxOXmB/rmo79YMSTp9rCv7xJ51QvLQS10XbxMoCD+Px3DYh7 9zpJEZRgFWTDa149yl6Mh8RtyVLrK36OkFtxjab+CNNQUb4hd5jOvSNEdD/4tg== From: Georg Piewald Message-ID: Date: Mon, 27 Jul 2020 13:14:25 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: [Fuego] Dockerfile vs install-debian.sh List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "fuego@lists.linuxfoundation.org" Hi guys, I was just looking into how to install Fuego without a Docker container (since the CHANGELOG says it's possible). Apparently, that's what install-debian.sh is good for (or is there something else, that I missed?). But honestly, this script seems like a halfhearted attempt to me and strongly violates the DRY principle. It is clearly descendant from Dockerfile, but did not evolve with it. Several later modifications in Dockerfile did not make it to install-debian.sh. How do you plan to keep these files in sync? I propose to only let install-debian.sh have all the code that sets up the OS and installs all requirements. The Dockerfile instead should do (almost) nothing but execute install-debian.sh. An additional benefit of that method is that it will be much easier to also keep Dockerfile.nojenkins in sync with the standard Dockerfile. Because here we have the same problem of lots of copied code, that is slowly drifting apart. We might even not need Dockerfile.nojenkins anymore at all. I can offer to implement this, unless there are strong objections by anyone. Regards, Georg