[U-Boot] [PATCH 1/6] zynqmp: Add support for emulation platform - Veloce

[U-Boot] [PATCH 1/6] zynqmp: Add support for emulation platform - Veloce

[Michal Simek]

Add support for Veloce - zynqmp emulation platform.
Platform doesn't support SDHCI.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/cpu/armv8/zynqmp/clk.c             | 3 +++
 arch/arm/cpu/armv8/zynqmp/cpu.c             | 2 ++
 arch/arm/include/asm/arch-zynqmp/hardware.h | 1 +
 board/xilinx/zynqmp/zynqmp.c                | 8 ++++++--
 4 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/armv8/zynqmp/clk.c b/arch/arm/cpu/armv8/zynqmp/clk.c
index 0af619d92fde..9147fa749507 100644
--- a/arch/arm/cpu/armv8/zynqmp/clk.c
+++ b/arch/arm/cpu/armv8/zynqmp/clk.c
@@ -6,6 +6,7 @@
  */
 
 #include <common.h>
+#include <asm/arch/clk.h>
 #include <asm/arch/hardware.h>
 #include <asm/arch/sys_proto.h>
 
@@ -16,6 +17,8 @@ unsigned long get_uart_clk(int dev_id)
 	u32 ver = zynqmp_get_silicon_version();
 
 	switch (ver) {
+	case ZYNQMP_CSU_VERSION_VELOCE:
+		return 96000;
 	case ZYNQMP_CSU_VERSION_EP108:
 		return 25000000;
 	}
diff --git a/arch/arm/cpu/armv8/zynqmp/cpu.c b/arch/arm/cpu/armv8/zynqmp/cpu.c
index 11958fea6f11..60d7d20e17c8 100644
--- a/arch/arm/cpu/armv8/zynqmp/cpu.c
+++ b/arch/arm/cpu/armv8/zynqmp/cpu.c
@@ -20,6 +20,8 @@ unsigned int zynqmp_get_silicon_version(void)
 	gd->cpu_clk = get_tbclk();
 
 	switch (gd->cpu_clk) {
+	case 0 ... 1000000:
+		return ZYNQMP_CSU_VERSION_VELOCE;
 	case 50000000:
 		return ZYNQMP_CSU_VERSION_QEMU;
 	}
diff --git a/arch/arm/include/asm/arch-zynqmp/hardware.h b/arch/arm/include/asm/arch-zynqmp/hardware.h
index 3df3147fc4c3..188b5c2144af 100644
--- a/arch/arm/include/asm/arch-zynqmp/hardware.h
+++ b/arch/arm/include/asm/arch-zynqmp/hardware.h
@@ -84,6 +84,7 @@ struct apu_regs {
 /* Board version value */
 #define ZYNQMP_CSU_VERSION_SILICON	0x0
 #define ZYNQMP_CSU_VERSION_EP108	0x1
+#define ZYNQMP_CSU_VERSION_VELOCE	0x2
 #define ZYNQMP_CSU_VERSION_QEMU		0x3
 
 #endif /* _ASM_ARCH_HARDWARE_H */
diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
index 1325bca5e552..e38948426d70 100644
--- a/board/xilinx/zynqmp/zynqmp.c
+++ b/board/xilinx/zynqmp/zynqmp.c
@@ -56,14 +56,18 @@ int board_mmc_init(bd_t *bd)
 {
 	int ret = 0;
 
+	u32 ver = zynqmp_get_silicon_version();
+
+	if (ver != ZYNQMP_CSU_VERSION_VELOCE) {
 #if defined(CONFIG_ZYNQ_SDHCI)
 # if defined(CONFIG_ZYNQ_SDHCI0)
-	ret = zynq_sdhci_init(ZYNQ_SDHCI_BASEADDR0);
+		ret = zynq_sdhci_init(ZYNQ_SDHCI_BASEADDR0);
 # endif
 # if defined(CONFIG_ZYNQ_SDHCI1)
-	ret |= zynq_sdhci_init(ZYNQ_SDHCI_BASEADDR1);
+		ret |= zynq_sdhci_init(ZYNQ_SDHCI_BASEADDR1);
 # endif
 #endif
+	}
 
 	return ret;
 }
-- 
2.3.5

[U-Boot] [PATCH 2/6] zynqmp: Add support for EMMC bootmode

[Michal Simek]

Add support for EMMC bootmode.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/include/asm/arch-zynqmp/hardware.h | 3 ++-
 board/xilinx/zynqmp/zynqmp.c                | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/arch-zynqmp/hardware.h b/arch/arm/include/asm/arch-zynqmp/hardware.h
index 188b5c2144af..87792c21a5d0 100644
--- a/arch/arm/include/asm/arch-zynqmp/hardware.h
+++ b/arch/arm/include/asm/arch-zynqmp/hardware.h
@@ -45,7 +45,8 @@ struct iou_scntr {
 
 /* Bootmode setting values */
 #define BOOT_MODES_MASK	0x0000000F
-#define SD_MODE		0x00000005
+#define SD_MODE		0x00000003
+#define EMMC_MODE	0x00000006
 #define JTAG_MODE	0x00000000
 
 #define ZYNQMP_RPU_BASEADDR	0xFF9A0000
diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c
index e38948426d70..f5ff64d988e5 100644
--- a/board/xilinx/zynqmp/zynqmp.c
+++ b/board/xilinx/zynqmp/zynqmp.c
@@ -83,6 +83,7 @@ int board_late_init(void)
 
 	switch (bootmode) {
 	case SD_MODE:
+	case EMMC_MODE:
 		setenv("modeboot", "sdboot");
 		break;
 	default:
-- 
2.3.5

[U-Boot] [PATCH 3/6] zynqmp: i2c: Enable i2c driver for zynqMP

[Michal Simek]

From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>

Enable the i2c driver for ZynqMP
Also enable the eeprom for read and writes
to eeprom on ZynqMP
ZynqMP uses the same i2c controller as in Zynq

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/include/asm/arch-zynqmp/hardware.h |  3 +++
 include/configs/xilinx_zynqmp.h             | 23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/arch/arm/include/asm/arch-zynqmp/hardware.h b/arch/arm/include/asm/arch-zynqmp/hardware.h
index 87792c21a5d0..1fedb1bb4b94 100644
--- a/arch/arm/include/asm/arch-zynqmp/hardware.h
+++ b/arch/arm/include/asm/arch-zynqmp/hardware.h
@@ -11,6 +11,9 @@
 #define ZYNQ_SERIAL_BASEADDR0	0xFF000000
 #define ZYNQ_SERIAL_BASEADDR1	0xFF001000
 
+#define ZYNQ_I2C_BASEADDR0	0xFF020000
+#define ZYNQ_I2C_BASEADDR1	0xFF030000
+
 #define ZYNQ_SDHCI_BASEADDR0	0xFF160000
 #define ZYNQ_SDHCI_BASEADDR1	0xFF170000
 
diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
index d0ec3c066f33..54bca6d47b72 100644
--- a/include/configs/xilinx_zynqmp.h
+++ b/include/configs/xilinx_zynqmp.h
@@ -119,6 +119,29 @@
 #define CONFIG_CMDLINE_EDITING
 #define CONFIG_SYS_MAXARGS		64
 
+#define CONFIG_ZYNQ_I2C0
+#define CONFIG_SYS_I2C_ZYNQ
+
+/* I2C */
+#if defined(CONFIG_SYS_I2C_ZYNQ)
+# define CONFIG_CMD_I2C
+# define CONFIG_SYS_I2C
+# define CONFIG_SYS_I2C_ZYNQ_SPEED		100000
+# define CONFIG_SYS_I2C_ZYNQ_SLAVE		0
+#endif
+
+#define CONFIG_ZYNQMP_EEPROM
+
+/* EEPROM */
+#ifdef CONFIG_ZYNQMP_EEPROM
+# define CONFIG_CMD_EEPROM
+# define CONFIG_SYS_I2C_EEPROM_ADDR_LEN		2
+# define CONFIG_SYS_I2C_EEPROM_ADDR		0x54
+# define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	4
+# define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	5
+# define CONFIG_SYS_EEPROM_SIZE			(64 * 1024)
+#endif
+
 #define CONFIG_FIT
 #define CONFIG_FIT_VERBOSE       /* enable fit_format_{error,warning}() */
 
-- 
2.3.5

[U-Boot] [PATCH 4/6] zynqmp: Add SPI driver support for ZynqMP

[Michal Simek]

From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>

Added the SPI driver support for ZynqMP
The controller is same as zynq SPI controller

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/include/asm/arch-zynqmp/hardware.h | 3 +++
 include/configs/xilinx_zynqmp.h             | 8 ++++++++
 2 files changed, 11 insertions(+)

diff --git a/arch/arm/include/asm/arch-zynqmp/hardware.h b/arch/arm/include/asm/arch-zynqmp/hardware.h
index 1fedb1bb4b94..c9dc49d78317 100644
--- a/arch/arm/include/asm/arch-zynqmp/hardware.h
+++ b/arch/arm/include/asm/arch-zynqmp/hardware.h
@@ -11,6 +11,9 @@
 #define ZYNQ_SERIAL_BASEADDR0	0xFF000000
 #define ZYNQ_SERIAL_BASEADDR1	0xFF001000
 
+#define ZYNQ_SPI_BASEADDR0	0xFF040000
+#define ZYNQ_SPI_BASEADDR1	0xFF050000
+
 #define ZYNQ_I2C_BASEADDR0	0xFF020000
 #define ZYNQ_I2C_BASEADDR1	0xFF030000
 
diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
index 54bca6d47b72..df7541b85baf 100644
--- a/include/configs/xilinx_zynqmp.h
+++ b/include/configs/xilinx_zynqmp.h
@@ -71,6 +71,14 @@
 #define CONFIG_CMD_ELF
 #define CONFIG_MP
 
+/* SPI */
+#ifdef CONFIG_ZYNQ_SPI
+# define CONFIG_SPI_FLASH
+# define CONFIG_SPI_FLASH_SST
+# define CONFIG_CMD_SPI
+# define CONFIG_CMD_SF
+#endif
+
 #if defined(CONFIG_ZYNQ_SDHCI0) || defined(CONFIG_ZYNQ_SDHCI1)
 # define CONFIG_MMC
 # define CONFIG_GENERIC_MMC
-- 
2.3.5

[U-Boot] [PATCH 5/6] zynqmp: Enable FS_GENERIC option

[Michal Simek]

From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>

Provide an option to write filesystem independend commands.

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 include/configs/xilinx_zynqmp.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
index df7541b85baf..94b713bc2b19 100644
--- a/include/configs/xilinx_zynqmp.h
+++ b/include/configs/xilinx_zynqmp.h
@@ -66,6 +66,7 @@
 #define CONFIG_CMD_EXT2
 #define CONFIG_CMD_EXT4
 #define CONFIG_CMD_FAT
+#define CONFIG_CMD_FS_GENERIC
 #define CONFIG_CMD_MEMORY
 #define CONFIG_DOS_PARTITION
 #define CONFIG_CMD_ELF
@@ -100,8 +101,8 @@
 	"kernel_addr=0x80000\0" \
 	"fdt_addr=0x7000000\0" \
 	"fdt_high=0x10000000\0" \
-	"sdboot=mmcinfo && fatload mmc 0:0 $fdt_addr system.dtb && " \
-		"fatload mmc 0:0 $kernel_addr Image && booti $kernel_addr - $fdt_addr\0"
+	"sdboot=mmcinfo && load mmc 0:0 $fdt_addr system.dtb && " \
+		"load mmc 0:0 $kernel_addr Image && booti $kernel_addr - $fdt_addr\0"
 
 #define CONFIG_BOOTARGS		"setenv bootargs console=ttyPS0,${baudrate} " \
 				"earlycon=cdns,mmio,0xff000000,${baudrate}n8"
-- 
2.3.5

[U-Boot] [PATCH 6/6] zynqmp: Enable SDHCI0 options

[Michal Simek]

Enable SDHCI0 for zynqmp.
Add empty gpio.h because of sdhci requirement.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

There will be gpio driver anyway that's why it should be fine to add
empty file.

---
 arch/arm/include/asm/arch-zynqmp/gpio.h | 12 ++++++++++++
 include/configs/xilinx_zynqmp.h         |  2 ++
 2 files changed, 14 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-zynqmp/gpio.h

diff --git a/arch/arm/include/asm/arch-zynqmp/gpio.h b/arch/arm/include/asm/arch-zynqmp/gpio.h
new file mode 100644
index 000000000000..098bbde06f30
--- /dev/null
+++ b/arch/arm/include/asm/arch-zynqmp/gpio.h
@@ -0,0 +1,12 @@
+/*
+ * Copyright 2015 Xilinx, Inc.
+ *
+ * SPDX-License-Identifier:      GPL-2.0+
+ */
+
+#ifndef __ARCH_ZYNQMP_GPIO_H
+#define __ARCH_ZYNQMP_GPIO_H
+
+/* Empty file - sdhci requires this. */
+
+#endif
diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
index 94b713bc2b19..6c608abfb9bb 100644
--- a/include/configs/xilinx_zynqmp.h
+++ b/include/configs/xilinx_zynqmp.h
@@ -61,6 +61,8 @@
 #define CONFIG_SYS_BAUDRATE_TABLE \
 	{ 4800, 9600, 19200, 38400, 57600, 115200 }
 
+#define CONFIG_ZYNQ_SDHCI0
+
 /* Command line configuration */
 #define CONFIG_CMD_ENV
 #define CONFIG_CMD_EXT2
-- 
2.3.5

[U-Boot] [PATCH 4/6] zynqmp: Add SPI driver support for ZynqMP

[Jagan Teki]

On 15 April 2015 at 19:03, Michal Simek <michal.simek@xilinx.com> wrote:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>
> Added the SPI driver support for ZynqMP
> The controller is same as zynq SPI controller
>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  arch/arm/include/asm/arch-zynqmp/hardware.h | 3 +++
>  include/configs/xilinx_zynqmp.h             | 8 ++++++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-zynqmp/hardware.h b/arch/arm/include/asm/arch-zynqmp/hardware.h
> index 1fedb1bb4b94..c9dc49d78317 100644
> --- a/arch/arm/include/asm/arch-zynqmp/hardware.h
> +++ b/arch/arm/include/asm/arch-zynqmp/hardware.h
> @@ -11,6 +11,9 @@
>  #define ZYNQ_SERIAL_BASEADDR0  0xFF000000
>  #define ZYNQ_SERIAL_BASEADDR1  0xFF001000
>
> +#define ZYNQ_SPI_BASEADDR0     0xFF040000
> +#define ZYNQ_SPI_BASEADDR1     0xFF050000
> +
>  #define ZYNQ_I2C_BASEADDR0     0xFF020000
>  #define ZYNQ_I2C_BASEADDR1     0xFF030000
>
> diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
> index 54bca6d47b72..df7541b85baf 100644
> --- a/include/configs/xilinx_zynqmp.h
> +++ b/include/configs/xilinx_zynqmp.h
> @@ -71,6 +71,14 @@
>  #define CONFIG_CMD_ELF
>  #define CONFIG_MP
>
> +/* SPI */
> +#ifdef CONFIG_ZYNQ_SPI
> +# define CONFIG_SPI_FLASH
> +# define CONFIG_SPI_FLASH_SST
> +# define CONFIG_CMD_SPI

CMD_SPI is never been verified I suppose, if so not required at this
point of time.

> +# define CONFIG_CMD_SF
> +#endif
> +
>  #if defined(CONFIG_ZYNQ_SDHCI0) || defined(CONFIG_ZYNQ_SDHCI1)
>  # define CONFIG_MMC
>  # define CONFIG_GENERIC_MMC
> --
> 2.3.5

thanks!
-- 
Jagan.

[U-Boot] [PATCH 4/6] zynqmp: Add SPI driver support for ZynqMP

[Michal Simek]

On 04/16/2015 08:13 PM, Jagan Teki wrote:
> On 15 April 2015 at 19:03, Michal Simek <michal.simek@xilinx.com> wrote:
>> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>>
>> Added the SPI driver support for ZynqMP
>> The controller is same as zynq SPI controller
>>
>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  arch/arm/include/asm/arch-zynqmp/hardware.h | 3 +++
>>  include/configs/xilinx_zynqmp.h             | 8 ++++++++
>>  2 files changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-zynqmp/hardware.h b/arch/arm/include/asm/arch-zynqmp/hardware.h
>> index 1fedb1bb4b94..c9dc49d78317 100644
>> --- a/arch/arm/include/asm/arch-zynqmp/hardware.h
>> +++ b/arch/arm/include/asm/arch-zynqmp/hardware.h
>> @@ -11,6 +11,9 @@
>>  #define ZYNQ_SERIAL_BASEADDR0  0xFF000000
>>  #define ZYNQ_SERIAL_BASEADDR1  0xFF001000
>>
>> +#define ZYNQ_SPI_BASEADDR0     0xFF040000
>> +#define ZYNQ_SPI_BASEADDR1     0xFF050000
>> +
>>  #define ZYNQ_I2C_BASEADDR0     0xFF020000
>>  #define ZYNQ_I2C_BASEADDR1     0xFF030000
>>
>> diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
>> index 54bca6d47b72..df7541b85baf 100644
>> --- a/include/configs/xilinx_zynqmp.h
>> +++ b/include/configs/xilinx_zynqmp.h
>> @@ -71,6 +71,14 @@
>>  #define CONFIG_CMD_ELF
>>  #define CONFIG_MP
>>
>> +/* SPI */
>> +#ifdef CONFIG_ZYNQ_SPI
>> +# define CONFIG_SPI_FLASH
>> +# define CONFIG_SPI_FLASH_SST
>> +# define CONFIG_CMD_SPI
> 
> CMD_SPI is never been verified I suppose, if so not required at this
> point of time.

It is enabled on 75 platforms that's why I can't see any problem with
it. If something is not verified then it should be verified. If it is
completely broken it should be removed.

Thanks,
Michal

[U-Boot] [PATCH 4/6] zynqmp: Add SPI driver support for ZynqMP

[Jagan Teki]

On 17 April 2015 at 11:02, Michal Simek <michal.simek@xilinx.com> wrote:
> On 04/16/2015 08:13 PM, Jagan Teki wrote:
>> On 15 April 2015 at 19:03, Michal Simek <michal.simek@xilinx.com> wrote:
>>> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>>>
>>> Added the SPI driver support for ZynqMP
>>> The controller is same as zynq SPI controller
>>>
>>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>> ---
>>>
>>>  arch/arm/include/asm/arch-zynqmp/hardware.h | 3 +++
>>>  include/configs/xilinx_zynqmp.h             | 8 ++++++++
>>>  2 files changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm/include/asm/arch-zynqmp/hardware.h b/arch/arm/include/asm/arch-zynqmp/hardware.h
>>> index 1fedb1bb4b94..c9dc49d78317 100644
>>> --- a/arch/arm/include/asm/arch-zynqmp/hardware.h
>>> +++ b/arch/arm/include/asm/arch-zynqmp/hardware.h
>>> @@ -11,6 +11,9 @@
>>>  #define ZYNQ_SERIAL_BASEADDR0  0xFF000000
>>>  #define ZYNQ_SERIAL_BASEADDR1  0xFF001000
>>>
>>> +#define ZYNQ_SPI_BASEADDR0     0xFF040000
>>> +#define ZYNQ_SPI_BASEADDR1     0xFF050000
>>> +
>>>  #define ZYNQ_I2C_BASEADDR0     0xFF020000
>>>  #define ZYNQ_I2C_BASEADDR1     0xFF030000
>>>
>>> diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h
>>> index 54bca6d47b72..df7541b85baf 100644
>>> --- a/include/configs/xilinx_zynqmp.h
>>> +++ b/include/configs/xilinx_zynqmp.h
>>> @@ -71,6 +71,14 @@
>>>  #define CONFIG_CMD_ELF
>>>  #define CONFIG_MP
>>>
>>> +/* SPI */
>>> +#ifdef CONFIG_ZYNQ_SPI
>>> +# define CONFIG_SPI_FLASH
>>> +# define CONFIG_SPI_FLASH_SST
>>> +# define CONFIG_CMD_SPI
>>
>> CMD_SPI is never been verified I suppose, if so not required at this
>> point of time.
>
> It is enabled on 75 platforms that's why I can't see any problem with
> it. If something is not verified then it should be verified. If it is
> completely broken it should be removed.

I do understand that it uses more boards based on their usage and need,
I believe zynq_spi mostly for flash related ops, if ie the case CMD_SF
enough I guess.

thaks!
-- 
Jagan.

[U-Boot] [PATCH 4/6] zynqmp: Add SPI driver support for ZynqMP

[Siva Durga Prasad Paladugu]

Hi Jagan,

> -----Original Message-----
> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> Sent: Friday, April 17, 2015 2:11 PM
> To: Michal Simek
> Cc: u-boot at lists.denx.de; Tom Rini; Siva Durga Prasad Paladugu
> Subject: Re: [U-Boot] [PATCH 4/6] zynqmp: Add SPI driver support for
> ZynqMP
> 
> On 17 April 2015 at 11:02, Michal Simek <michal.simek@xilinx.com> wrote:
> > On 04/16/2015 08:13 PM, Jagan Teki wrote:
> >> On 15 April 2015 at 19:03, Michal Simek <michal.simek@xilinx.com> wrote:
> >>> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> >>>
> >>> Added the SPI driver support for ZynqMP The controller is same as
> >>> zynq SPI controller
> >>>
> >>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >>> ---
> >>>
> >>>  arch/arm/include/asm/arch-zynqmp/hardware.h | 3 +++
> >>>  include/configs/xilinx_zynqmp.h             | 8 ++++++++
> >>>  2 files changed, 11 insertions(+)
> >>>
> >>> diff --git a/arch/arm/include/asm/arch-zynqmp/hardware.h
> >>> b/arch/arm/include/asm/arch-zynqmp/hardware.h
> >>> index 1fedb1bb4b94..c9dc49d78317 100644
> >>> --- a/arch/arm/include/asm/arch-zynqmp/hardware.h
> >>> +++ b/arch/arm/include/asm/arch-zynqmp/hardware.h
> >>> @@ -11,6 +11,9 @@
> >>>  #define ZYNQ_SERIAL_BASEADDR0  0xFF000000  #define
> >>> ZYNQ_SERIAL_BASEADDR1  0xFF001000
> >>>
> >>> +#define ZYNQ_SPI_BASEADDR0     0xFF040000
> >>> +#define ZYNQ_SPI_BASEADDR1     0xFF050000
> >>> +
> >>>  #define ZYNQ_I2C_BASEADDR0     0xFF020000
> >>>  #define ZYNQ_I2C_BASEADDR1     0xFF030000
> >>>
> >>> diff --git a/include/configs/xilinx_zynqmp.h
> >>> b/include/configs/xilinx_zynqmp.h index 54bca6d47b72..df7541b85baf
> >>> 100644
> >>> --- a/include/configs/xilinx_zynqmp.h
> >>> +++ b/include/configs/xilinx_zynqmp.h
> >>> @@ -71,6 +71,14 @@
> >>>  #define CONFIG_CMD_ELF
> >>>  #define CONFIG_MP
> >>>
> >>> +/* SPI */
> >>> +#ifdef CONFIG_ZYNQ_SPI
> >>> +# define CONFIG_SPI_FLASH
> >>> +# define CONFIG_SPI_FLASH_SST
> >>> +# define CONFIG_CMD_SPI
> >>
> >> CMD_SPI is never been verified I suppose, if so not required at this
> >> point of time.
> >
> > It is enabled on 75 platforms that's why I can't see any problem with
> > it. If something is not verified then it should be verified. If it is
> > completely broken it should be removed.
> 
> I do understand that it uses more boards based on their usage and need, I
> believe zynq_spi mostly for flash related ops, if ie the case CMD_SF enough I
> guess.

We didn?t need it at this point of time and also not verified. 
Its mostly flash related ops which we use. Will send v2 for the same.

Regards,
Siva

> 
> thaks!
> --
> Jagan.