From: Mark Cave-Ayland <firstname.lastname@example.org> To: "Philippe Mathieu-Daudé" <email@example.com>, firstname.lastname@example.org Cc: Jason Wang <email@example.com>, Laurent Vivier <firstname.lastname@example.org>, Finn Thain <email@example.com> Subject: Re: [PATCH 2/6] dp8393x: don't force 32-bit register access Date: Sun, 4 Jul 2021 16:34:44 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 03/07/2021 17:29, Philippe Mathieu-Daudé wrote: > On 7/3/21 4:39 PM, Mark Cave-Ayland wrote: >> On 03/07/2021 15:19, Philippe Mathieu-Daudé wrote: >> >>> From: Mark Cave-Ayland <firstname.lastname@example.org> >>> >>> Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that >>> all accesses >>> to the registers were 32-bit but this is actually not the case. The >>> access size is >>> determined by the CPU instruction used and not the number of physical >>> address lines. >>> >>> The big_endian workaround applied to the register read/writes was >>> actually caused >>> by forcing the access size to 32-bit when the guest OS was using a >>> 16-bit access. >>> Since the registers are 16-bit then we can simply set .impl.min_access >>> to 2 and >>> then the memory API will automatically do the right thing for both >>> 16-bit accesses >>> used by Linux and 32-bit accesses used by the MacOS toolbox ROM. >> >> The change should work, but the commit message above needs a slight >> tweak - maybe something like this? >> >> Since the registers are 16-bit then we can simply set both >> .impl.min_access and .impl.max_access to 2 and then the memory API will >> automatically do the right thing for both 16-bit accesses used by Linux >> and 32-bit accesses used by the MacOS toolbox ROM. > > Do you mind sending v3 of this patch reworded (and including the .valid > fields)? I've sent a v3 with the rewording but dropping the .valid fields since that breaks MacOS and removed Finn's T-b tag as it may be there is an issue here with mips64el - whilst it works for me on all of my test images, I'm struggling to keep up with all the patches flying around everywhere :/ Now that your MIPS PR has been applied, perhaps it is worth sending a rebased v2 of your RFC "dp8393x: Housekeeping" patchset to ensure that everyone is up to date with the latest fixes? I won't be able to have a look at the CRC patchset for a few days though. ATB, Mark.
next prev parent reply other threads:[~2021-07-04 15:35 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-03 14:19 [RFC PATCH 0/6] dp8393x: Housekeeping Philippe Mathieu-Daudé 2021-07-03 14:19 ` [PATCH 1/6] dp8393x: fix CAM descriptor entry index Philippe Mathieu-Daudé 2021-07-03 14:19 ` [PATCH 2/6] dp8393x: don't force 32-bit register access Philippe Mathieu-Daudé 2021-07-03 14:39 ` Mark Cave-Ayland 2021-07-03 16:29 ` Philippe Mathieu-Daudé 2021-07-04 15:34 ` Mark Cave-Ayland [this message] 2021-07-04 2:06 ` Finn Thain 2021-07-03 14:19 ` [RFC PATCH 3/6] dp8393x: Restrict bus access to 16/32-bit operations Philippe Mathieu-Daudé 2021-07-03 14:52 ` Mark Cave-Ayland 2021-07-04 14:45 ` Mark Cave-Ayland 2021-07-03 14:19 ` [RFC PATCH 4/6] dp8393x: Store CAM registers as 16-bit Philippe Mathieu-Daudé 2021-07-03 14:56 ` Mark Cave-Ayland 2021-07-04 14:48 ` Mark Cave-Ayland 2021-07-06 17:29 ` Philippe Mathieu-Daudé 2021-07-06 19:27 ` Mark Cave-Ayland 2021-07-03 14:19 ` [PATCH 5/6] dp8393x: Replace address_space_rw(is_write=1) by address_space_write() Philippe Mathieu-Daudé 2021-07-03 14:57 ` Mark Cave-Ayland 2021-07-04 14:49 ` Mark Cave-Ayland 2021-07-03 14:19 ` [RFC PATCH 6/6] dp8393x: Rewrite dp8393x_get() / dp8393x_put() Philippe Mathieu-Daudé 2021-07-03 15:00 ` Mark Cave-Ayland 2021-07-03 15:04 ` Philippe Mathieu-Daudé 2021-07-04 1:46 ` Finn Thain 2021-07-04 15:07 ` Mark Cave-Ayland 2021-07-05 1:36 ` Finn Thain 2021-07-05 6:34 ` Mark Cave-Ayland 2021-07-07 1:30 ` Finn Thain 2021-07-07 10:12 ` Mark Cave-Ayland 2021-07-09 9:13 ` Finn Thain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 2/6] dp8393x: don'\''t force 32-bit register access' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.