From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: "Beraldo Leal" <bleal@redhat.com>,
qemu-devel@nongnu.org, "Fabien Chouteau" <chouteau@adacore.com>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
qemu-ppc@nongnu.org,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH v7 3/8] Acceptance tests: use avocado tags for machine type
Date: Tue, 12 Nov 2019 19:15:11 +0100 [thread overview]
Message-ID: <ebd5af02-c0cc-813b-1fd0-5e9768833e9d@redhat.com> (raw)
In-Reply-To: <20191111214957.GC19559@localhost.localdomain>
On 11/11/19 10:49 PM, Cleber Rosa wrote:
> On Fri, Nov 08, 2019 at 02:20:45PM +0100, Philippe Mathieu-Daudé wrote:
>>> @@ -310,7 +302,7 @@ class BootLinuxConsole(Test):
>>> def test_arm_emcraft_sf2(self):
>>> """
>>> :avocado: tags=arch:arm
>>> - :avocado: tags=machine:emcraft_sf2
>>> + :avocado: tags=machine:emcraft-sf2
>>
>> Maybe add a comment about this change, "Since avocado 72(?) we can ... so
>> use ..."
>>
>
> You mean on this specific test docstring? I'm confused if there's a
No! Just in the commit description :)
> special reason for doing it here, of if you're suggesting adding a
> similar command to all tag entries which make use of the extended
> character set (which I think would be too verbose, repetitve, and hard
> to maintain).
>
>>> diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py
>>> index af47d2795a..293dccb89a 100644
>>> --- a/tests/acceptance/cpu_queries.py
>>> +++ b/tests/acceptance/cpu_queries.py
>>> @@ -20,8 +20,8 @@ class QueryCPUModelExpansion(Test):
>>> def test(self):
>>> """
>>> :avocado: tags=arch:x86_64
>>> + :avocado: tags=machine:none
>>
>> Not to confuse with None :)
>>
>
> Yep! :)
>
> - Cleber.
>
next prev parent reply other threads:[~2019-11-12 18:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 15:13 [PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 1/8] Acceptance test x86_cpu_model_versions: use default vm Cleber Rosa
2019-11-04 18:22 ` Philippe Mathieu-Daudé
2019-11-04 15:13 ` [PATCH v7 2/8] Acceptance tests: introduce utility method for tags unique vals Cleber Rosa
2019-11-08 13:14 ` Philippe Mathieu-Daudé
2019-11-11 21:44 ` Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 3/8] Acceptance tests: use avocado tags for machine type Cleber Rosa
2019-11-08 13:20 ` Philippe Mathieu-Daudé
2019-11-11 21:49 ` Cleber Rosa
2019-11-12 18:15 ` Philippe Mathieu-Daudé [this message]
2019-11-12 1:59 ` Cleber Rosa
2019-11-12 18:15 ` Philippe Mathieu-Daudé
2019-11-04 15:13 ` [PATCH v7 4/8] Acceptance tests: use relative location for tests Cleber Rosa
2019-11-04 18:26 ` Philippe Mathieu-Daudé
2019-11-11 22:11 ` Cleber Rosa
2019-11-12 18:17 ` Philippe Mathieu-Daudé
2019-11-07 18:52 ` Wainer dos Santos Moschetta
2019-11-04 15:13 ` [PATCH v7 5/8] Acceptance tests: keep a stable reference to the QEMU build dir Cleber Rosa
2019-11-07 19:22 ` Wainer dos Santos Moschetta
2019-11-11 22:38 ` Cleber Rosa
2019-11-15 21:36 ` Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 6/8] Acceptance tests: add the build directory to the system PATH Cleber Rosa
2019-11-07 19:46 ` Wainer dos Santos Moschetta
2019-11-11 22:49 ` Cleber Rosa
2019-11-12 14:00 ` Wainer dos Santos Moschetta
2019-11-15 23:17 ` Cleber Rosa
2019-11-08 13:13 ` Philippe Mathieu-Daudé
2019-11-15 23:19 ` Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 7/8] Acceptance tests: depend on qemu-img Cleber Rosa
2019-11-07 20:31 ` Wainer dos Santos Moschetta
2019-11-15 23:45 ` Cleber Rosa
2019-11-04 15:13 ` [PATCH v7 8/8] Acceptance test: add "boot_linux" tests Cleber Rosa
2019-11-08 19:42 ` Wainer dos Santos Moschetta
2019-11-15 23:47 ` Cleber Rosa
2019-11-12 18:20 ` Philippe Mathieu-Daudé
2019-11-15 23:48 ` Cleber Rosa
2019-12-03 19:19 ` Alex Bennée
2019-11-04 19:54 ` [PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test no-reply
2019-11-07 18:38 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd5af02-c0cc-813b-1fd0-5e9768833e9d@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=aurelien@aurel32.net \
--cc=bleal@redhat.com \
--cc=chouteau@adacore.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.