From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814D0C433ED for ; Mon, 19 Apr 2021 16:25:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14A5061077 for ; Mon, 19 Apr 2021 16:25:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14A5061077 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYWid-0005OZ-8Q for qemu-devel@archiver.kernel.org; Mon, 19 Apr 2021 12:25:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYWhZ-0004ef-EP; Mon, 19 Apr 2021 12:24:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:48286) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYWhR-0002Ol-SR; Mon, 19 Apr 2021 12:24:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C7C1AAFF8; Mon, 19 Apr 2021 16:24:35 +0000 (UTC) Subject: Re: [RFC v1 1/5] hw/s390x: only build qemu-tod from the CONFIG_TCG build To: Cornelia Huck References: <20210322191551.25752-1-cfontana@suse.de> <20210322191551.25752-2-cfontana@suse.de> <20210331130756.20971c8a.cohuck@redhat.com> <4eaf4c51-b940-66df-7ef7-61782b0cf31d@suse.de> <0eecb78f-c521-f217-1ea5-e570dc080a15@suse.de> <20210419182023.3b44e114.cohuck@redhat.com> From: Claudio Fontana Message-ID: Date: Mon, 19 Apr 2021 18:24:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210419182023.3b44e114.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Richard Henderson , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/19/21 6:20 PM, Cornelia Huck wrote: > On Mon, 19 Apr 2021 18:12:48 +0200 > Claudio Fontana wrote: > >> On 4/19/21 11:11 AM, Claudio Fontana wrote: >>> Hi Cornelia, >>> >>> On 3/31/21 1:07 PM, Cornelia Huck wrote: >>>> On Mon, 22 Mar 2021 20:15:47 +0100 >>>> Claudio Fontana wrote: > >>>>> @@ -25,6 +24,10 @@ s390x_ss.add(when: 'CONFIG_KVM', if_true: files( >>>>> 's390-stattrib-kvm.c', >>>>> 'pv.c', >>>>> )) >>>>> +s390x_ss.add(when: 'CONFIG_TCG', if_true: files( >>>>> + 'tod-qemu.c', >>>> >>>> Should we rename this to tod-tcg.c? >>> >>> I think so. >> >> Here we are a bit limited though by the fact that the object is currently called: >> >> include/hw/s390x/tod.h:26:#define TYPE_QEMU_S390_TOD TYPE_S390_TOD "-qemu" >> >> So there might be a compatibility issue in trying to make this consistent, which would mean to replace this with: >> >> #define TYPE_TCG_S390_TOD TYPE_S390_TOD "-tcg" >> >> What do you think? > > How visible is this? I don't think the TOD objects are instantiable by > the user. > I just remember we were very conservative with the object hierarchy on x86, personally I am fine with the change. I will add this change then, I'd ask for people with concerns about this to speak up: (Paolo?) Ciao, CLaudio