From: Richard Henderson <richard.henderson@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, berrange@redhat.com, qemu-block@nongnu.org,
libvir-list@redhat.com, mreitz@redhat.com, jsnow@redhat.com
Subject: Re: [PATCH v3 3/4] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()
Date: Tue, 9 Mar 2021 12:25:18 -0600 [thread overview]
Message-ID: <ebe654b3-aafb-658d-ba80-ebc3e60d59a5@linaro.org> (raw)
In-Reply-To: <20210309161214.1402527-4-armbru@redhat.com>
On 3/9/21 8:12 AM, Markus Armbruster wrote:
> @@ -2565,6 +2551,7 @@ static void fdctrl_realize_common(DeviceState *dev, FDCtrl *fdctrl,
> Error **errp)
> {
> int i, j;
> + FDrive *drive;
> static int command_tables_inited = 0;
>
> if (fdctrl->fallback == FLOPPY_DRIVE_TYPE_AUTO) {
> @@ -2604,7 +2591,13 @@ static void fdctrl_realize_common(DeviceState *dev, FDCtrl *fdctrl,
> }
>
> floppy_bus_create(fdctrl, &fdctrl->bus, dev);
> - fdctrl_connect_drives(fdctrl, dev, errp);
> +
> + for (i = 0; i < MAX_FD; i++) {
> + drive = &fdctrl->drives[i];
FWIW, the declaration could be local to this loop.
r~
next prev parent reply other threads:[~2021-03-09 20:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 16:12 [PATCH v3 0/4] Drop deprecated floppy config & bogus -drive if=T Markus Armbruster
2021-03-09 16:12 ` [PATCH v3 1/4] docs/system/deprecated: Fix note on fdc drive properties Markus Armbruster
2021-03-09 16:13 ` Daniel P. Berrangé
2021-03-09 16:12 ` [PATCH v3 2/4] fdc: Drop deprecated floppy configuration Markus Armbruster
2021-03-09 16:14 ` Daniel P. Berrangé
2021-03-09 16:12 ` [PATCH v3 3/4] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() Markus Armbruster
2021-03-09 16:15 ` Daniel P. Berrangé
2021-03-09 18:25 ` Richard Henderson [this message]
2021-03-10 8:13 ` Markus Armbruster
2021-03-09 16:12 ` [PATCH v3 4/4] blockdev: Drop deprecated bogus -drive interface type Markus Armbruster
2021-03-09 16:18 ` Daniel P. Berrangé
2021-03-10 8:10 ` Markus Armbruster
2021-03-11 5:00 ` John Snow
2021-03-11 6:29 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe654b3-aafb-658d-ba80-ebc3e60d59a5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.