From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY Date: Wed, 10 Jul 2019 23:29:54 +0000 Message-ID: References: <20190523231758.6230-1-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2538E89895 for ; Wed, 10 Jul 2019 23:29:56 +0000 (UTC) In-Reply-To: <20190523231758.6230-1-rodrigo.vivi@intel.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE5LTA1LTIzIGF0IDE2OjE3IC0wNzAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6DQo+ IFN1c3BlbmQgcmVzdW1lIGlzIGJyb2tlbiBpZiB3ZSB0cnkgdG8gZW5hYmxlL2Rpc2FibGUgZGM5 IG9uDQo+IGNhc2VzIHdpdGggZGlzYWJsZWQgZGlzcGxheXMuDQo+IA0KPiB2MjogTWFrZSBjaGVj a3BhdGNoIGhhcHB5Og0KPiAgICAgLSBicmFjZXMge30gYXJlIG5vdCBuZWNlc3NhcnkgZm9yIHNp bmdsZSBzdGF0ZW1lbnQgYmxvY2tzDQo+IA0KPiB2MzogQWxzbyBtb3ZlIGhzdy9iZHcgUEM4IHNl cXVlbmNlcyBzaW5jZSB0aGV5IGFyZSByZWxhdGVkIHRvDQo+ICAgICBkaXNwbGF5IFBNIGFueXdh eXMuIChWaWxsZSkNCg0KUmV2aWV3ZWQtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uu c291emFAaW50ZWwuY29tPg0KDQo+IA0KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4NCj4gQ2M6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uu c291emFAaW50ZWwuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28u dml2aUBpbnRlbC5jb20+DQo+IFJldmlld2VkLWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxq b3NlLnNvdXphQGludGVsLmNvbT4gKHYxKQ0KPiAtLS0NCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmMgfCAxMTcgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tDQo+IC0tDQo+ ICAxIGZpbGUgY2hhbmdlZCwgNzYgaW5zZXJ0aW9ucygrKSwgNDEgZGVsZXRpb25zKC0pDQo+IA0K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYw0KPiBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMNCj4gaW5kZXggODNkMmViOWU3NGNiLi5iZDczY2U1 Nzc0MWEgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMNCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYw0KPiBAQCAtMjExOCw2ICsyMTE4 LDE3IEBAIGdldF9zdXNwZW5kX21vZGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUNCj4gKmRldl9w cml2LCBib29sIGhpYmVybmF0ZSkNCj4gIAlyZXR1cm4gSTkxNV9EUk1fU1VTUEVORF9NRU07DQo+ ICB9DQo+ICANCj4gK3N0YXRpYyB2b2lkIGludGVsX2Rpc3BsYXlfc3VzcGVuZF9sYXRlKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlDQo+ICpkZXZfcHJpdikNCj4gK3sNCj4gKwlpZiAoIUhBU19ESVNQ TEFZKGRldl9wcml2KSkNCj4gKwkJcmV0dXJuOw0KPiArDQo+ICsJaWYgKElOVEVMX0dFTihkZXZf cHJpdikgPj0gMTEgfHwgSVNfR0VOOV9MUChkZXZfcHJpdikpDQo+ICsJCWJ4dF9lbmFibGVfZGM5 KGRldl9wcml2KTsNCj4gKwllbHNlIGlmIChJU19IQVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9B RFdFTEwoZGV2X3ByaXYpKQ0KPiArCQloc3dfZW5hYmxlX3BjOChkZXZfcHJpdik7DQo+ICt9DQo+ ICsNCj4gIHN0YXRpYyBpbnQgaTkxNV9kcm1fc3VzcGVuZF9sYXRlKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIGJvb2wNCj4gaGliZXJuYXRpb24pDQo+ICB7DQo+ICAJc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOw0KPiBAQCAtMjEzMywxMiArMjE0NCwxMCBA QCBzdGF0aWMgaW50IGk5MTVfZHJtX3N1c3BlbmRfbGF0ZShzdHJ1Y3QNCj4gZHJtX2RldmljZSAq ZGV2LCBib29sIGhpYmVybmF0aW9uKQ0KPiAgCWludGVsX3Bvd2VyX2RvbWFpbnNfc3VzcGVuZChk ZXZfcHJpdiwNCj4gIAkJCQkgICAgZ2V0X3N1c3BlbmRfbW9kZShkZXZfcHJpdiwNCj4gaGliZXJu YXRpb24pKTsNCj4gIA0KPiArCWludGVsX2Rpc3BsYXlfc3VzcGVuZF9sYXRlKGRldl9wcml2KTsN Cj4gKw0KPiAgCXJldCA9IDA7DQo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEgfHwg SVNfR0VOOV9MUChkZXZfcHJpdikpDQo+IC0JCWJ4dF9lbmFibGVfZGM5KGRldl9wcml2KTsNCj4g LQllbHNlIGlmIChJU19IQVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2X3ByaXYp KQ0KPiAtCQloc3dfZW5hYmxlX3BjOChkZXZfcHJpdik7DQo+IC0JZWxzZSBpZiAoSVNfVkFMTEVZ VklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpDQo+ICsJaWYgKElTX1ZB TExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQ0KPiAgCQlyZXQg PSB2bHZfc3VzcGVuZF9jb21wbGV0ZShkZXZfcHJpdik7DQo+ICANCj4gIAlpZiAocmV0KSB7DQo+ IEBAIC0yMjY2LDYgKzIyNzUsMTkgQEAgc3RhdGljIGludCBpOTE1X2RybV9yZXN1bWUoc3RydWN0 IGRybV9kZXZpY2UNCj4gKmRldikNCj4gIAlyZXR1cm4gMDsNCj4gIH0NCj4gIA0KPiArc3RhdGlj IHZvaWQgaW50ZWxfZGlzcGxheV9yZXN1bWVfZWFybHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUN Cj4gKmRldl9wcml2KQ0KPiArew0KPiArCWlmICghSEFTX0RJU1BMQVkoZGV2X3ByaXYpKQ0KPiAr CQlyZXR1cm47DQo+ICsNCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSB8fCBJU19H RU45X0xQKGRldl9wcml2KSkgew0KPiArCQlnZW45X3Nhbml0aXplX2RjX3N0YXRlKGRldl9wcml2 KTsNCj4gKwkJYnh0X2Rpc2FibGVfZGM5KGRldl9wcml2KTsNCj4gKwl9IGVsc2UgaWYgKElTX0hB U1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsNCj4gKwkJaHN3X2Rp c2FibGVfcGM4KGRldl9wcml2KTsNCj4gKwl9DQo+ICt9DQo+ICsNCj4gIHN0YXRpYyBpbnQgaTkx NV9kcm1fcmVzdW1lX2Vhcmx5KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpDQo+ICB7DQo+ICAJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOw0KPiBAQCAtMjMy OCwxMiArMjM1MCw3IEBAIHN0YXRpYyBpbnQgaTkxNV9kcm1fcmVzdW1lX2Vhcmx5KHN0cnVjdA0K PiBkcm1fZGV2aWNlICpkZXYpDQo+ICANCj4gIAlpOTE1X2NoZWNrX2FuZF9jbGVhcl9mYXVsdHMo ZGV2X3ByaXYpOw0KPiAgDQo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEgfHwgSVNf R0VOOV9MUChkZXZfcHJpdikpIHsNCj4gLQkJZ2VuOV9zYW5pdGl6ZV9kY19zdGF0ZShkZXZfcHJp dik7DQo+IC0JCWJ4dF9kaXNhYmxlX2RjOShkZXZfcHJpdik7DQo+IC0JfSBlbHNlIGlmIChJU19I QVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7DQo+IC0JCWhzd19k aXNhYmxlX3BjOChkZXZfcHJpdik7DQo+IC0JfQ0KPiArCWludGVsX2Rpc3BsYXlfcmVzdW1lX2Vh cmx5KGRldl9wcml2KTsNCj4gIA0KPiAgCWludGVsX3VuY29yZV9zYW5pdGl6ZShkZXZfcHJpdik7 DQo+ICANCj4gQEAgLTI4NjksNiArMjg4NiwyMiBAQCBzdGF0aWMgaW50IHZsdl9yZXN1bWVfcHJl cGFyZShzdHJ1Y3QNCj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsDQo+ICAJcmV0dXJuIHJl dDsNCj4gIH0NCj4gIA0KPiArc3RhdGljIHZvaWQgaW50ZWxfcnVudGltZV9kaXNwbGF5X3N1c3Bl bmQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUNCj4gKmRldl9wcml2KQ0KPiArew0KPiArCWlmICgh SEFTX0RJU1BMQVkoZGV2X3ByaXYpKQ0KPiArCQlyZXR1cm47DQo+ICsNCj4gKwlpZiAoSU5URUxf R0VOKGRldl9wcml2KSA+PSAxMSkgew0KPiArCQlpY2xfZGlzcGxheV9jb3JlX3VuaW5pdChkZXZf cHJpdik7DQo+ICsJCWJ4dF9lbmFibGVfZGM5KGRldl9wcml2KTsNCj4gKwl9IGVsc2UgaWYgKElT X0dFTjlfTFAoZGV2X3ByaXYpKSB7DQo+ICsJCWJ4dF9kaXNwbGF5X2NvcmVfdW5pbml0KGRldl9w cml2KTsNCj4gKwkJYnh0X2VuYWJsZV9kYzkoZGV2X3ByaXYpOw0KPiArCX0gZWxzZSBpZiAoSVNf SEFTV0VMTChkZXZfcHJpdikgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkgew0KPiArCQloc3df ZW5hYmxlX3BjOChkZXZfcHJpdik7DQo+ICsJfQ0KPiArfQ0KPiArDQo+ICBzdGF0aWMgaW50IGlu dGVsX3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICprZGV2KQ0KPiAgew0KPiAgCXN0cnVj dCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihrZGV2KTsNCj4gQEAgLTI4OTgsMTggKzI5MzEs MTEgQEAgc3RhdGljIGludCBpbnRlbF9ydW50aW1lX3N1c3BlbmQoc3RydWN0DQo+IGRldmljZSAq a2RldikNCj4gIA0KPiAgCWludGVsX3VuY29yZV9zdXNwZW5kKCZkZXZfcHJpdi0+dW5jb3JlKTsN Cj4gIA0KPiArCWludGVsX3J1bnRpbWVfZGlzcGxheV9zdXNwZW5kKGRldl9wcml2KTsNCj4gKw0K PiAgCXJldCA9IDA7DQo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpIHsNCj4gLQkJ aWNsX2Rpc3BsYXlfY29yZV91bmluaXQoZGV2X3ByaXYpOw0KPiAtCQlieHRfZW5hYmxlX2RjOShk ZXZfcHJpdik7DQo+IC0JfSBlbHNlIGlmIChJU19HRU45X0xQKGRldl9wcml2KSkgew0KPiAtCQli eHRfZGlzcGxheV9jb3JlX3VuaW5pdChkZXZfcHJpdik7DQo+IC0JCWJ4dF9lbmFibGVfZGM5KGRl dl9wcml2KTsNCj4gLQl9IGVsc2UgaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8IElTX0JST0FE V0VMTChkZXZfcHJpdikpIHsNCj4gLQkJaHN3X2VuYWJsZV9wYzgoZGV2X3ByaXYpOw0KPiAtCX0g ZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZfcHJp dikpDQo+IHsNCj4gKwlpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklF VyhkZXZfcHJpdikpDQo+ICAJCXJldCA9IHZsdl9zdXNwZW5kX2NvbXBsZXRlKGRldl9wcml2KTsN Cj4gLQl9DQo+ICANCj4gIAlpZiAocmV0KSB7DQo+ICAJCURSTV9FUlJPUigiUnVudGltZSBzdXNw ZW5kIGZhaWxlZCwgZGlzYWJsaW5nIGl0DQo+ICglZClcbiIsIHJldCk7DQo+IEBAIC0yOTY3LDI1 ICsyOTkzLDEwIEBAIHN0YXRpYyBpbnQgaW50ZWxfcnVudGltZV9zdXNwZW5kKHN0cnVjdA0KPiBk ZXZpY2UgKmtkZXYpDQo+ICAJcmV0dXJuIDA7DQo+ICB9DQo+ICANCj4gLXN0YXRpYyBpbnQgaW50 ZWxfcnVudGltZV9yZXN1bWUoc3RydWN0IGRldmljZSAqa2RldikNCj4gK3N0YXRpYyB2b2lkIGlu dGVsX3J1bnRpbWVfZGlzcGxheV9yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUNCj4gKmRl dl9wcml2KQ0KPiAgew0KPiAtCXN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihrZGV2 KTsNCj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcGNpX2dldF9kcnZkYXRhKHBkZXYpOw0K PiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsNCj4g LQlpbnQgcmV0ID0gMDsNCj4gLQ0KPiAtCWlmIChXQVJOX09OX09OQ0UoIUhBU19SVU5USU1FX1BN KGRldl9wcml2KSkpDQo+IC0JCXJldHVybiAtRU5PREVWOw0KPiAtDQo+IC0JRFJNX0RFQlVHX0tN UygiUmVzdW1pbmcgZGV2aWNlXG4iKTsNCj4gLQ0KPiAtCVdBUk5fT05fT05DRShhdG9taWNfcmVh ZCgmZGV2X3ByaXYtPnJ1bnRpbWVfcG0ud2FrZXJlZl9jb3VudCkpOw0KPiAtCWRpc2FibGVfcnBt X3dha2VyZWZfYXNzZXJ0cyhkZXZfcHJpdik7DQo+IC0NCj4gLQlpbnRlbF9vcHJlZ2lvbl9ub3Rp ZnlfYWRhcHRlcihkZXZfcHJpdiwgUENJX0QwKTsNCj4gLQlkZXZfcHJpdi0+cnVudGltZV9wbS5z dXNwZW5kZWQgPSBmYWxzZTsNCj4gLQlpZiAoaW50ZWxfdW5jb3JlX3VuY2xhaW1lZF9tbWlvKCZk ZXZfcHJpdi0+dW5jb3JlKSkNCj4gLQkJRFJNX0RFQlVHX0RSSVZFUigiVW5jbGFpbWVkIGFjY2Vz cyBkdXJpbmcgc3VzcGVuZCwNCj4gYmlvcz9cbiIpOw0KPiArCWlmICghSEFTX0RJU1BMQVkoZGV2 X3ByaXYpKQ0KPiArCQlyZXR1cm47DQo+ICANCj4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+ PSAxMSkgew0KPiAgCQlieHRfZGlzYWJsZV9kYzkoZGV2X3ByaXYpOw0KPiBAQCAtMzAwNiw5ICsz MDE3LDMzIEBAIHN0YXRpYyBpbnQgaW50ZWxfcnVudGltZV9yZXN1bWUoc3RydWN0IGRldmljZQ0K PiAqa2RldikNCj4gIAkJCWdlbjlfZW5hYmxlX2RjNShkZXZfcHJpdik7DQo+ICAJfSBlbHNlIGlm IChJU19IQVNXRUxMKGRldl9wcml2KSB8fCBJU19CUk9BRFdFTEwoZGV2X3ByaXYpKSB7DQo+ICAJ CWhzd19kaXNhYmxlX3BjOChkZXZfcHJpdik7DQo+IC0JfSBlbHNlIGlmIChJU19WQUxMRVlWSUVX KGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkNCj4gew0KPiAtCQlyZXQgPSB2 bHZfcmVzdW1lX3ByZXBhcmUoZGV2X3ByaXYsIHRydWUpOw0KPiAgCX0NCj4gK30NCj4gKw0KPiAr c3RhdGljIGludCBpbnRlbF9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICprZGV2KQ0KPiAr ew0KPiArCXN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gdG9fcGNpX2RldihrZGV2KTsNCj4gKwlzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2ID0gcGNpX2dldF9kcnZkYXRhKHBkZXYpOw0KPiArCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsNCj4gKwlpbnQgcmV0ID0g MDsNCj4gKw0KPiArCWlmIChXQVJOX09OX09OQ0UoIUhBU19SVU5USU1FX1BNKGRldl9wcml2KSkp DQo+ICsJCXJldHVybiAtRU5PREVWOw0KPiArDQo+ICsJRFJNX0RFQlVHX0tNUygiUmVzdW1pbmcg ZGV2aWNlXG4iKTsNCj4gKw0KPiArCVdBUk5fT05fT05DRShhdG9taWNfcmVhZCgmZGV2X3ByaXYt PnJ1bnRpbWVfcG0ud2FrZXJlZl9jb3VudCkpOw0KPiArCWRpc2FibGVfcnBtX3dha2VyZWZfYXNz ZXJ0cyhkZXZfcHJpdik7DQo+ICsNCj4gKwlpbnRlbF9vcHJlZ2lvbl9ub3RpZnlfYWRhcHRlcihk ZXZfcHJpdiwgUENJX0QwKTsNCj4gKwlkZXZfcHJpdi0+cnVudGltZV9wbS5zdXNwZW5kZWQgPSBm YWxzZTsNCj4gKwlpZiAoaW50ZWxfdW5jb3JlX3VuY2xhaW1lZF9tbWlvKCZkZXZfcHJpdi0+dW5j b3JlKSkNCj4gKwkJRFJNX0RFQlVHX0RSSVZFUigiVW5jbGFpbWVkIGFjY2VzcyBkdXJpbmcgc3Vz cGVuZCwNCj4gYmlvcz9cbiIpOw0KPiArDQo+ICsJaW50ZWxfcnVudGltZV9kaXNwbGF5X3Jlc3Vt ZShkZXZfcHJpdik7DQo+ICsNCj4gKwlpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNf Q0hFUlJZVklFVyhkZXZfcHJpdikpDQo+ICsJCXJldCA9IHZsdl9yZXN1bWVfcHJlcGFyZShkZXZf cHJpdiwgdHJ1ZSk7DQo+ICANCj4gIAlpbnRlbF91bmNvcmVfcnVudGltZV9yZXN1bWUoJmRldl9w cml2LT51bmNvcmUpOw0KPiAgDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZng=