From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB6AEC433E0 for ; Fri, 17 Jul 2020 23:57:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8213420739 for ; Fri, 17 Jul 2020 23:57:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="QOvLbloS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728249AbgGQX5w (ORCPT ); Fri, 17 Jul 2020 19:57:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727946AbgGQX5v (ORCPT ); Fri, 17 Jul 2020 19:57:51 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43FD6C0619D3 for ; Fri, 17 Jul 2020 16:57:51 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id p20so12616241ejd.13 for ; Fri, 17 Jul 2020 16:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=90BDAQt2ZKjpK6dC2RjNJvlJ6X9bNG9d2FjodAiTaIs=; b=QOvLbloSaN5KHLKmGPPgrN2pCkLUwBvPDo3+63ct4xAZbGv8y8iBEtS5iP7XP/4rUk Y4lZShsdYs+6AzwCkUtJBBKHgwUj2L2uaI0p/JNx6ooMbyU5ivWKklcm9U63APZ8USIm 1dpu9UsPvaSvEBCikT2WBCJMi4zKMZDJxXDuk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=90BDAQt2ZKjpK6dC2RjNJvlJ6X9bNG9d2FjodAiTaIs=; b=p5QfdhzXP/83JKKw+syJyXfptWEiWdyGVsXcT0NhhZhiqBTOeFrXnZWFAZ2Yt9BeqX xbWZWJx2pP6SkhbipertDxErSx9maevZCaUyUfVa7ygSuyT+Ya71U4X9bb3zZI43g38H cZiQk9YfUhMl5bb5Vr7V+bncCC86+VV4zas9fs9XcA6e8JgH6tesKG/gUSua1Lf898og 5xaO+9nBDL7+aqoa9AVjV92AHsBjFVrhx26UIc4ZtNgLa2XPZuAFXeTWmiy7k7QEEgTK wpnjXfRU+89SayHkkw3QL2ffWVBb+kfiJfLCoXrycOxxooclBOV0qveO/fXx+9Mvk2rQ sObw== X-Gm-Message-State: AOAM531EGqVfbNtVRnRIrxPIFCybJ70IPGHNBtcLpUu0g/OCFZLYYdaY H7+Wj1K65NXBe3epLcHDWySWNxHvE/ob5SF0 X-Google-Smtp-Source: ABdhPJzZICwvD2lHCdBPoedxxdB9CsLD8/5+wD8myd8nLObsSVSXyyF19NYub8OSky354S+yneJZXQ== X-Received: by 2002:a17:906:aac9:: with SMTP id kt9mr10580040ejb.488.1595030269688; Fri, 17 Jul 2020 16:57:49 -0700 (PDT) Received: from [192.168.1.201] (d66-183-107-60.bchsia.telus.net. [66.183.107.60]) by smtp.gmail.com with ESMTPSA id g21sm9593764edr.45.2020.07.17.16.57.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 16:57:48 -0700 (PDT) Subject: Re: [PATCH v3] pwm: bcm-iproc: handle clk_get_rate() return To: Scott Branden , Thierry Reding , Lee Jones Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , BCM Kernel Feedback , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Rayagonda Kokatanur References: <20200717231954.11695-1-scott.branden@broadcom.com> From: Ray Jui Message-ID: Date: Fri, 17 Jul 2020 16:57:44 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200717231954.11695-1-scott.branden@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/17/2020 4:19 PM, Scott Branden wrote: > From: Rayagonda Kokatanur > > Handle clk_get_rate() returning 0 to avoid possible division by zero. > > Fixes: daa5abc41c80 ("pwm: Add support for Broadcom iProc PWM controller") > Signed-off-by: Rayagonda Kokatanur > Signed-off-by: Scott Branden > Reviewed-off-by: Ray Jui Typo. Should be 'Reviewed-by: Ray Jui ', :) > > --- > Changes from v2: update commit message to remove <= condition > as clk_get_rate only returns value >= 0 > --- > drivers/pwm/pwm-bcm-iproc.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c > index 1f829edd8ee7..d392a828fc49 100644 > --- a/drivers/pwm/pwm-bcm-iproc.c > +++ b/drivers/pwm/pwm-bcm-iproc.c > @@ -85,8 +85,6 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > u64 tmp, multi, rate; > u32 value, prescale; > > - rate = clk_get_rate(ip->clk); > - > value = readl(ip->base + IPROC_PWM_CTRL_OFFSET); > > if (value & BIT(IPROC_PWM_CTRL_EN_SHIFT(pwm->hwpwm))) > @@ -99,6 +97,13 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm, > else > state->polarity = PWM_POLARITY_INVERSED; > > + rate = clk_get_rate(ip->clk); > + if (rate == 0) { > + state->period = 0; > + state->duty_cycle = 0; > + return; > + } > + > value = readl(ip->base + IPROC_PWM_PRESCALE_OFFSET); > prescale = value >> IPROC_PWM_PRESCALE_SHIFT(pwm->hwpwm); > prescale &= IPROC_PWM_PRESCALE_MAX; >