From: POPESCU Catalin <catalin.popescu@leica-geosystems.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
GEO-CHHER-bsp-development
<bsp-development.geo@leica-geosystems.com>
Subject: Re: [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across suspends
Date: Wed, 3 Apr 2024 07:15:07 +0000 [thread overview]
Message-ID: <ebf88d8f-c5e7-49c1-ac7f-ee7fef9bffe3@leica-geosystems.com> (raw)
In-Reply-To: <20240402174536.75cbe074@kernel.org>
On 03/04/2024 02:45, Jakub Kicinski wrote:
> [Some people who received this message don't often get email from kuba@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On Thu, 28 Mar 2024 14:33:58 +0100 Catalin Popescu wrote:
>> -static int dp83822_set_wol(struct phy_device *phydev,
>> - struct ethtool_wolinfo *wol)
>> +static int _dp83822_set_wol(struct phy_device *phydev,
>> + struct ethtool_wolinfo *wol)
> Why the underscore, you can all this any number of things maybe
> dp83822_config_wol() or dp83822_apply_wol()?
Sure, I'll use dp83822_config_wol.
prev parent reply other threads:[~2024-04-03 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 13:33 [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across suspends Catalin Popescu
2024-04-03 0:45 ` Jakub Kicinski
2024-04-03 7:15 ` POPESCU Catalin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebf88d8f-c5e7-49c1-ac7f-ee7fef9bffe3@leica-geosystems.com \
--to=catalin.popescu@leica-geosystems.com \
--cc=andrew@lunn.ch \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.felsch@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.