From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Stefan Agner <stefan@agner.ch>
Cc: muhammad_shakeel@mentor.com,
Stefan Agner <stefan.agner@toradex.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/3] postinsts fixes
Date: Tue, 15 May 2018 19:07:19 +0300 [thread overview]
Message-ID: <ec1476d7-1757-ebf9-7259-c2d55638b42e@linux.intel.com> (raw)
In-Reply-To: <e2efa2cc72ff1bf2c9620e1fd9ebaece@agner.ch>
On 05/15/2018 07:07 PM, Stefan Agner wrote:
> On 15.05.2018 17:03, Alexander Kanavin wrote:
>> On 05/15/2018 05:04 PM, Stefan Agner wrote:
>>> This follows up on the discussion a while ago:
>>> https://www.mail-archive.com/openembedded-core@lists.openembedded.org/msg104996.html
>>
>> Took me a moment to realize all three patches are specific to
>> opkg/dpkg and do not change how rpm (or general 'postinst handling')
>> works. Perhaps you could amend the commit messages to emphasize that?
>
> Patch 1 has opkg in the subject.
>
> Patch 2/3 mention opkg/dpkg in the commit log.
>
> Patch 3 also really edits the DpkgOpkgRootfs class, which should make it
> rather obvious.
>
> But I agree for patch 2 it would be good to emphasize it.
>
> How about adding this after the first paragraph:
> The behavior for rpm stays the same.
That, and amend the commit summaries:
patch 2:
run-postinsts: for dpkg/opkg, do not rely on /etc/*-postinsts
patch 3:
rootfs.py: for dpkg/opkg, don't install postinsts if package management
is present
Otherwise those one liners can give the wrong impression.
Alex
prev parent reply other threads:[~2018-05-15 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 14:04 [PATCH 0/3] postinsts fixes Stefan Agner
2018-05-15 14:04 ` [PATCH 1/3] opkg: avoid running postinst scripts twice when using systemd Stefan Agner
2018-06-05 22:17 ` Christopher Larson
2018-05-15 14:04 ` [PATCH 2/3] run-postinsts: Do not rely on /etc/*-postinsts Stefan Agner
2018-05-15 14:04 ` [PATCH 3/3] rootfs.py: Don't install postinsts if package management is present Stefan Agner
2018-05-15 15:03 ` [PATCH 0/3] postinsts fixes Alexander Kanavin
2018-05-15 16:07 ` Stefan Agner
2018-05-15 16:07 ` Alexander Kanavin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1476d7-1757-ebf9-7259-c2d55638b42e@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=muhammad_shakeel@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=stefan.agner@toradex.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.