From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BFDC48BD4 for ; Tue, 25 Jun 2019 17:05:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B97B20645 for ; Tue, 25 Jun 2019 17:05:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731097AbfFYRFl (ORCPT ); Tue, 25 Jun 2019 13:05:41 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:34074 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727215AbfFYRF1 (ORCPT ); Tue, 25 Jun 2019 13:05:27 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id ED25EFB02; Tue, 25 Jun 2019 19:05:23 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ILinwd_cVNSn; Tue, 25 Jun 2019 19:05:22 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 59B7648E34; Tue, 25 Jun 2019 19:05:19 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Nicolas Ferre , "Paul E. McKenney" , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Purism Kernel Team Subject: [PATCH 2/4] drm/panel: jh057n0090: Don't use magic constant Date: Tue, 25 Jun 2019 19:05:17 +0200 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 0xBF isn't in any ST7703 data sheet so mark it as unknown. This avoids confusion on whether there is a missing command in that dsi_generic_write_seq() call. Signed-off-by: Guido Günther --- drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c index 6dcb692c4701..b8a069055fbc 100644 --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c @@ -33,6 +33,7 @@ #define ST7703_CMD_SETEXTC 0xB9 #define ST7703_CMD_SETMIPI 0xBA #define ST7703_CMD_SETVDC 0xBC +#define ST7703_CMD_UNKNOWN0 0xBF #define ST7703_CMD_SETSCR 0xC0 #define ST7703_CMD_SETPOWER 0xC1 #define ST7703_CMD_SETPANEL 0xCC @@ -94,7 +95,7 @@ static int jh057n_init_sequence(struct jh057n *ctx) msleep(20); dsi_generic_write_seq(dsi, ST7703_CMD_SETVCOM, 0x3F, 0x3F); - dsi_generic_write_seq(dsi, 0xBF, 0x02, 0x11, 0x00); + dsi_generic_write_seq(dsi, ST7703_CMD_UNKNOWN0, 0x02, 0x11, 0x00); dsi_generic_write_seq(dsi, ST7703_CMD_SETGIP1, 0x82, 0x10, 0x06, 0x05, 0x9E, 0x0A, 0xA5, 0x12, 0x31, 0x23, 0x37, 0x83, 0x04, 0xBC, 0x27, 0x38, -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Subject: [PATCH 2/4] drm/panel: jh057n0090: Don't use magic constant Date: Tue, 25 Jun 2019 19:05:17 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Nicolas Ferre , "Paul E. McKenney" , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Purism Kernel Team List-Id: devicetree@vger.kernel.org MHhCRiBpc24ndCBpbiBhbnkgU1Q3NzAzIGRhdGEgc2hlZXQgc28gbWFyayBpdCBhcyB1bmtub3du LiBUaGlzIGF2b2lkcwpjb25mdXNpb24gb24gd2hldGhlciB0aGVyZSBpcyBhIG1pc3NpbmcgY29t bWFuZCBpbiB0aGF0CmRzaV9nZW5lcmljX3dyaXRlX3NlcSgpIGNhbGwuCgpTaWduZWQtb2ZmLWJ5 OiBHdWlkbyBHw7xudGhlciA8YWd4QHNpZ3hjcHUub3JnPgotLS0KIGRyaXZlcnMvZ3B1L2RybS9w YW5lbC9wYW5lbC1yb2NrdGVjaC1qaDA1N24wMDkwMC5jIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vcGFuZWwvcGFuZWwtcm9ja3RlY2gtamgwNTduMDA5MDAuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9wYW5lbC9wYW5lbC1yb2NrdGVjaC1qaDA1N24wMDkwMC5jCmluZGV4IDZkY2I2OTJjNDcwMS4u YjhhMDY5MDU1ZmJjIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcm9j a3RlY2gtamgwNTduMDA5MDAuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtcm9j a3RlY2gtamgwNTduMDA5MDAuYwpAQCAtMzMsNiArMzMsNyBAQAogI2RlZmluZSBTVDc3MDNfQ01E X1NFVEVYVEMJIDB4QjkKICNkZWZpbmUgU1Q3NzAzX0NNRF9TRVRNSVBJCSAweEJBCiAjZGVmaW5l IFNUNzcwM19DTURfU0VUVkRDCSAweEJDCisjZGVmaW5lIFNUNzcwM19DTURfVU5LTk9XTjAJIDB4 QkYKICNkZWZpbmUgU1Q3NzAzX0NNRF9TRVRTQ1IJIDB4QzAKICNkZWZpbmUgU1Q3NzAzX0NNRF9T RVRQT1dFUgkgMHhDMQogI2RlZmluZSBTVDc3MDNfQ01EX1NFVFBBTkVMCSAweENDCkBAIC05NCw3 ICs5NSw3IEBAIHN0YXRpYyBpbnQgamgwNTduX2luaXRfc2VxdWVuY2Uoc3RydWN0IGpoMDU3biAq Y3R4KQogCW1zbGVlcCgyMCk7CiAKIAlkc2lfZ2VuZXJpY193cml0ZV9zZXEoZHNpLCBTVDc3MDNf Q01EX1NFVFZDT00sIDB4M0YsIDB4M0YpOwotCWRzaV9nZW5lcmljX3dyaXRlX3NlcShkc2ksIDB4 QkYsIDB4MDIsIDB4MTEsIDB4MDApOworCWRzaV9nZW5lcmljX3dyaXRlX3NlcShkc2ksIFNUNzcw M19DTURfVU5LTk9XTjAsIDB4MDIsIDB4MTEsIDB4MDApOwogCWRzaV9nZW5lcmljX3dyaXRlX3Nl cShkc2ksIFNUNzcwM19DTURfU0VUR0lQMSwKIAkJCSAgICAgIDB4ODIsIDB4MTAsIDB4MDYsIDB4 MDUsIDB4OUUsIDB4MEEsIDB4QTUsIDB4MTIsCiAJCQkgICAgICAweDMxLCAweDIzLCAweDM3LCAw eDgzLCAweDA0LCAweEJDLCAweDI3LCAweDM4LAotLSAKMi4yMC4xCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=