From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Thu, 16 Nov 2017 15:40:25 -0600 Message-ID: References: <20171115194203.13572-1-dmurphy@ti.com> <20171116154139.wed7qmpmv2ffyzv2@rob-hp-laptop> <20171116201121.GA28848@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , Pavel Machek Cc: Mark Rutland , Richard Purdie , Jacek Anaszewski , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux LED Subsystem List-Id: linux-leds@vger.kernel.org On 11/16/2017 02:36 PM, Rob Herring wrote: > On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek wrote: >> Hi! >> >>>>> +Required properties: >>>>> + - compatible: >>>>> + "ti,lm3692x" >>>> >>>> Don't use wildcards in compatible strings. >>> >>> Do you mean to remove the x? How do we denote a family of parts >>> then? >> >> I guess you should specify the exact chip. >> >> Which will present interesting problem for me on Nokia N9/N950; in one >> case, compatible chip is produced by two companies, and it looks like >> some machines have one and some have the other; but we'd like to share >> the dts as user has no chance telling them apart (and it is not >> important, anyway). >> >> In second case, chip is refered as APDS990X and I don't know where to >> get more exact data. > > There's always exceptions to rules. Just make the case for it. IIRC, > there was the same case for the BT chip. > Not sure how I got looped into the dts fun. But I am going to call out the specific chips out in the compatible strings. There are currently only 2 devices supported by this driver. The delta between the chips is one supports a third string of LEDs. 1 bit in 1 register. Dan > Rob > -- ------------------ Dan Murphy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935491AbdKPVlW (ORCPT ); Thu, 16 Nov 2017 16:41:22 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:53737 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933865AbdKPVlF (ORCPT ); Thu, 16 Nov 2017 16:41:05 -0500 Subject: Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver To: Rob Herring , Pavel Machek CC: Mark Rutland , Richard Purdie , Jacek Anaszewski , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux LED Subsystem References: <20171115194203.13572-1-dmurphy@ti.com> <20171116154139.wed7qmpmv2ffyzv2@rob-hp-laptop> <20171116201121.GA28848@amd> From: Dan Murphy Message-ID: Date: Thu, 16 Nov 2017 15:40:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/2017 02:36 PM, Rob Herring wrote: > On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek wrote: >> Hi! >> >>>>> +Required properties: >>>>> + - compatible: >>>>> + "ti,lm3692x" >>>> >>>> Don't use wildcards in compatible strings. >>> >>> Do you mean to remove the x? How do we denote a family of parts >>> then? >> >> I guess you should specify the exact chip. >> >> Which will present interesting problem for me on Nokia N9/N950; in one >> case, compatible chip is produced by two companies, and it looks like >> some machines have one and some have the other; but we'd like to share >> the dts as user has no chance telling them apart (and it is not >> important, anyway). >> >> In second case, chip is refered as APDS990X and I don't know where to >> get more exact data. > > There's always exceptions to rules. Just make the case for it. IIRC, > there was the same case for the BT chip. > Not sure how I got looped into the dts fun. But I am going to call out the specific chips out in the compatible strings. There are currently only 2 devices supported by this driver. The delta between the chips is one supports a third string of LEDs. 1 bit in 1 register. Dan > Rob > -- ------------------ Dan Murphy