From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073ACC48BCD for ; Wed, 9 Jun 2021 13:27:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E562F6108E for ; Wed, 9 Jun 2021 13:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235166AbhFIN3G (ORCPT ); Wed, 9 Jun 2021 09:29:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49640 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233302AbhFIN3E (ORCPT ); Wed, 9 Jun 2021 09:29:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623245229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ohr3+N5+xISuDSpVy5HLd2jlXJtsoJDH7zUknKOaVE=; b=Pbyq3avq+eG3xosDAZfc/FYyJPgsaM0fpzrMWk5XkcMXPxIJp3RDJ8EvM9v2TVrHw+HbkZ QizTg0RUgQz5/Ttx/dhS2fuZ5QnFoiKvteK8bW6xD4ziet8a3iy+vxDp4hii6HhRjlWcIf RgIGp44yaYMF1F5HbWll3GuxRBC5kPE= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-IDPNACDtPai5U8AEuSbAGA-1; Wed, 09 Jun 2021 09:27:08 -0400 X-MC-Unique: IDPNACDtPai5U8AEuSbAGA-1 Received: by mail-oo1-f72.google.com with SMTP id o2-20020a4ad4820000b0290208a2516d36so15523407oos.16 for ; Wed, 09 Jun 2021 06:27:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9ohr3+N5+xISuDSpVy5HLd2jlXJtsoJDH7zUknKOaVE=; b=TOtb+gtEwNgjq4H75NmWSftqRzVJ0Uv0CE4N1TvQHBLMRLqsNt3jH5OVppklBxZlb+ OzV4wuptN8vHuKxX+v/DRtItV09MLYdR7U8/lPxu79iGuALVHwyJF8i23i51+rqkxp3j vhlOFBSk2xDshN9fmyWSu3/vnAhF+8tnr+zfwqkPPze/O3mcr0b2E32LvIc6lqSZj3wM uLzSk/dSQpSec5sdDKRYKoNgglHt/CGNRAuHDztPk1kB1mpBsAupUhkMmkXJia8f7sva PKERLfxcSyyx2VOfEJozhcKxuRffVlKrVztXo/EVxmNaSXEobx9U1rjVzW9BM6Ui5ZSl 4Qvg== X-Gm-Message-State: AOAM5316MKTqCb06CW3QnVSThTZZNL6nDsbd06N5PNOyGSECYsDv90Hk 1WrD/L7CmcQTbcd6jmGE3hOScZKdsyG00eXEoQVci3GmDoQc8Cd1CmIsE7lQSgi4+aStRblc6ee pbhASGAfCLupPccjOH9uErY1Uq7hdBAELR7U/+u5272WhiK/mjfwYEubDRcXmCO0XzUcEtiI= X-Received: by 2002:a9d:7096:: with SMTP id l22mr1480965otj.79.1623245227491; Wed, 09 Jun 2021 06:27:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxknDhyZXQ2dREilj+RsfQ2CcUmDo/spMg54cPqAUNtnKCISJ8SIDWlXQ2kuypYzZqZH5QCnA== X-Received: by 2002:a9d:7096:: with SMTP id l22mr1480942otj.79.1623245227268; Wed, 09 Jun 2021 06:27:07 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id z14sm3760901oti.29.2021.06.09.06.27.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 06:27:07 -0700 (PDT) Subject: Re: [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files To: Greg KH Cc: mdf@kernel.org, michal.simek@xilinx.com, nava.manne@xilinx.com, luca@lucaceresoli.net, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210608162551.3010533-1-trix@redhat.com> From: Tom Rix Message-ID: Date: Wed, 9 Jun 2021 06:27:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/21 2:59 AM, Greg KH wrote: > On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote: >> From: Tom Rix >> >> It is not necessary to have a xilinx- prefix on a file >> when the file is in a xilinx/ subdir. >> >> Signed-off-by: Tom Rix >> --- >> drivers/fpga/xilinx/Makefile | 4 ++-- >> drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 >> drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 >> 3 files changed, 2 insertions(+), 2 deletions(-) >> rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) >> rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%) >> >> diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile >> index 7bb7543412790..4ac727d03e140 100644 >> --- a/drivers/fpga/xilinx/Makefile >> +++ b/drivers/fpga/xilinx/Makefile >> @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0 >> >> -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o >> -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o >> +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o >> +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o > You just renamed the module to be called "spi.ko"???? > > Did you test this thing? You can not rename modules without good > reasons, and calling a device specific kernel module "spi.ko" is not ok. yes, this is a problem, I will drop the renaming patches. Tom > greg k-h > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A0DC48BCD for ; Wed, 9 Jun 2021 14:06:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63F1261364 for ; Wed, 9 Jun 2021 14:06:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63F1261364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BXz/CduTw38GHSkzdH4KRHk40hfr58H4vbgB3UepTME=; b=z0HMVeLCDcqB4Ix7AAYaXLX4dm Rxr55FR1rCNeg2aaKdzDYuB1jcwHsXnkHEBqFyOmp1igelNcWYkploPmSUyIX5PFNqS5wNQ8fFgJW s4F1SUaz5hafSVvoKnMUwQmIlsGMBqxfi1fB78tvQAaNBwC8FP1kbfHLpsR9dd3yC3zXhCwHs0RVi EsquKpfbQTc3XGZlli9xBEFNqnASKx/5Ryan64q4tCBQCURuM+YEiMGocbN8iFuWzWJwrEQzqNtaC BXeOHNsV7Yp7WurytIlxc/SCClegbaMvRb0zu7b08gdxbUGAlIIvU6AXgNAgnuaKNLSewmPY5lYkh FXKk4rdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqynq-00EBT1-Eu; Wed, 09 Jun 2021 14:03:33 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqyEh-00Dzpi-20 for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 13:27:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623245230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ohr3+N5+xISuDSpVy5HLd2jlXJtsoJDH7zUknKOaVE=; b=WYgPlvviUtHtbYqG6xqpTt7whFr4R1wAbDN1gvczoy3rmPKG9znJC2aoJA6pWuNcH4ntNN mDwi4uw0qEWJopFZGVjwfQ9z2Hea7FXfmtqr2v72WMSM5QuRFQ5GVR565sFXAiugDAkYTu Ewofs1stVsLBgfq1Kj/bB4Q+NIMA6qk= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375--YHRBufION27f9AqECxBRg-1; Wed, 09 Jun 2021 09:27:08 -0400 X-MC-Unique: -YHRBufION27f9AqECxBRg-1 Received: by mail-oo1-f72.google.com with SMTP id m22-20020a0568200356b0290248e4270f00so12831724ooe.14 for ; Wed, 09 Jun 2021 06:27:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9ohr3+N5+xISuDSpVy5HLd2jlXJtsoJDH7zUknKOaVE=; b=CrkS71cTpUN9QmbVZi5Vq7acvPcEwWzVYDnfZt/xG0/lHObqT0sxktO5PWmrkLow9Y LbdrLuBGmxC2zWjQ4rAC3NPfBq+wwcYS34WSV/QfczDQKqcdQonVGNawySUeMZb+Hn6R v82Lr77nJua474q8UEzHAVpzQm4r6Dz/oFIT9fur342IoVAF79QlrrYuFCN2mH7bRTxn kcimTIBkGWcjtI+PIRljFaT/+YXD+I/9aBVbv5iQ8bbNqS8G/HTcZjdQwVaCddtIVoNH jpjYf/7D5DHXHM/yw8xaRMZrskFQKJAGinta05qmmvbrHybTOnXMFXuhzruQuglObJiT USrw== X-Gm-Message-State: AOAM532BglmmK7Xco7ndhnSjn6aRc6Wxg2yoWCEPOZKc9/MHMF4vyIVj XINfOAXZM3/KCpd38K8b+CJYPHQc/YHvg9tmIFPzwhUjFKlZlGgqoMaRBNGrztReB/aoN+Jlx0d 1tGJ9SIjmkCLwbG4JJ42tgKNNq+RyNxwPcJY= X-Received: by 2002:a9d:7096:: with SMTP id l22mr1480957otj.79.1623245227431; Wed, 09 Jun 2021 06:27:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxknDhyZXQ2dREilj+RsfQ2CcUmDo/spMg54cPqAUNtnKCISJ8SIDWlXQ2kuypYzZqZH5QCnA== X-Received: by 2002:a9d:7096:: with SMTP id l22mr1480942otj.79.1623245227268; Wed, 09 Jun 2021 06:27:07 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id z14sm3760901oti.29.2021.06.09.06.27.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 06:27:07 -0700 (PDT) Subject: Re: [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files To: Greg KH Cc: mdf@kernel.org, michal.simek@xilinx.com, nava.manne@xilinx.com, luca@lucaceresoli.net, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210608162551.3010533-1-trix@redhat.com> From: Tom Rix Message-ID: Date: Wed, 9 Jun 2021 06:27:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_062711_233400_678B73B8 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/9/21 2:59 AM, Greg KH wrote: > On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote: >> From: Tom Rix >> >> It is not necessary to have a xilinx- prefix on a file >> when the file is in a xilinx/ subdir. >> >> Signed-off-by: Tom Rix >> --- >> drivers/fpga/xilinx/Makefile | 4 ++-- >> drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 >> drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 >> 3 files changed, 2 insertions(+), 2 deletions(-) >> rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) >> rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%) >> >> diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile >> index 7bb7543412790..4ac727d03e140 100644 >> --- a/drivers/fpga/xilinx/Makefile >> +++ b/drivers/fpga/xilinx/Makefile >> @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0 >> >> -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o >> -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o >> +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o >> +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o > You just renamed the module to be called "spi.ko"???? > > Did you test this thing? You can not rename modules without good > reasons, and calling a device specific kernel module "spi.ko" is not ok. yes, this is a problem, I will drop the renaming patches. Tom > greg k-h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel