From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757969AbdJMLV4 (ORCPT ); Fri, 13 Oct 2017 07:21:56 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8037 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbdJMLVy (ORCPT ); Fri, 13 Oct 2017 07:21:54 -0400 Subject: Re: [f2fs-dev] [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim To: Chao Yu , , , CC: , , , References: <1507729864-118702-1-git-send-email-yunlong.song@huawei.com> <7a3f0052-86e0-4e46-c89b-048d6137b820@kernel.org> From: Yunlong Song Message-ID: Date: Fri, 13 Oct 2017 19:20:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <7a3f0052-86e0-4e46-c89b-048d6137b820@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.111.220.140] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0204.59E0A1C6.001F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6ee8e7625de6484f301276e754a663ca Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yep, both are OK, since I do not care it is foreground or background. Here it just needs to do gc. On 2017/10/13 19:09, Chao Yu wrote: > On 2017/10/11 21:51, Yunlong Song wrote: >> This can help us to debug on some corner case. >> >> Signed-off-by: Yunlong Song >> --- >> fs/f2fs/gc.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >> index 197ebf4..960503e 100644 >> --- a/fs/f2fs/gc.c >> +++ b/fs/f2fs/gc.c >> @@ -986,6 +986,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, >> .ilist = LIST_HEAD_INIT(gc_list.ilist), >> .iroot = RADIX_TREE_INIT(GFP_NOFS), >> }; >> + bool need_gc = false; > How about changing variable name to need_fggc for better readability? > > Thanks, > >> >> trace_f2fs_gc_begin(sbi->sb, sync, background, >> get_pages(sbi, F2FS_DIRTY_NODES), >> @@ -1018,8 +1019,10 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, >> if (ret) >> goto stop; >> } >> - if (has_not_enough_free_secs(sbi, 0, 0)) >> + if (has_not_enough_free_secs(sbi, 0, 0)) { >> gc_type = FG_GC; >> + need_gc = true; >> + } >> } >> >> /* f2fs_balance_fs doesn't need to do BG_GC in critical path. */ >> @@ -1028,6 +1031,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, >> goto stop; >> } >> if (!__get_victim(sbi, &segno, gc_type)) { >> + f2fs_bug_on(sbi, !total_freed && need_gc); >> ret = -ENODATA; >> goto stop; >> } >> > . > -- Thanks, Yunlong Song From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yunlong Song Subject: Re: [f2fs-dev] [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim Date: Fri, 13 Oct 2017 19:20:22 +0800 Message-ID: References: <1507729864-118702-1-git-send-email-yunlong.song@huawei.com> <7a3f0052-86e0-4e46-c89b-048d6137b820@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7a3f0052-86e0-4e46-c89b-048d6137b820@kernel.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Chao Yu , jaegeuk@kernel.org, yuchao0@huawei.com, yunlong.song@icloud.com Cc: linux-fsdevel@vger.kernel.org, miaoxie@huawei.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net List-Id: linux-f2fs-devel.lists.sourceforge.net Yep, both are OK, since I do not care it is foreground or background. Here it just needs to do gc. On 2017/10/13 19:09, Chao Yu wrote: > On 2017/10/11 21:51, Yunlong Song wrote: >> This can help us to debug on some corner case. >> >> Signed-off-by: Yunlong Song >> --- >> fs/f2fs/gc.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >> index 197ebf4..960503e 100644 >> --- a/fs/f2fs/gc.c >> +++ b/fs/f2fs/gc.c >> @@ -986,6 +986,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, >> .ilist = LIST_HEAD_INIT(gc_list.ilist), >> .iroot = RADIX_TREE_INIT(GFP_NOFS), >> }; >> + bool need_gc = false; > How about changing variable name to need_fggc for better readability? > > Thanks, > >> >> trace_f2fs_gc_begin(sbi->sb, sync, background, >> get_pages(sbi, F2FS_DIRTY_NODES), >> @@ -1018,8 +1019,10 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, >> if (ret) >> goto stop; >> } >> - if (has_not_enough_free_secs(sbi, 0, 0)) >> + if (has_not_enough_free_secs(sbi, 0, 0)) { >> gc_type = FG_GC; >> + need_gc = true; >> + } >> } >> >> /* f2fs_balance_fs doesn't need to do BG_GC in critical path. */ >> @@ -1028,6 +1031,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, >> goto stop; >> } >> if (!__get_victim(sbi, &segno, gc_type)) { >> + f2fs_bug_on(sbi, !total_freed && need_gc); >> ret = -ENODATA; >> goto stop; >> } >> > . > -- Thanks, Yunlong Song