From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A57C6FA8B for ; Mon, 19 Sep 2022 13:43:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230230AbiISNnU (ORCPT ); Mon, 19 Sep 2022 09:43:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbiISNnS (ORCPT ); Mon, 19 Sep 2022 09:43:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C5262229E for ; Mon, 19 Sep 2022 06:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663594995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XAQ4C8p526IwfywWHvDt2bP3t+cfJKiAuugWFxjBeBk=; b=gLWz5xnjmG3/gwDiTNyn0M2ngQWlwMIkqiti22GwmL0S0qDl9gxLZzUJVUI7jKIBNMiTcq hGnOzkVgWkN2wtpzAOPvLbw5opTJItw5hntTggBzZhGjfE1zSSX+UrKglISia0RFqvwO2D Kl231P5j4kSPLfSyN4wnLLdiVftWtQQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-175-m7uMEVL3PEO3rwyjHKygLg-1; Mon, 19 Sep 2022 09:43:10 -0400 X-MC-Unique: m7uMEVL3PEO3rwyjHKygLg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB7301C0BC6D; Mon, 19 Sep 2022 13:43:08 +0000 (UTC) Received: from starship (unknown [10.40.192.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 681AD1121314; Mon, 19 Sep 2022 13:43:02 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 0/5] x86: cpuid: improve support for broken CPUID configurations From: Maxim Levitsky To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Pawan Gupta , Ingo Molnar , Josh Poimboeuf , Namhyung Kim , Tony Luck , Paolo Bonzini , "H. Peter Anvin" , Arnaldo Carvalho de Melo , Thomas Gleixner , Alexander Shishkin , Tim Chen , Borislav Petkov , "David S. Miller" , Dave Hansen , "Chang S. Bae" , Jane Malalane , Kees Cook , Kan Liang , Peter Zijlstra , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Herbert Xu , Jiri Olsa , Mark Rutland , linux-perf-users@vger.kernel.org, "open list:CRYPTO API" Date: Mon, 19 Sep 2022 16:43:00 +0300 In-Reply-To: <4a327f06f6e5da6f3badb5ccf80d22a5c9e18b97.camel@redhat.com> References: <20220718141123.136106-1-mlevitsk@redhat.com> <4a327f06f6e5da6f3badb5ccf80d22a5c9e18b97.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, 2022-08-01 at 19:05 +0300, Maxim Levitsky wrote: > On Thu, 2022-07-28 at 10:30 +0300, Maxim Levitsky wrote: > > On Mon, 2022-07-18 at 17:11 +0300, Maxim Levitsky wrote: > > > This patch series aims to harden the cpuid code against the case when > > > the hypervisor exposes a broken CPUID configuration to the guest, > > > in the form of having a feature disabled but not features that depend on it. > > > > > > This is the more generic way to fix kernel panic in aes-ni kernel driver, > > > which was triggered by CPUID configuration in which AVX is disabled but > > > not AVX2. > > > > > > https://lore.kernel.org/all/20211103145231.GA4485@gondor.apana.org.au/T/ > > > > > > This was tested by booting a guest with AVX disabled and not AVX2, > > > and observing that both a warning is now printed in dmesg, and > > > that avx2 is gone from /proc/cpuinfo. > > > > > > V2: > > > > > > I hopefully addressed all the (very good) review feedback. > > > > > > Best regards, > > > Maxim Levitsky > > > > > > Maxim Levitsky (5): > > > perf/x86/intel/lbr: use setup_clear_cpu_cap instead of clear_cpu_cap > > > x86/cpuid: refactor setup_clear_cpu_cap()/clear_cpu_cap() > > > x86/cpuid: move filter_cpuid_features to cpuid-deps.c > > > x86/cpuid: remove 'warn' parameter from filter_cpuid_features > > > x86/cpuid: check for dependencies violations in CPUID and attempt to > > > fix them > > > > > > arch/x86/events/intel/lbr.c | 2 +- > > > arch/x86/include/asm/cpufeature.h | 1 + > > > arch/x86/kernel/cpu/common.c | 51 +------------------- > > > arch/x86/kernel/cpu/cpuid-deps.c | 80 +++++++++++++++++++++++++++---- > > > 4 files changed, 74 insertions(+), 60 deletions(-) > > > > > > -- > > > 2.34.3 > > > > > > > > A very kind ping on these patches. > > Another kind ping on these patches. Another very gentle ping on these patches. Best regards, Maxim Levitsky > > > Best regards, > Maxim Levitsky > > Best regards, > > Maxim Levitsky