From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 674FDC433F5 for ; Tue, 24 May 2022 07:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234732AbiEXHPr (ORCPT ); Tue, 24 May 2022 03:15:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232183AbiEXHPq (ORCPT ); Tue, 24 May 2022 03:15:46 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B77C85AA66; Tue, 24 May 2022 00:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653376545; x=1684912545; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=o1deSnlVZaJUiL95RTHbdcraQdrqHnneaLqHhAeeC18=; b=RSKwbAX+jJK8NtYmeDZLTizW5pjwSuS2R0tcft+GJVKtwZnFkxAHaQRN OPp+qpywgApLFGJCbqxqyAUtLsvruifOH9sq/YS95sgFbLKvLmjSPbYyv DngZ4nJQE+2amo0NJBs3omrSYc4JI+L8YAabrv7GJlDCa/MRLIeZxqrPf w=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-02.qualcomm.com with ESMTP; 24 May 2022 00:15:45 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 00:15:45 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 00:15:44 -0700 Received: from [10.239.133.9] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 00:15:39 -0700 Message-ID: Date: Tue, 24 May 2022 15:15:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v7 04/10] coresight-tpdm: Add DSB dataset support Content-Language: en-US To: Suzuki K Poulose , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach CC: Leo Yan , Greg Kroah-Hartman , , , , Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , , Bjorn Andersson References: <20220509133947.20987-1-quic_jinlmao@quicinc.com> <20220509133947.20987-5-quic_jinlmao@quicinc.com> <00c30f02-de4e-6bd1-f220-00ae114ef91f@arm.com> From: Jinlong Mao In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Suzuki, On 5/23/2022 5:24 PM, Suzuki K Poulose wrote: > On 23/05/2022 10:11, Suzuki K Poulose wrote: >> Hi >> >> On 09/05/2022 14:39, Mao Jinlong wrote: >>> TPDM serves as data collection component for various dataset types. >>> DSB(Discrete Single Bit) is one of the dataset types. DSB subunit >>> can be enabled for data collection by writing 1 to the first bit of >>> DSB_CR register. This change is to add enable/disable function for >>> DSB dataset by writing DSB_CR register. >> >> The patch looks good to me, except for some minor comment below. >> >>> >>> Signed-off-by: Tao Zhang >>> Signed-off-by: Mao Jinlong >>> --- >>>   drivers/hwtracing/coresight/coresight-tpdm.c | 58 >>> ++++++++++++++++++++ >>>   drivers/hwtracing/coresight/coresight-tpdm.h | 23 ++++++++ >>>   2 files changed, 81 insertions(+) >>> >>> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c >>> b/drivers/hwtracing/coresight/coresight-tpdm.c >>> index 6a4e2a35053d..70df888ac565 100644 >>> --- a/drivers/hwtracing/coresight/coresight-tpdm.c >>> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c >>> @@ -20,7 +20,28 @@ >>>   DEFINE_CORESIGHT_DEVLIST(tpdm_devs, "tpdm"); >>> +static void tpdm_enable_dsb(struct tpdm_drvdata *drvdata) >>> +{ >>> +    u32 val; >>> + >>> +    /* Set the enable bit of DSB control register to 1 */ >>> +    val = readl_relaxed(drvdata->base + TPDM_DSB_CR); >>> +    val |= TPDM_DSB_CR_ENA; >>> +    writel_relaxed(val, drvdata->base + TPDM_DSB_CR); >>> +} >>> + > > > >>>   /* TPDM enable operations */ >>> +static void _tpdm_enable(struct tpdm_drvdata *drvdata) > > >>>   /* TPDM disable operations */ >>> +static void _tpdm_disable(struct tpdm_drvdata *drvdata) > > Missed this. The general convention is to use: > > __tpdm_disable() > __tpdm_enable(); I will address your comments. > > So, please switch to the names above. > > Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A355EC433F5 for ; Tue, 24 May 2022 07:17:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I676DQq7ncyssC1oqTjBnCO8W5ribioEuRwO0ikm/yQ=; b=vmvOjId2FrxKLd W+XkqGs3bjPANu9foXieRsU/oQonygrB5SBsszK4FBn2U1rsWoab9XBTVDOScasI9aLtq0AXLlGUo dsoPAwNn39B85opFi+EEor0K0rafBWIsGYn6f+4h8O4SF1WRTFAYYViOo1UgF6IWKRrtYtE3PchsL TrOUt51Gf552bMhcpNaqSe3tcexLv9GQu/7DqeZc+j9Y8shkK9JdJR0PGcR3c2ACJeBTYCwBmCzHY wRSBKrpSWc77+XMGMo+ksJRaodllNUqbaNEf+1IDb5qMuGjBUWTeDkBvOEUsVeQSrL0r0Bc467J+R NdMha+EzWET4HAlOmPOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntOli-0072bS-5k; Tue, 24 May 2022 07:15:50 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntOld-0072a1-OK for linux-arm-kernel@lists.infradead.org; Tue, 24 May 2022 07:15:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1653376545; x=1684912545; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=o1deSnlVZaJUiL95RTHbdcraQdrqHnneaLqHhAeeC18=; b=RSKwbAX+jJK8NtYmeDZLTizW5pjwSuS2R0tcft+GJVKtwZnFkxAHaQRN OPp+qpywgApLFGJCbqxqyAUtLsvruifOH9sq/YS95sgFbLKvLmjSPbYyv DngZ4nJQE+2amo0NJBs3omrSYc4JI+L8YAabrv7GJlDCa/MRLIeZxqrPf w=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 24 May 2022 00:15:45 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 00:15:45 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 00:15:44 -0700 Received: from [10.239.133.9] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 24 May 2022 00:15:39 -0700 Message-ID: Date: Tue, 24 May 2022 15:15:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v7 04/10] coresight-tpdm: Add DSB dataset support Content-Language: en-US To: Suzuki K Poulose , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach CC: Leo Yan , Greg Kroah-Hartman , , , , Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , , Bjorn Andersson References: <20220509133947.20987-1-quic_jinlmao@quicinc.com> <20220509133947.20987-5-quic_jinlmao@quicinc.com> <00c30f02-de4e-6bd1-f220-00ae114ef91f@arm.com> From: Jinlong Mao In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_001545_884787_89F9E325 X-CRM114-Status: GOOD ( 11.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU3V6dWtpLAoKT24gNS8yMy8yMDIyIDU6MjQgUE0sIFN1enVraSBLIFBvdWxvc2Ugd3JvdGU6 Cj4gT24gMjMvMDUvMjAyMiAxMDoxMSwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPj4gSGkKPj4K Pj4gT24gMDkvMDUvMjAyMiAxNDozOSwgTWFvIEppbmxvbmcgd3JvdGU6Cj4+PiBUUERNIHNlcnZl cyBhcyBkYXRhIGNvbGxlY3Rpb24gY29tcG9uZW50IGZvciB2YXJpb3VzIGRhdGFzZXQgdHlwZXMu Cj4+PiBEU0IoRGlzY3JldGUgU2luZ2xlIEJpdCkgaXMgb25lIG9mIHRoZSBkYXRhc2V0IHR5cGVz LiBEU0Igc3VidW5pdAo+Pj4gY2FuIGJlIGVuYWJsZWQgZm9yIGRhdGEgY29sbGVjdGlvbiBieSB3 cml0aW5nIDEgdG8gdGhlIGZpcnN0IGJpdCBvZgo+Pj4gRFNCX0NSIHJlZ2lzdGVyLiBUaGlzIGNo YW5nZSBpcyB0byBhZGQgZW5hYmxlL2Rpc2FibGUgZnVuY3Rpb24gZm9yCj4+PiBEU0IgZGF0YXNl dCBieSB3cml0aW5nIERTQl9DUiByZWdpc3Rlci4KPj4KPj4gVGhlIHBhdGNoIGxvb2tzIGdvb2Qg dG8gbWUsIGV4Y2VwdCBmb3Igc29tZSBtaW5vciBjb21tZW50IGJlbG93Lgo+Pgo+Pj4KPj4+IFNp Z25lZC1vZmYtYnk6IFRhbyBaaGFuZyA8cXVpY190YW96aGFAcXVpY2luYy5jb20+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBNYW8gSmlubG9uZyA8cXVpY19qaW5sbWFvQHF1aWNpbmMuY29tPgo+Pj4gLS0t Cj4+PiDCoCBkcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRwZG0uYyB8IDU4 IAo+Pj4gKysrKysrKysrKysrKysrKysrKysKPj4+IMKgIGRyaXZlcnMvaHd0cmFjaW5nL2NvcmVz aWdodC9jb3Jlc2lnaHQtdHBkbS5oIHwgMjMgKysrKysrKysKPj4+IMKgIDIgZmlsZXMgY2hhbmdl ZCwgODEgaW5zZXJ0aW9ucygrKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2h3dHJhY2lu Zy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRwZG0uYyAKPj4+IGIvZHJpdmVycy9od3RyYWNpbmcvY29y ZXNpZ2h0L2NvcmVzaWdodC10cGRtLmMKPj4+IGluZGV4IDZhNGUyYTM1MDUzZC4uNzBkZjg4OGFj NTY1IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdo dC10cGRtLmMKPj4+ICsrKyBiL2RyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQt dHBkbS5jCj4+PiBAQCAtMjAsNyArMjAsMjggQEAKPj4+IMKgIERFRklORV9DT1JFU0lHSFRfREVW TElTVCh0cGRtX2RldnMsICJ0cGRtIik7Cj4+PiArc3RhdGljIHZvaWQgdHBkbV9lbmFibGVfZHNi KHN0cnVjdCB0cGRtX2RydmRhdGEgKmRydmRhdGEpCj4+PiArewo+Pj4gK8KgwqDCoCB1MzIgdmFs Owo+Pj4gKwo+Pj4gK8KgwqDCoCAvKiBTZXQgdGhlIGVuYWJsZSBiaXQgb2YgRFNCIGNvbnRyb2wg cmVnaXN0ZXIgdG8gMSAqLwo+Pj4gK8KgwqDCoCB2YWwgPSByZWFkbF9yZWxheGVkKGRydmRhdGEt PmJhc2UgKyBUUERNX0RTQl9DUik7Cj4+PiArwqDCoMKgIHZhbCB8PSBUUERNX0RTQl9DUl9FTkE7 Cj4+PiArwqDCoMKgIHdyaXRlbF9yZWxheGVkKHZhbCwgZHJ2ZGF0YS0+YmFzZSArIFRQRE1fRFNC X0NSKTsKPj4+ICt9Cj4+PiArCj4KPgo+Cj4+PiDCoCAvKiBUUERNIGVuYWJsZSBvcGVyYXRpb25z ICovCj4+PiArc3RhdGljIHZvaWQgX3RwZG1fZW5hYmxlKHN0cnVjdCB0cGRtX2RydmRhdGEgKmRy dmRhdGEpCj4KPgo+Pj4gwqAgLyogVFBETSBkaXNhYmxlIG9wZXJhdGlvbnMgKi8KPj4+ICtzdGF0 aWMgdm9pZCBfdHBkbV9kaXNhYmxlKHN0cnVjdCB0cGRtX2RydmRhdGEgKmRydmRhdGEpCj4KPiBN aXNzZWQgdGhpcy4gVGhlIGdlbmVyYWwgY29udmVudGlvbiBpcyB0byB1c2U6Cj4KPiBfX3RwZG1f ZGlzYWJsZSgpCj4gX190cGRtX2VuYWJsZSgpOwpJIHdpbGwgYWRkcmVzcyB5b3VyIGNvbW1lbnRz Lgo+Cj4gU28sIHBsZWFzZSBzd2l0Y2ggdG8gdGhlIG5hbWVzIGFib3ZlLgo+Cj4gU3V6dWtpCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==