From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349C2C433ED for ; Thu, 29 Apr 2021 12:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 034F0613F4 for ; Thu, 29 Apr 2021 12:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233011AbhD2MjG (ORCPT ); Thu, 29 Apr 2021 08:39:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232657AbhD2MjG (ORCPT ); Thu, 29 Apr 2021 08:39:06 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B54B5C06138B; Thu, 29 Apr 2021 05:38:19 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id b21so3762335ljf.11; Thu, 29 Apr 2021 05:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C9ADd+O1J2g7WPah5TPp1y5aPWH188p57AR71wN8M7Y=; b=jNb3LRNDZRY9dtWQ93oZg3Us255+OUEcb5r+MjK5sgkqGm7K9ak2patahQ6FZcQ4SG 28gHOMaQhLQK4D5cZpgiMVK1xT5XaPCU5pkFtSOVIMAZQ9BBiOgPnc/cXivzWcDrNz2i H9506pQwYfGU9WiNOhZ3cIL0FTWvHooUSMBpK5u6BPyF2ggTLCQG09bdSv95I1JnkX3g nh3pI0amvi5YoTJBsug51S7QoV+mrkdy5sDhpRttOD/vmKonfuRbaUBS+GKkabP6a7Az uTEygRG6Qdg7dwzw0ebu4kUpHrNm2Jc9NyFuOLXfFVRJyurvbkzpJUP+ZLKUZztvchJ2 eX7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C9ADd+O1J2g7WPah5TPp1y5aPWH188p57AR71wN8M7Y=; b=Mm9rHTI72nTTyaQzdJGEmKuoNrI/jp4EG2F7DanwU9C+0/F+sQBAk/Xf1clfXU02X/ +l8H4sKrAZvMPMofSR+4/fGpeNBMuemSaYoxa8J9+aP20lz+F+mpk8Jwe8t+XtxyNmtF xOR8CW3Sp8WLF+oPxl1m8nmM5Vu6xISI/Dwhov619MZF36BqEQaCS1uOn2A72blmFrW+ A03w+1PDvX06uY5iDGJjTY5KVWIquZpgGCXxq7rJ88M3Gv4Y0piGe7XfY8bdQABppbmB ntswtyKkpFgypWAoB8B8m2nwGVytgl6orrj0lFoIXwVgnM9V56M1VyvsXHvHE03MzG9I y5iw== X-Gm-Message-State: AOAM531Xb1KTWqW1fdbWLTTHfNpBSwFHLXeEnGjj9hvKIZ4q6kvANgFV gXOkDwtyTPW+lZdlstvJmJcHF5p3tcI= X-Google-Smtp-Source: ABdhPJzTvng8yQNg4q9VfyFfl15qNbeKD7GZ3dV96aB9VC37IqAWamJguU8SXFBqPTn3oiUW9HRVMA== X-Received: by 2002:a2e:140b:: with SMTP id u11mr24386345ljd.125.1619699898040; Thu, 29 Apr 2021 05:38:18 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-102.dynamic.spd-mgts.ru. [109.252.193.102]) by smtp.googlemail.com with ESMTPSA id v130sm515026lfa.262.2021.04.29.05.38.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 05:38:17 -0700 (PDT) Subject: Re: [PATCH v4 25/79] staging: media: tegra-vde: use pm_runtime_resume_and_get() To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , Jonathan Hunter , Mauro Carvalho Chehab , Thierry Reding , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org References: From: Dmitry Osipenko Message-ID: Date: Thu, 29 Apr 2021 15:38:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 28.04.2021 17:51, Mauro Carvalho Chehab пишет: > @@ -1069,11 +1071,17 @@ static int tegra_vde_probe(struct platform_device *pdev) > * power-cycle it in order to put hardware into a predictable lower > * power state. > */ > - pm_runtime_get_sync(dev); > + if (pm_runtime_resume_and_get(dev) < 0) > + goto err_pm_runtime; > + > pm_runtime_put(dev); > > return 0; > > +err_pm_runtime: > + pm_runtime_dont_use_autosuspend(dev); > + pm_runtime_disable(dev); > + > err_deinit_iommu: > tegra_vde_iommu_deinit(vde); This is incorrect error unwinding, the miscdev isn't unregistered. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5804C433ED for ; Thu, 29 Apr 2021 12:38:23 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76381613F2 for ; Thu, 29 Apr 2021 12:38:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76381613F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0D3994014B; Thu, 29 Apr 2021 12:38:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lf8CXNdTTCtk; Thu, 29 Apr 2021 12:38:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 22A09402C5; Thu, 29 Apr 2021 12:38:22 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id F09E11BF312 for ; Thu, 29 Apr 2021 12:38:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DFACE606B0 for ; Thu, 29 Apr 2021 12:38:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OyCURvhBqDi0 for ; Thu, 29 Apr 2021 12:38:20 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2A8D06069F for ; Thu, 29 Apr 2021 12:38:20 +0000 (UTC) Received: by mail-lj1-x231.google.com with SMTP id s9so18318137ljj.6 for ; Thu, 29 Apr 2021 05:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C9ADd+O1J2g7WPah5TPp1y5aPWH188p57AR71wN8M7Y=; b=jNb3LRNDZRY9dtWQ93oZg3Us255+OUEcb5r+MjK5sgkqGm7K9ak2patahQ6FZcQ4SG 28gHOMaQhLQK4D5cZpgiMVK1xT5XaPCU5pkFtSOVIMAZQ9BBiOgPnc/cXivzWcDrNz2i H9506pQwYfGU9WiNOhZ3cIL0FTWvHooUSMBpK5u6BPyF2ggTLCQG09bdSv95I1JnkX3g nh3pI0amvi5YoTJBsug51S7QoV+mrkdy5sDhpRttOD/vmKonfuRbaUBS+GKkabP6a7Az uTEygRG6Qdg7dwzw0ebu4kUpHrNm2Jc9NyFuOLXfFVRJyurvbkzpJUP+ZLKUZztvchJ2 eX7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C9ADd+O1J2g7WPah5TPp1y5aPWH188p57AR71wN8M7Y=; b=gRnLyGumztQ0wK1RZVpneOz4QoWYZe68E+eAVL7h6Cgbm98WrFiOrXO3dP50/gUKcb vueFHMU+LXezqFNvYS8Raq1pN2oxyQzNqrccuSmh6Y7mUQnEM415Llrqye4+JIMBvGSZ /p+QhW6+FRtNx4LMoShCK+9SXYvjld/oeIY0GN3qRM/xUoyXx22RkAeXjP9SBPYcQsSc IV/fNzvReTm2xYa1pRlAnscM1aB/27Qy6jGWSnR+iCTdxbiZcBVh8pr224CL954kOzrr bCa2e1K55+f+dbbU5lDfrxSlVUUNyveiXhIRsVFNcpbD8XQYUHrfDGb7aitX7tCUtaXG 5O+A== X-Gm-Message-State: AOAM5333nsGId2uII5DtxSGg+My/9lPQ0LOa8BZlXiwrwvez9WHuCJ6x xGEg580OS6vrsML207BKhDg= X-Google-Smtp-Source: ABdhPJzTvng8yQNg4q9VfyFfl15qNbeKD7GZ3dV96aB9VC37IqAWamJguU8SXFBqPTn3oiUW9HRVMA== X-Received: by 2002:a2e:140b:: with SMTP id u11mr24386345ljd.125.1619699898040; Thu, 29 Apr 2021 05:38:18 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-102.dynamic.spd-mgts.ru. [109.252.193.102]) by smtp.googlemail.com with ESMTPSA id v130sm515026lfa.262.2021.04.29.05.38.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 05:38:17 -0700 (PDT) Subject: Re: [PATCH v4 25/79] staging: media: tegra-vde: use pm_runtime_resume_and_get() To: Mauro Carvalho Chehab References: From: Dmitry Osipenko Message-ID: Date: Thu, 29 Apr 2021 15:38:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linuxarm@huawei.com, Jonathan Hunter , linux-tegra@vger.kernel.org, Thierry Reding , mauro.chehab@huawei.com, Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" MjguMDQuMjAyMSAxNzo1MSwgTWF1cm8gQ2FydmFsaG8gQ2hlaGFiINC/0LjRiNC10YI6Cj4gQEAg LTEwNjksMTEgKzEwNzEsMTcgQEAgc3RhdGljIGludCB0ZWdyYV92ZGVfcHJvYmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiAgCSAqIHBvd2VyLWN5Y2xlIGl0IGluIG9yZGVyIHRvIHB1 dCBoYXJkd2FyZSBpbnRvIGEgcHJlZGljdGFibGUgbG93ZXIKPiAgCSAqIHBvd2VyIHN0YXRlLgo+ ICAJICovCj4gLQlwbV9ydW50aW1lX2dldF9zeW5jKGRldik7Cj4gKwlpZiAocG1fcnVudGltZV9y ZXN1bWVfYW5kX2dldChkZXYpIDwgMCkKPiArCQlnb3RvIGVycl9wbV9ydW50aW1lOwo+ICsKPiAg CXBtX3J1bnRpbWVfcHV0KGRldik7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIAo+ICtlcnJfcG1fcnVu dGltZToKPiArCXBtX3J1bnRpbWVfZG9udF91c2VfYXV0b3N1c3BlbmQoZGV2KTsKPiArCXBtX3J1 bnRpbWVfZGlzYWJsZShkZXYpOwo+ICsKPiAgZXJyX2RlaW5pdF9pb21tdToKPiAgCXRlZ3JhX3Zk ZV9pb21tdV9kZWluaXQodmRlKTsKClRoaXMgaXMgaW5jb3JyZWN0IGVycm9yIHVud2luZGluZywg dGhlIG1pc2NkZXYgaXNuJ3QgdW5yZWdpc3RlcmVkLgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2 ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK