From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24100C433E2 for ; Thu, 3 Sep 2020 12:59:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0FC42072A for ; Thu, 3 Sep 2020 12:59:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JYiJPowL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0FC42072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDopT-000568-Vq for qemu-devel@archiver.kernel.org; Thu, 03 Sep 2020 08:59:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDoo0-0003pJ-GN for qemu-devel@nongnu.org; Thu, 03 Sep 2020 08:57:32 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53983 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDony-0003Im-QW for qemu-devel@nongnu.org; Thu, 03 Sep 2020 08:57:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599137850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LAUH/9ryRR5/OksUHUVor7l4I+V37+FxPSiCylrh30U=; b=JYiJPowL0WANvPbinyGTsXlDKoTSsYdavWn/hhEPe3qUwbfiEoKiK248VeJxdUxJt//8cB d6XkKe+1WMLoFOYVxx3/lUXuDNcTNdYL0YrGDDmQehKNnXPt3B66yY1dbOsQxzzSy72RBP KO4ao2aogKYkPbMk+PzzEtkz2dJd8c8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-GTmjcbClNcOWPYtxmDTQZA-1; Thu, 03 Sep 2020 08:57:28 -0400 X-MC-Unique: GTmjcbClNcOWPYtxmDTQZA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E1BFB18BA284; Thu, 3 Sep 2020 12:57:26 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-112-164.ams2.redhat.com [10.36.112.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 35B835C22D; Thu, 3 Sep 2020 12:57:21 +0000 (UTC) Subject: Re: [RFC qemu 0/6] mirror: implement incremental and bitmap modes To: Kevin Wolf References: <20200218100740.2228521-1-f.gruenbichler@proxmox.com> <1599127031.9uxdp5h9o2.astroid@nora.none> <20200903123850.GB8835@linux.fritz.box> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Thu, 3 Sep 2020 14:57:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200903123850.GB8835@linux.fritz.box> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cnfr2KdXqybndI8pHCUh9XLlnrqDTlxOl" Received-SPF: pass client-ip=205.139.110.120; envelope-from=mreitz@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 01:58:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.403, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Cnfr2KdXqybndI8pHCUh9XLlnrqDTlxOl Content-Type: multipart/mixed; boundary="0nxcR6BgrpzpJu99dUOaSSV4GFsBymF0m" --0nxcR6BgrpzpJu99dUOaSSV4GFsBymF0m Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 03.09.20 14:38, Kevin Wolf wrote: > Am 03.09.2020 um 13:04 hat Max Reitz geschrieben: >> On 03.09.20 12:13, Fabian Gr=C3=BCnbichler wrote: >>> On August 21, 2020 3:03 pm, Max Reitz wrote: >>>> On 18.02.20 11:07, Fabian Gr=C3=BCnbichler wrote: >>> I am not sure how=20 >>> the S-O-B by John is supposed to enter the mix - should I just include= =20 >>> it in the squashed patch (which would be partly authored, but=20 >>> not-yet-signed-off by him otherwise?)? >> >> I=E2=80=99m not too sure on the proceedings, actually. I think it shoul= d be >> fine if you put his S-o-b there, as long as your patch is somehow based >> on a patch that he sent earlier with his S-o-b underneath. But I=E2=80= =99m not >> sure. >=20 > Signed-off-by means that John certifies the DCO for the patch (at least > the original version that you possibly modified), so you cannot just add > it without asking him. But what if you take a patch from someone and heavily modify it =E2=80=93 wouldn=E2=80=99t you keep the original S-o-b and explain the modifications = in the commit message? Max > John should reply with a Signed-off-by line to the patch in question. > Then you (Fabian) can add it in the next version of the series (if I > understand correctly, you're going to respin anyway). >=20 > I see that patch 2 doesn't have any S-o-b at all. It should have both > John's and Fabian's. >=20 > Kevin >=20 --0nxcR6BgrpzpJu99dUOaSSV4GFsBymF0m-- --Cnfr2KdXqybndI8pHCUh9XLlnrqDTlxOl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl9Q6C8ACgkQ9AfbAGHV z0AqzwgAh41GL4613nfjqbZMXj4moXWRKoIiNoMb1ybfzPkakA9ZXKWrJiAklwvk DNsJIznPFklDU5CBZ4N6cJkU8XioOUmpjUf+B6Y0T8b9rAzbjXcrVU3zswpL6/te aCoWz2x+1El6l1ENyoapNTZFMVNkNESOrOKAF9RpandU2kwOREhMlUy0cK3vCxMP 5Bq/3dSgUEsFPlHY54Vnua04wQelYanO27o3+UtRRauYJ2j7xC8hgICd+z1MhvQW v4eO4sPdwOkORaDVedonVMtbZQnctA3vU/W+OB8PqCkzvU1GV7odw6TVKliycoge 415zDD7TG1xsk8BsViH4tKvLogwmZw== =8b8E -----END PGP SIGNATURE----- --Cnfr2KdXqybndI8pHCUh9XLlnrqDTlxOl--