From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49552C433DB for ; Fri, 5 Mar 2021 01:24:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7CC864FEE for ; Fri, 5 Mar 2021 01:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7CC864FEE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHzCl-0005xx-Kg for qemu-devel@archiver.kernel.org; Thu, 04 Mar 2021 20:24:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHzBD-0004ve-Pd for qemu-devel@nongnu.org; Thu, 04 Mar 2021 20:22:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60897) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHzBB-0008Vw-Bl for qemu-devel@nongnu.org; Thu, 04 Mar 2021 20:22:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614907375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kn3Q0U5I4oIs3/msaAaKQKltZPtzxzUxg2cRiuf4eTI=; b=MuqTs3Gkyg+74HpKqAO4QXX5mfFlK5L/8EuhS/57SuOIpC24FW7aVSOzlMoh2zArtbsb/Q aK4V9pt5lYugfJrTA1bdBgE0VnmcdxhPgAlRqX6Cl5IBG+2nGk3sss1grlQ233YnKOKBNR f4AF7oO1MpFvnzxAvm5FuXofYWpeKQc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-JoRTHv0dOZmHjACSBi0VRA-1; Thu, 04 Mar 2021 20:22:54 -0500 X-MC-Unique: JoRTHv0dOZmHjACSBi0VRA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6FFD814336; Fri, 5 Mar 2021 01:22:52 +0000 (UTC) Received: from [10.10.118.103] (ovpn-118-103.rdu2.redhat.com [10.10.118.103]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADE11100164C; Fri, 5 Mar 2021 01:22:51 +0000 (UTC) Subject: Re: [PATCH v2 1/8] simplebench: bench_one(): add slow_limit argument To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20210304101738.20248-1-vsementsov@virtuozzo.com> <20210304101738.20248-2-vsementsov@virtuozzo.com> From: John Snow Message-ID: Date: Thu, 4 Mar 2021 20:22:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210304101738.20248-2-vsementsov@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: den@openvz.org, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/4/21 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: > Sometimes one of cells in a testing table runs too slow. And we really > don't want to wait so long. Limit number of runs in this case. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > scripts/simplebench/simplebench.py | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) > > diff --git a/scripts/simplebench/simplebench.py b/scripts/simplebench/simplebench.py > index f61513af90..b153cae274 100644 > --- a/scripts/simplebench/simplebench.py > +++ b/scripts/simplebench/simplebench.py > @@ -19,9 +19,11 @@ > # > > import statistics > +import time > > > -def bench_one(test_func, test_env, test_case, count=5, initial_run=True): > +def bench_one(test_func, test_env, test_case, count=5, initial_run=True, > + slow_limit=100): > """Benchmark one test-case > > test_func -- benchmarking function with prototype > @@ -36,6 +38,8 @@ def bench_one(test_func, test_env, test_case, count=5, initial_run=True): > test_case -- test case - opaque second argument for test_func > count -- how many times to call test_func, to calculate average > initial_run -- do initial run of test_func, which don't get into result > + slow_limit -- reduce test runs to 2, if current run exceedes the limit > + (in seconds) > s/exceedes/exceeds, and you need to mention that if the initial run exceeds the limit, it will change the behavior to count that result. It is also possible (conceivably) that the initial run exceeds the limit, but subsequent runs don't, so it might be hard to predict how many tests it'll actually run. If you're OK with that behavior, maybe: "Consider a test run 'slow' once it exceeds this limit, in seconds. Stop early once there are two 'slow' runs, including the initial run. Slow initial runs will be included in the results." Lastly, this will change existing behavior -- do we care? Should it default to None instead? Should we be able to pass None or 0 to disable this behavior? > Returns dict with the following fields: > 'runs': list of test_func results > @@ -47,17 +51,34 @@ def bench_one(test_func, test_env, test_case, count=5, initial_run=True): > 'n-failed': number of failed runs (exists only if at least one run > failed) > """ > + runs = [] > + i = 0 > if initial_run: > + t = time.time() > + > print(' #initial run:') > - print(' ', test_func(test_env, test_case)) > + res = test_func(test_env, test_case) > + print(' ', res) > + > + if time.time() - t > slow_limit: > + print(' - initial run is too slow, so it counts') > + runs.append(res) > + i = 1 > + > + for i in range(i, count): > + t = time.time() > > - runs = [] > - for i in range(count): > print(' #run {}'.format(i+1)) > res = test_func(test_env, test_case) > print(' ', res) > runs.append(res) > > + if time.time() - t > slow_limit and len(runs) >= 2: > + print(' - run is too slow, and we have enough runs, stop here') > + break > + > + count = len(runs) > + > result = {'runs': runs} > > succeeded = [r for r in runs if ('seconds' in r or 'iops' in r)] >