From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbdKICDT (ORCPT ); Wed, 8 Nov 2017 21:03:19 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:45310 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752328AbdKICDR (ORCPT ); Wed, 8 Nov 2017 21:03:17 -0500 Subject: Re: [PATCH net-next 1/2] net: hns3: fix a bug when getting phy address from NCL_config file To: Andrew Lunn References: <1510127543-34158-1-git-send-email-lipeng321@huawei.com> <1510127543-34158-2-git-send-email-lipeng321@huawei.com> <20171108143052.GH21784@lunn.ch> CC: , , , , , From: "lipeng (Y)" Message-ID: Date: Thu, 9 Nov 2017 10:02:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171108143052.GH21784@lunn.ch> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.173.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/11/8 22:30, Andrew Lunn wrote: > On Wed, Nov 08, 2017 at 03:52:22PM +0800, Lipeng wrote: >> From: Fuyun Liang >> >> Driver gets phy address from NCL_config file and uses the phy address >> to initialize phydev. There are 5 bits for phy address. And C22 phy >> address has 5 bits. So 0-31 are all valid address for phy. If there >> is no phy, it will crash. Because driver always get a valid phy address. > Hi Lipeng > > Any plans for C45? The PHY address is still 5 bits, but do you need to > get the device type from your configuration file? > > Andrew Hi Andrew C45 support is in Plan, now only support C22. This bugfix patch is valid for C22 and C45. As plan , will get the device type(NULL, C22, C45) from configuration file after support C45. Do you think we must do it now? or can add it along with C45 support? Lipeng > . >