From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38860C433FE for ; Tue, 31 May 2022 12:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344066AbiEaMBg (ORCPT ); Tue, 31 May 2022 08:01:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243208AbiEaMBe (ORCPT ); Tue, 31 May 2022 08:01:34 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB10499689 for ; Tue, 31 May 2022 05:01:32 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id q1so9660079ejz.9 for ; Tue, 31 May 2022 05:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=9m1AKxIKpBOrpgKNCQswOv5BEEg74xfUnH4p95pE0Iw=; b=SHfiVo2JGBy9urqWEOop6MF6w+4wlZeWdDY1LgpUjcIay15tWjPFosBYJQwwg6FjwW xQpNqYVSmiFUKjNQ+ewkjgVRf0YMH6+vCFp82TkN8BquafHSLrvXdRRvYJHm0bSB27R1 MB1egy6sIg3M0zDBk0bZAMJEZrHAs3QtI5sEILgzF2mAEzN3+7GRIshE2KCBwQ3FZDyM iLUwa7yDozDzkcI5+tKK775xzimUwB/wzVFpHjjrfmutvareSYgZC8Byyx1tLVbV0Gg/ b0SmzfkPT455ZBljp9vtbuQpaz71AUPHBVSqNCQYV3zvUMXlSWi2wNGyCQl59kiTB8m1 A6LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9m1AKxIKpBOrpgKNCQswOv5BEEg74xfUnH4p95pE0Iw=; b=6VRgUbOSvSNNhS2827WSxhSVfif5qAfkOxcQjx7FRk526BGZmTmYh4vaIhB22h7rvr MwGJiOMwptUJENxhfXiBrKRLA32MO0CKZoEdzdDzjbqTBphKUi8o7613s0TXTCXqb3x7 PgUNWzVV06jKCVSDjOvJgEH3BxJ/tULQjiXQH/ioMKU2QQYPMZxthJdxwHc1fe2VJHeR NVvh1yhtc3X9OonzxlJQXuT+szOL+493+qyVPUZjfRucRcctuPbRO3g0LMbZHqB7gcJV BA0Zj0LwSvglR+EIMLDqP71NVih6Ox2XQzNjQMtuRYhTQg40cK/CfbFan7uI3CY3kYYy WCzg== X-Gm-Message-State: AOAM531wkytuVOhIx3A5AxM4DhTNYhh54h+5oOC0FUGgjMafBdKhojio bgEVrb0IR/aPLWT5AaqSbZZ4Ag== X-Google-Smtp-Source: ABdhPJxHgVT1VxJPKc4NOyeIRvx19A/V04OMD+Gv/i2sdGRSIMB/6647wknXUWrWohNzzTuXeyBrBA== X-Received: by 2002:a17:906:6a24:b0:6fe:fa6b:4386 with SMTP id qw36-20020a1709066a2400b006fefa6b4386mr34917333ejc.351.1653998491476; Tue, 31 May 2022 05:01:31 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id g16-20020a50d0d0000000b0042dc9aafbfbsm4910687edf.39.2022.05.31.05.01.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 05:01:31 -0700 (PDT) Message-ID: Date: Tue, 31 May 2022 14:01:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Content-Language: en-US To: Puranjay Mohan , linux-kernel@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org, s-anna@ti.com, linux-arm-kernel@lists.infradead.org, rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com, robh+dt@kernel.org, afd@ti.com, andrew@lunn.ch References: <20220531095108.21757-1-p-mohan@ti.com> <20220531095108.21757-2-p-mohan@ti.com> <4ccba38a-ccde-83cd-195b-77db7a64477c@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/05/2022 13:59, Puranjay Mohan wrote: > Hi Krzysztof, > > On 31/05/22 17:18, Krzysztof Kozlowski wrote: >> On 31/05/2022 13:27, Puranjay Mohan wrote: >>>>> +examples: >>>>> + - | >>>>> + >>>>> + /* Example k3-am654 base board SR2.0, dual-emac */ >>>>> + pruss2_eth: pruss2_eth { >>>>> + compatible = "ti,am654-icssg-prueth"; >>>> >>>> Again missed Rob's comment. >>> >>> One of Rob's comment was to make the indentation as 4 which I have done. >> >> I clearly do not see indentation of 4, but there is 8 instead. > > I changed the indentation at the wrong place. > >> >> Let's count: >> + pruss2_eth: pruss2_eth { > ^ here, it was 8 in v1 so, I changed it to 4 > >> + compatible = "ti,am654-icssg-prueth"; >> 12345678^ >> > > Compatible is the child of pruss2_eth, so, It should have 4+4 = 8? Yes. Indentation of four means first block is indented with 4 spaces. The next block 4+4. The next one 4+4+4. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A395EC433F5 for ; Tue, 31 May 2022 12:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KLpOohVBrrC6LZR5kpDzgQ6DBRqoTaeDZtzdGquyhEs=; b=3vIVSVRQUU+V/4 CXUkeT+Rk9AKdVHJiVWH88Bhoh0GnoQ2E4MmEaHX/hYHcC1SggBm9iznHx6B7ABPDiZjcAA60DsXX AwyNd5qAM8JFnu3oYu1Mt17lzZn6y6tggsRQrFKr0CjXcoYq6zCJqwJFjcRRV5huah39l/s/vnIwe 5olmi7Y5ZrYXtXLLoG8L5X1s5RriDp4/VGw3JFqFQxZ/o4nWV8krPde/50SvuAPk6bGv/CNDdHNfU goRKPKmrYOdYtRJLX+1LKg7/7O2IBk1fHsHdl+AGKZdXJ1FcDAYaaOOMBL/L+TwuuWVeQpUraboAb d6nbKHgteZmyMfxifpoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw0Z7-00AdXL-Pc; Tue, 31 May 2022 12:01:37 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw0Z4-00AdVt-9z for linux-arm-kernel@lists.infradead.org; Tue, 31 May 2022 12:01:35 +0000 Received: by mail-ej1-x62d.google.com with SMTP id gh17so26167947ejc.6 for ; Tue, 31 May 2022 05:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=9m1AKxIKpBOrpgKNCQswOv5BEEg74xfUnH4p95pE0Iw=; b=SHfiVo2JGBy9urqWEOop6MF6w+4wlZeWdDY1LgpUjcIay15tWjPFosBYJQwwg6FjwW xQpNqYVSmiFUKjNQ+ewkjgVRf0YMH6+vCFp82TkN8BquafHSLrvXdRRvYJHm0bSB27R1 MB1egy6sIg3M0zDBk0bZAMJEZrHAs3QtI5sEILgzF2mAEzN3+7GRIshE2KCBwQ3FZDyM iLUwa7yDozDzkcI5+tKK775xzimUwB/wzVFpHjjrfmutvareSYgZC8Byyx1tLVbV0Gg/ b0SmzfkPT455ZBljp9vtbuQpaz71AUPHBVSqNCQYV3zvUMXlSWi2wNGyCQl59kiTB8m1 A6LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9m1AKxIKpBOrpgKNCQswOv5BEEg74xfUnH4p95pE0Iw=; b=wdQ/RE1mM75yCJE3jUZWxpDB1ZDqBJSLGpxuD38c0HVWpIh2drU/E2sI8wbYKIc1uv 7n2MaMOuZLSkUuMVEYCOk361FVapngqpc8TZeaHPHOx0829jmyE23YBqfKUodmi/LFBj DU11meut12WdmDh9ZC6M05IMmgUWRkzGZt2g4N2ZTyMTozNENnuaXJwTMVzy2LR3ONIs kFf1e4M3i1on6PiYrnUeaNsKuqvZciyei6YyD7GACYwP5d9kE4VtParzULRfM29dWk2X NLKu1n0eqA/NowZbhcbEeRkoCQeBhg5U0k2QlA2rzWFQ8F5TGEHJbRyfDh1q1siYTQRL 08jg== X-Gm-Message-State: AOAM530TsTXKxs3Oj1m+5w/zAseOW2BEtr2M2ansqHkH8zQQV6/gc1oD cznfQM6ehvCM4s/rsy/dzbYOKw== X-Google-Smtp-Source: ABdhPJxHgVT1VxJPKc4NOyeIRvx19A/V04OMD+Gv/i2sdGRSIMB/6647wknXUWrWohNzzTuXeyBrBA== X-Received: by 2002:a17:906:6a24:b0:6fe:fa6b:4386 with SMTP id qw36-20020a1709066a2400b006fefa6b4386mr34917333ejc.351.1653998491476; Tue, 31 May 2022 05:01:31 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id g16-20020a50d0d0000000b0042dc9aafbfbsm4910687edf.39.2022.05.31.05.01.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 05:01:31 -0700 (PDT) Message-ID: Date: Tue, 31 May 2022 14:01:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Content-Language: en-US To: Puranjay Mohan , linux-kernel@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org, s-anna@ti.com, linux-arm-kernel@lists.infradead.org, rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com, robh+dt@kernel.org, afd@ti.com, andrew@lunn.ch References: <20220531095108.21757-1-p-mohan@ti.com> <20220531095108.21757-2-p-mohan@ti.com> <4ccba38a-ccde-83cd-195b-77db7a64477c@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_050134_406032_95F68F02 X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/05/2022 13:59, Puranjay Mohan wrote: > Hi Krzysztof, > > On 31/05/22 17:18, Krzysztof Kozlowski wrote: >> On 31/05/2022 13:27, Puranjay Mohan wrote: >>>>> +examples: >>>>> + - | >>>>> + >>>>> + /* Example k3-am654 base board SR2.0, dual-emac */ >>>>> + pruss2_eth: pruss2_eth { >>>>> + compatible = "ti,am654-icssg-prueth"; >>>> >>>> Again missed Rob's comment. >>> >>> One of Rob's comment was to make the indentation as 4 which I have done. >> >> I clearly do not see indentation of 4, but there is 8 instead. > > I changed the indentation at the wrong place. > >> >> Let's count: >> + pruss2_eth: pruss2_eth { > ^ here, it was 8 in v1 so, I changed it to 4 > >> + compatible = "ti,am654-icssg-prueth"; >> 12345678^ >> > > Compatible is the child of pruss2_eth, so, It should have 4+4 = 8? Yes. Indentation of four means first block is indented with 4 spaces. The next block 4+4. The next one 4+4+4. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel