From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA787C4740C for ; Mon, 9 Sep 2019 18:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9778E2086D for ; Mon, 9 Sep 2019 18:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391435AbfIISDR (ORCPT ); Mon, 9 Sep 2019 14:03:17 -0400 Received: from foss.arm.com ([217.140.110.172]:54376 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391382AbfIISDR (ORCPT ); Mon, 9 Sep 2019 14:03:17 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 455B31000; Mon, 9 Sep 2019 11:03:16 -0700 (PDT) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 472953F71F; Mon, 9 Sep 2019 11:03:13 -0700 (PDT) Subject: Re: [PATCH v5 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd To: Dave Martin Cc: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org, amit.kachhap@arm.com, andreyknvl@google.com References: <20190902112932.36129-1-cristian.marussi@arm.com> <20190902112932.36129-10-cristian.marussi@arm.com> <20190904114923.GZ27757@arm.com> From: Cristian Marussi Message-ID: Date: Mon, 9 Sep 2019 19:03:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190904114923.GZ27757@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 04/09/2019 12:49, Dave Martin wrote: > On Mon, Sep 02, 2019 at 12:29:30pm +0100, Cristian Marussi wrote: >> Add a simple fake_sigreturn testcase which builds a ucontext_t with >> an anomalous additional fpsimd_context and place it onto the stack. >> Expects a SIGSEGV on test PASS. >> >> Signed-off-by: Cristian Marussi >> --- >> v3 --> v4 >> - fix commit >> - missing include >> - using new get_starting_head() helper >> - added test description >> --- >> .../fake_sigreturn_duplicated_fpsimd.c | 52 +++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> >> diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> new file mode 100644 >> index 000000000000..c7122c44f53f >> --- /dev/null >> +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> @@ -0,0 +1,52 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2019 ARM Limited >> + * >> + * Place a fake sigframe on the stack including an additional FPSIMD >> + * record: on sigreturn Kernel must spot this attempt and the test >> + * case is expected to be terminated via SEGV. >> + */ >> + >> +#include >> +#include >> + >> +#include "test_signals_utils.h" >> +#include "testcases.h" >> + >> +struct fake_sigframe sf; >> + >> +static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td, >> + siginfo_t *si, ucontext_t *uc) >> +{ >> + size_t resv_sz, need_sz; >> + struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head; >> + >> + /* just to fill the ucontext_t with something real */ >> + if (!get_current_context(td, &sf.uc)) >> + return 1; >> + >> + resv_sz = GET_SF_RESV_SIZE(sf); >> + need_sz = HDR_SZ + sizeof(struct fpsimd_context); > > Nit: Maybe write this sum in the same order as the records we're going > o append, i.e.: > > need_sz = sizeof(struct fpsimd_context) + HDR_SZ; /* for terminator */ > Ok > Also, maybe fail this test if there is no fpsimd_context in the initial > frame from get_current_context(): that would be a kernel bug, but we > wouldn't be giving fake_sigreturn() duplicate fpsimd_contexts in that > case -- so this test wouldn't test the thing it's supposed to test. > I've reviewed ASSERT_BAD/GOOD_CONTEXT() macros in this series to use abort() instead of assert(): this means any frame get with get_current_context() will be checked to be GOOD before the test starts. >> + >> + head = get_starting_head(shead, need_sz, resv_sz, NULL); >> + if (head) { >> + /* Add a spurios fpsimd_context */ >> + head->magic = FPSIMD_MAGIC; >> + head->size = sizeof(struct fpsimd_context); >> + /* and terminate */ >> + write_terminator_record(GET_RESV_NEXT_HEAD(head)); >> + >> + ASSERT_BAD_CONTEXT(&sf.uc); >> + fake_sigreturn(&sf, sizeof(sf), 0); >> + } >> + >> + return 1; > Here I'll avoid the timeout on !head and exit straight away (like in other fake_ tests) > [...] > > Cheers > ---Dave > Cheers Cristian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3B6C4740C for ; Mon, 9 Sep 2019 18:03:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D18D2089F for ; Mon, 9 Sep 2019 18:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jvQ9aDsL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D18D2089F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vbVghw3tgbOwxmI3kNTuNndFtKKdYM7k/+CmGqvsGck=; b=jvQ9aDsLNEE9BQ HymhLdC+fAPdsYxfkXL9hzqAX+inJ7RATjNrl4RMYzERwxwaj3fdWcAMDE6Gc+jK2eG1NX/n9zjsL +c8HGwSjVnRm+n4DTgyoMr/054v22sPCp3ipXVv+oO7PE9H6u80wqMlLtKJQ6AqLT9V3lstUbAjCX DG0llOz8qYZHuLEbRzlaklXcN+1TeTDaQiqDzCwQQWdeawx6F66ubgrJeBhx6vjYFiIFcJFsTRRnT 0+eJ+hAS8lg7MhyuA3qT7l+4bHqbLFuF9s7UkMTM/y2IhRc5HV23bRd7uLcsceu5mLhiz6yTcc6Oh n95lyUcGlyefowLWLBmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7O0V-0004hy-NW; Mon, 09 Sep 2019 18:03:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7O0S-0004hY-Ve for linux-arm-kernel@lists.infradead.org; Mon, 09 Sep 2019 18:03:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 455B31000; Mon, 9 Sep 2019 11:03:16 -0700 (PDT) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 472953F71F; Mon, 9 Sep 2019 11:03:13 -0700 (PDT) Subject: Re: [PATCH v5 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd To: Dave Martin References: <20190902112932.36129-1-cristian.marussi@arm.com> <20190902112932.36129-10-cristian.marussi@arm.com> <20190904114923.GZ27757@arm.com> From: Cristian Marussi Message-ID: Date: Mon, 9 Sep 2019 19:03:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190904114923.GZ27757@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190909_110317_109072_7FA955FF X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/09/2019 12:49, Dave Martin wrote: > On Mon, Sep 02, 2019 at 12:29:30pm +0100, Cristian Marussi wrote: >> Add a simple fake_sigreturn testcase which builds a ucontext_t with >> an anomalous additional fpsimd_context and place it onto the stack. >> Expects a SIGSEGV on test PASS. >> >> Signed-off-by: Cristian Marussi >> --- >> v3 --> v4 >> - fix commit >> - missing include >> - using new get_starting_head() helper >> - added test description >> --- >> .../fake_sigreturn_duplicated_fpsimd.c | 52 +++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> >> diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> new file mode 100644 >> index 000000000000..c7122c44f53f >> --- /dev/null >> +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c >> @@ -0,0 +1,52 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2019 ARM Limited >> + * >> + * Place a fake sigframe on the stack including an additional FPSIMD >> + * record: on sigreturn Kernel must spot this attempt and the test >> + * case is expected to be terminated via SEGV. >> + */ >> + >> +#include >> +#include >> + >> +#include "test_signals_utils.h" >> +#include "testcases.h" >> + >> +struct fake_sigframe sf; >> + >> +static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td, >> + siginfo_t *si, ucontext_t *uc) >> +{ >> + size_t resv_sz, need_sz; >> + struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head; >> + >> + /* just to fill the ucontext_t with something real */ >> + if (!get_current_context(td, &sf.uc)) >> + return 1; >> + >> + resv_sz = GET_SF_RESV_SIZE(sf); >> + need_sz = HDR_SZ + sizeof(struct fpsimd_context); > > Nit: Maybe write this sum in the same order as the records we're going > o append, i.e.: > > need_sz = sizeof(struct fpsimd_context) + HDR_SZ; /* for terminator */ > Ok > Also, maybe fail this test if there is no fpsimd_context in the initial > frame from get_current_context(): that would be a kernel bug, but we > wouldn't be giving fake_sigreturn() duplicate fpsimd_contexts in that > case -- so this test wouldn't test the thing it's supposed to test. > I've reviewed ASSERT_BAD/GOOD_CONTEXT() macros in this series to use abort() instead of assert(): this means any frame get with get_current_context() will be checked to be GOOD before the test starts. >> + >> + head = get_starting_head(shead, need_sz, resv_sz, NULL); >> + if (head) { >> + /* Add a spurios fpsimd_context */ >> + head->magic = FPSIMD_MAGIC; >> + head->size = sizeof(struct fpsimd_context); >> + /* and terminate */ >> + write_terminator_record(GET_RESV_NEXT_HEAD(head)); >> + >> + ASSERT_BAD_CONTEXT(&sf.uc); >> + fake_sigreturn(&sf, sizeof(sf), 0); >> + } >> + >> + return 1; > Here I'll avoid the timeout on !head and exit straight away (like in other fake_ tests) > [...] > > Cheers > ---Dave > Cheers Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel