From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>,
Amit Singh Tomar <amittomer25@gmail.com>
Cc: edgar.iglesias@xilinx.com,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
andre.przywara@arm.com, Ian Jackson <Ian.Jackson@eu.citrix.com>,
Tim Deegan <tim@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
baozich@gmail.com
Subject: Re: [PATCH] xen: char: Remove unnecessary (uart->irq > 0) check
Date: Mon, 30 Apr 2018 15:31:38 +0100 [thread overview]
Message-ID: <ecb6f9b6-4c1e-e9df-174b-13f165790258@arm.com> (raw)
In-Reply-To: <5AE6D17602000078001BF7D9@prv1-mh.provo.novell.com>
Hi,
On 30/04/18 09:19, Jan Beulich wrote:
>>>> On 28.04.18 at 11:08, <amittomer25@gmail.com> wrote:
>> While working on MVEBU uart driver, Julien pointed out that (uart->irq > 0)
>> check is unnecessary during irq set up.if ever there is an invalid irq, driver
>> initialization itself would be bailed out from platform_get_irq.
>>
>> This patch would remove similar check for other uart drivers present in XEN.
>
> At the example of the changes to ns16550.c you do, this is not correct. I
> can't judge about the various ARM specific drivers, but the 16550 can well
> be run in polling mode, and hence failure to set up an interrupt is not fatal
> to overall driver initialization.
This makes sense for any ARM only UART driver because they don't support
polling. However, I agree that if the driver is supporting polling (such
as NS16550) then you should keep the irq check around.
Cheers,
>
>> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
>> ---
>> * This patch is only compiled tested.
>
> In which case this should be marked RFC imo.
>
> Jan
>
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-04-30 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-28 9:08 [PATCH] xen: char: Remove unnecessary (uart->irq > 0) check Amit Singh Tomar
2018-04-30 8:19 ` Jan Beulich
2018-04-30 14:31 ` Julien Grall [this message]
2018-04-30 14:32 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb6f9b6-4c1e-e9df-174b-13f165790258@arm.com \
--to=julien.grall@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=amittomer25@gmail.com \
--cc=andre.przywara@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=baozich@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.