From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751385AbdILUeR (ORCPT ); Tue, 12 Sep 2017 16:34:17 -0400 Received: from mout.web.de ([212.227.17.12]:57251 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbdILUeP (ORCPT ); Tue, 12 Sep 2017 16:34:15 -0400 Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions To: Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Andrzej Hajda , Jeongtae Park , Kamil Debski , Kyungmin Park , Marek Szyprowski , Mauro Carvalho Chehab , kernel-janitors@vger.kernel.org, LKML References: <482a6c92-a85e-0bcd-edf7-3c2f63ea74c5@users.sourceforge.net> <6c2d20b3-4437-0473-73d4-73c049ba52a9@samsung.com> <0fa9a180-be67-3a33-682c-bff819c36c6a@samsung.com> <5b8eb902-d97c-3308-5ba9-64469320e0e2@users.sourceforge.net> From: SF Markus Elfring Message-ID: Date: Tue, 12 Sep 2017 22:33:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Provags-ID: V03:K0:PW9tQl9J4pAM3tNlWfbPSD372kHEeGuiRWQhbS5y1HxsjRk0g+U d/6jA5iHpuQsaOMxmIhpLNgr/zOetiPRa6skIRpzaYv7qWyoWSBPcEqRyVgLSFTE9qWZs7v 6/6ot1qALKPhnEjSpVQpTW3UgCGxb2je0SmuGfq6+byUg2RTKQrSBBFYMcJB/OZJMeYKjiw 4INllv0zAJpG0q8mGMQ5w== X-UI-Out-Filterresults: notjunk:1;V01:K0:7qKSwyC1o5U=:+iR2PzXb6odQ6YVHxNWpRj U+p/K27mI3K3OEJdPy8oGKDFDQ5l3tB2C3lxMp6HiqXTLPbiovXHVswsIuh0gW5rSskjl8TQf 7ykz3QnQmSbB0hXY1qKdhFa04Iz2vD6MCZRcVhivnzZplkTiZaO2dQ6pvrPMn2c2eZGD9M+lX Yxh3BqfXgZ0Mi5a6g2GxHwIpuVGObsdirq9+cO/ersqwrlvnxRc5ert0gYxhzFFmF3gx7V1CI jNHto93vyjDt942hpAky+5TKZVKFnlcPBz+/tLnP15ggrQryZAhplzC4IoXk6rSeEr8HxVRyg l5wY+Qw5/Zhj7kdJlNGb3XrI8HFUNpPukPmNp+CdqQkBLBZi3Up4/ovMNqQbP0gEdoS0jcqdb MccBMCrTTt8ISwJzScrhTuiCOzkzeVOQITw9lIQKvcD+QzHphCwMWHe6YYp5ryQXTxnR6zdSf OvoWMMbSC6TFRCkHQTOhQcWw+eSV7zmpoqOpHyo3KaELi+FqAXxedTrAkqNdjFBUjkv+LUPUD WtvtkZ1taV9hkYNJKZj/MbaNa8oRwoV+7Y2zDrExWUFsWOTtyVy/P811yua4jw4kBeAF3JYrg 8Wj6fLDkHHAhSsHT3YZmv6pcqlTQKqm8C7LxWlIIoO69OS0AlMFgXRF71My+n4T6bCQxMFxLx 6RRd1U+nCPJA9apFycZ7UCJa+33hrjY5c463aC89Zh+aP8yUHX2vMbHhKHPvVZ1ex4v5jqffD 12e17VVg1BnCAw4ThFpDqIizxdN2Tv7ZrEpA7hsnvPXU6YIltgzpdfjZzEWhj23/qQ5ZDUy91 XSrkorsGrjP2JyoHjxSAHxB1E1k8f+U0elgzetjL0rrOLcD/+c= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Generating patch is only part of the story, I can follow this view in principle. > it seems the patch is not sent properly I got an other impression. > and tags which should be in SMTP header end up in the message body. I agree that extra message fields were presented by the git software for a reason. You might have got other opinions about the original reason (than me). > I think there would not be such issues if you have used git > format-patch + git send-email. I have got also doubts about your corresponding expectations when you would find the proposed commit message itself acceptable (besides the small source code changes). > I normally do amend things like this while applying, That is interesting. > I will do that this time as well. Such an action can also be nice. > It's already too much time wasted for such a dubious patch. A bit of time is needed to resolve a temporary disagreement. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 12 Sep 2017 20:33:16 +0000 Subject: Re: [media] s5p-mfc: Adjust a null pointer check in four functions Message-Id: List-Id: References: <482a6c92-a85e-0bcd-edf7-3c2f63ea74c5@users.sourceforge.net> <6c2d20b3-4437-0473-73d4-73c049ba52a9@samsung.com> <0fa9a180-be67-3a33-682c-bff819c36c6a@samsung.com> <5b8eb902-d97c-3308-5ba9-64469320e0e2@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org > Generating patch is only part of the story, I can follow this view in principle. > it seems the patch is not sent properly I got an other impression. > and tags which should be in SMTP header end up in the message body. I agree that extra message fields were presented by the git software for a reason. You might have got other opinions about the original reason (than me). > I think there would not be such issues if you have used git > format-patch + git send-email. I have got also doubts about your corresponding expectations when you would find the proposed commit message itself acceptable (besides the small source code changes). > I normally do amend things like this while applying, That is interesting. > I will do that this time as well. Such an action can also be nice. > It's already too much time wasted for such a dubious patch. A bit of time is needed to resolve a temporary disagreement. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Tue, 12 Sep 2017 22:33:16 +0200 Subject: [media] s5p-mfc: Adjust a null pointer check in four functions In-Reply-To: References: <482a6c92-a85e-0bcd-edf7-3c2f63ea74c5@users.sourceforge.net> <6c2d20b3-4437-0473-73d4-73c049ba52a9@samsung.com> <0fa9a180-be67-3a33-682c-bff819c36c6a@samsung.com> <5b8eb902-d97c-3308-5ba9-64469320e0e2@users.sourceforge.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > Generating patch is only part of the story, I can follow this view in principle. > it seems the patch is not sent properly I got an other impression. > and tags which should be in SMTP header end up in the message body. I agree that extra message fields were presented by the git software for a reason. You might have got other opinions about the original reason (than me). > I think there would not be such issues if you have used git > format-patch + git send-email. I have got also doubts about your corresponding expectations when you would find the proposed commit message itself acceptable (besides the small source code changes). > I normally do amend things like this while applying, That is interesting. > I will do that this time as well. Such an action can also be nice. > It's already too much time wasted for such a dubious patch. A bit of time is needed to resolve a temporary disagreement. Regards, Markus