All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] sim: fix crash in case of invalid sim password type
Date: Mon, 07 Aug 2017 14:19:30 -0500	[thread overview]
Message-ID: <ecbf6c15-96a2-adf9-97c0-2c83b6e2a842@gmail.com> (raw)
In-Reply-To: <1498636003-24999-2-git-send-email-c.ronco@kerlink.fr>

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

Hi Christophe,

On 06/28/2017 02:46 AM, Christophe Ronco wrote:
> Crash seen in sim_pin_query_cb if pin type is OFONO_SIM_PASSWORD_INVALID
> ---
>  src/sim.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/sim.c b/src/sim.c
> index ac5b6fd..aa4190f 100644
> --- a/src/sim.c
> +++ b/src/sim.c
> @@ -145,6 +145,7 @@ static const char *const passwd_name[] = {
>  	[OFONO_SIM_PASSWORD_PHSP_PUK] = "servicepuk",
>  	[OFONO_SIM_PASSWORD_PHCORP_PIN] = "corp",
>  	[OFONO_SIM_PASSWORD_PHCORP_PUK] = "corppuk",
> +	[OFONO_SIM_PASSWORD_INVALID] = "invalid",

This seems wrong, the driver should not be reporting an invalid PIN type.

>  };
>
>  static void sim_own_numbers_update(struct ofono_sim *sim);
>

Regards,
-Denis

  reply	other threads:[~2017-08-07 19:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28  7:46 [PATCH] sim: fix crash in case of invalid sim password type Christophe Ronco
2017-06-28  7:46 ` Christophe Ronco
2017-08-07 19:19   ` Denis Kenzior [this message]
2017-08-29 12:29     ` [PATCHV2] " Christophe Ronco
2017-08-29 12:29       ` [PATCH] qmimodem: report failure in case of invalid pin type Christophe Ronco
2017-08-30 18:29         ` Denis Kenzior
2017-09-06  8:31           ` Christophe Ronco
2017-09-06 15:35             ` Denis Kenzior
2018-04-13 13:55               ` Christophe Ronco
2018-04-13 13:58                 ` [PATCH 1/2] qmi: report failure or retry " Christophe Ronco
2018-04-13 13:58                   ` [PATCH 2/2] qmi: report SIM not inserted when unable to get PIN type Christophe Ronco
2018-04-19 15:30                   ` [PATCH 1/2] qmi: report failure or retry in case of invalid pin type Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecbf6c15-96a2-adf9-97c0-2c83b6e2a842@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.