All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Mark Lehrer <lehrer@gmail.com>
Cc: Parav Pandit <parav@nvidia.com>,
	Zhu Yanjun <yanjun.zhu@intel.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>,
	"leon@kernel.org" <leon@kernel.org>,
	"zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCHv3 0/8] Fix the problem that rxe can not work in net namespace
Date: Thu, 20 Apr 2023 22:28:59 +0800	[thread overview]
Message-ID: <ecc2fe69-9e39-fe9a-9605-2418835c2e77@linux.dev> (raw)
In-Reply-To: <CADvaNzW=d03HS89H=XJDZvZUxW8HRUR4h83-voneS7egVrg1Ow@mail.gmail.com>


在 2023/4/20 2:01, Mark Lehrer 写道:
>> TCP without net ns notifier missed the net ns delete scenario results in a use after free bug, that should be fixed first as its critical.
>>
>> Sure. I also confronted this mentioned problem. If I remember correctly,
>> a net ns callback can fix this problem.
> I'm not sure if the bug fix will be this in depth, but I have a
> related question.  What is the proper way for the kernel nvme
> initiator code to know which netns context to use?  e.g. should we
> take the pid of the process that opened /dev/nvme-fabrics and look it
> up (presumaly this will be nvme-cli), and will this method give us
> enough details for both tcp & rdma?

Please check the netns callback functions. You will find all the answers 
to your questions.

Zhu Yanjun

>
> Mark
>
>
> On Tue, Apr 18, 2023 at 10:19 PM Zhu Yanjun <yanjun.zhu@linux.dev> wrote:
>>
>> 在 2023/4/19 8:43, Parav Pandit 写道:
>>>> From: Mark Lehrer <lehrer@gmail.com>
>>>> Sent: Friday, April 14, 2023 12:24 PM
>>>> I'm going to try making the nvme-fabrics set of modules use the network
>>>> namespace properly with RoCEv2.  TCP seems to work properly already, so this
>>>> should be more of a "port" than real development.
>>> TCP without net ns notifier missed the net ns delete scenario results in a use after free bug, that should be fixed first as its critical.
>> Sure. I also confronted this mentioned problem. If I remember correctly,
>> a net ns callback can fix this problem.
>>
>> Zhu Yanjun
>>
>>>> Are you (or anyone else) interested in working on this too?  I'm more familiar
>>>> with the video frame buffer area of the kernel, so first I'm familiarizing myself
>>>> with how nvme-fabrics works with TCP & netns.
>>>>
>>>> Thanks,
>>>> Mark

  reply	other threads:[~2023-04-20 14:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  6:06 [PATCHv3 0/8] Fix the problem that rxe can not work in net namespace Zhu Yanjun
2023-02-14  6:06 ` [PATCHv3 1/8] RDMA/rxe: Creating listening sock in newlink function Zhu Yanjun
2023-02-23 13:10   ` Zhu Yanjun
2023-02-14  6:06 ` [PATCHv3 2/8] RDMA/rxe: Support more rdma links in init_net Zhu Yanjun
2023-02-23 13:10   ` Zhu Yanjun
2023-02-14  6:06 ` [PATCHv3 3/8] RDMA/nldev: Add dellink function pointer Zhu Yanjun
2023-02-23 13:11   ` Zhu Yanjun
2023-02-14  6:06 ` [PATCHv3 4/8] RDMA/rxe: Implement dellink in rxe Zhu Yanjun
2023-02-23 13:12   ` Zhu Yanjun
2023-02-14  6:06 ` [PATCHv3 5/8] RDMA/rxe: Replace global variable with sock lookup functions Zhu Yanjun
2023-02-23 13:13   ` Zhu Yanjun
2023-02-14  6:06 ` [PATCHv3 6/8] RDMA/rxe: add the support of net namespace Zhu Yanjun
2023-02-23 13:14   ` Zhu Yanjun
2023-02-14  6:06 ` [PATCHv3 7/8] RDMA/rxe: Add the support of net namespace notifier Zhu Yanjun
2023-02-23 13:14   ` Zhu Yanjun
2023-02-14  6:06 ` [PATCHv3 8/8] RDMA/rxe: Replace l_sk6 with sk6 in net namespace Zhu Yanjun
2023-02-23 13:15   ` Zhu Yanjun
2023-02-23  0:31 ` [PATCHv3 0/8] Fix the problem that rxe can not work " Zhu Yanjun
2023-02-23  4:56   ` Jakub Kicinski
2023-02-23 11:42     ` Zhu Yanjun
2023-02-25  8:43   ` Rain River
2023-04-12 17:22 ` Mark Lehrer
2023-04-12 21:01   ` Mark Lehrer
2023-04-13  7:22     ` Zhu Yanjun
2023-04-13 13:00       ` Mark Lehrer
2023-04-13 13:05         ` Parav Pandit
2023-04-13 15:38           ` Mark Lehrer
2023-04-13 16:20             ` Parav Pandit
2023-04-13 16:23               ` Parav Pandit
2023-04-13 16:37                 ` Mark Lehrer
2023-04-13 16:42                   ` Parav Pandit
2023-04-14 15:49                     ` Zhu Yanjun
     [not found]                       ` <CADvaNzWfS5TFQ3b5JyaKFft06ihazadSJ15V3aXvWZh1jp1cCA@mail.gmail.com>
2023-04-14 16:24                         ` Mark Lehrer
2023-04-15 13:35                           ` Zhu Yanjun
2023-04-19  0:43                           ` Parav Pandit
2023-04-19  4:19                             ` Zhu Yanjun
2023-04-19 18:01                               ` Mark Lehrer
2023-04-20 14:28                                 ` Zhu Yanjun [this message]
2023-04-13  7:17   ` Zhu Yanjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecc2fe69-9e39-fe9a-9605-2418835c2e77@linux.dev \
    --to=yanjun.zhu@linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=lehrer@gmail.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=yanjun.zhu@intel.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.