From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D1D1C433F5 for ; Tue, 15 Mar 2022 21:01:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3CE5283BF7; Tue, 15 Mar 2022 22:01:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=web.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=web.de header.i=@web.de header.b="GZ+bTD4E"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1BDC283C01; Tue, 15 Mar 2022 22:01:20 +0100 (CET) Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 635568309E for ; Tue, 15 Mar 2022 22:01:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=web.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=smoch@web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1647378075; bh=1fDPhd7UmCGw5fRUsPQ0dLOJBTywTK5n5bh/+iTsEqA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=GZ+bTD4EjGGJl4Pk0vojEMZO9m7wL6AKTpAVEQKjHJg6aGSM2//Y3Hc3FoOSnXsiR tbAPtWzItAG0yMdy/jWinxfBSXmoyMW0W9Ek8HIm2U1zzMk8R20wHSaBhrxF4+gSf5 EbhaRKPfaaEhWXnlc43iEynmmoDhtvIL5SL8sico= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.27] ([77.11.107.138]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MSZM3-1nfOSZ2yld-00T2Cs; Tue, 15 Mar 2022 22:01:14 +0100 Message-ID: Date: Tue, 15 Mar 2022 22:01:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] tbs2910: Convert to DM_SERIAL Content-Language: en-GB To: Fabio Estevam , sbabic@denx.de Cc: u-boot@lists.denx.de, trini@konsulko.com, Fabio Estevam References: <20220315204705.2175288-1-festevam@gmail.com> From: Soeren Moch In-Reply-To: <20220315204705.2175288-1-festevam@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3JdhaVUXEQeTSQTt1LHC54vjajjlB0RBb9EptIP+Ovdtbt59PCi 0VfBdQhhVuS/GZ4cNc8XImOzUpzJmgCXkwuN8hC1QnKT6p5ajOpOFnmjpyIMY82uy5gUdJw HtNbXwicSw0wpZaIhO4Cpa0kTsrdGoH6RltHhnevD1GL8vGStCR/28KjhJDO+kxxxUhr7L1 qU2zFncJ5KYrZprEtFkPA== X-UI-Out-Filterresults: notjunk:1;V03:K0:4Gs6HWTzmo0=:vNUX2TW11dMUKVT5JQOYK3 IHDVmxL5Ydg+1Fdpq8sy7mkjbckYt1HE3jZZ84kVRHped5knRyCEcOBAnuOc9idIgI/W9b9Bc RJdRX3QElWUxUTuchHijK/NvQQUY2746sVV4785zflShaLqruiFkUNU2EME1q0zRc7RYpiHti UH21uqrSzpD2Uu8eqeRjiMRsgecAmoZs7KlnyZZNdOsUFAAuKoxkJrlLR8/EqEPX85ztyI0IJ tH01lukygpVlQ6qoAfX7CdErJln4Qb+gtJJQnjPh9DSX0TXZSg2Pj/HL8bfzjuAL634X78Ybd XR9xGZObwwNS1K2v19uqScU9cCrOVqb4H3BLOa+rjhIU5WshfTgqqpewRzWnLxIQ67jaMqaBr bg+qgAgXB7rdKtlrTk8xoozZaGAwMlivRTiD6u3D2uOL60DDyFOU3g/74lX2POfvIoRyQjWQG Ld4Uqh362XebyaC05F7SpgkcdQYldFU2o+LzbKBHQarTE8p5NynnAdl7SdfH3vr1lJAfhN5b3 seTDR0QUMw3Yvfe2/O2KuF0zy52nz+pWQjL9M8tKfQtrlvbPZf0On+gjaGRv2uCN9ioZ2f2At I8YVXG/xq1JoDUfMnaFsHGvWeA8rb4QT/rjBPF4H2RXjm9EHn7dOpbjcBJbjjpSAJVwwCdFBA A3dfE6c2vS0X15plYuiecFEpGCEgRpQAx1q0k1GYjCGrqnaOdg3DN1uXyARTAnCYjydojQ6b4 Txk75+/dWle27rMMldY4HJPss5NVSqxsep5hWUk39CXQ2wPu8zfrNtUVexU5FsxOZn81y/8Gu YsLUG6BO8RJHtV3ZNyBEa0OvwDRJYPtrFryKVRoXdhB98a92NMWwrjBWfLHeoCrNS3KcHjnEE sUVuZTgXgRab5MwMMAhQVc8Jt/wHd3oKf+YMWxWAchsGMzOXVqb3tBk5rJEkuL7DgEIOsaUvn lYE2QWgxcvcnMMjS4JmmQbunPtadIGeV0rJGSGBfy2Y+zOwQESUjJyxAg2MO8cUNNvKapRq2f iHDsqNhp3HN4XOcNu/BdQ3YN/JerQoN3y3E/6dcaGNL1USVeeiFERhpwTMMAqg8cWwHo/+dqc jmoGaue9pNLoKM= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 15.03.22 21:47, Fabio Estevam wrote: > From: Fabio Estevam > > Conversion to DM_SERIAL is mandatory. > > Select DM_SERIAL and add a imx6q-tbs2910-u-boot.dtsi file > that describes the nodes that require dm-pre-reloc, which allows > the DM model to configure the UART pinctrl early. > > Remove the now unneeded board UART initialization. > > Signed-off-by: Fabio Estevam I will test this within the next few days, please give me a little more time. Thanks, Soeren > --- > arch/arm/dts/imx6q-tbs2910-u-boot.dtsi | 17 +++++++++++++++++ > arch/arm/dts/imx6qdl.dtsi | 4 ++-- > board/tbs/tbs2910/tbs2910.c | 26 -------------------------- > configs/tbs2910_defconfig | 2 +- > 4 files changed, 20 insertions(+), 29 deletions(-) > create mode 100644 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi > > diff --git a/arch/arm/dts/imx6q-tbs2910-u-boot.dtsi b/arch/arm/dts/imx6q= -tbs2910-u-boot.dtsi > new file mode 100644 > index 000000000000..65ab052ac2c0 > --- /dev/null > +++ b/arch/arm/dts/imx6q-tbs2910-u-boot.dtsi > @@ -0,0 +1,17 @@ > +// SPDX-License-Identifier: GPL-2.0+ > + > +&aips1 { > + u-boot,dm-pre-reloc; > +}; > + > +&pinctrl_uart1 { > + u-boot,dm-pre-reloc; > +}; > + > +&soc { > + u-boot,dm-pre-reloc; > +}; > + > +&uart1 { > + u-boot,dm-pre-reloc; > +}; > diff --git a/arch/arm/dts/imx6qdl.dtsi b/arch/arm/dts/imx6qdl.dtsi > index efd89510d512..d89272039b28 100644 > --- a/arch/arm/dts/imx6qdl.dtsi > +++ b/arch/arm/dts/imx6qdl.dtsi > @@ -139,7 +139,7 @@ > interrupts =3D <0 94 IRQ_TYPE_LEVEL_HIGH>; > }; > > - soc { > + soc: soc { > #address-cells =3D <1>; > #size-cells =3D <1>; > compatible =3D "simple-bus"; > @@ -283,7 +283,7 @@ > status =3D "disabled"; > }; > > - bus@2000000 { /* AIPS1 */ > + aips1: bus@2000000 { /* AIPS1 */ > compatible =3D "fsl,aips-bus", "simple-bus"; > #address-cells =3D <1>; > #size-cells =3D <1>; > diff --git a/board/tbs/tbs2910/tbs2910.c b/board/tbs/tbs2910/tbs2910.c > index faf73cc218c9..3a447ca8a93c 100644 > --- a/board/tbs/tbs2910/tbs2910.c > +++ b/board/tbs/tbs2910/tbs2910.c > @@ -22,32 +22,12 @@ > #include > DECLARE_GLOBAL_DATA_PTR; > > -#define UART_PAD_CTRL (PAD_CTL_PUS_100K_UP | \ > - PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm | \ > - PAD_CTL_SRE_FAST | PAD_CTL_HYS) > - > -static iomux_v3_cfg_t const uart1_pads[] =3D { > - MX6_PAD_CSI0_DAT10__UART1_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL), > - MX6_PAD_CSI0_DAT11__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL), > -}; > - > -static iomux_v3_cfg_t const uart2_pads[] =3D { > - MX6_PAD_EIM_D26__UART2_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL), > - MX6_PAD_EIM_D27__UART2_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL), > -}; > - > int dram_init(void) > { > gd->ram_size =3D 2048ul * 1024 * 1024; > return 0; > } > > -static void setup_iomux_uart(void) > -{ > - imx_iomux_v3_setup_multiple_pads(uart1_pads, ARRAY_SIZE(uart1_pads)); > - imx_iomux_v3_setup_multiple_pads(uart2_pads, ARRAY_SIZE(uart2_pads)); > -} > - > #ifdef CONFIG_FSL_ESDHC_IMX > /* set environment device to boot device when booting from SD */ > int board_mmc_get_env_dev(int devno) > @@ -150,12 +130,6 @@ static void setup_display(void) > } > #endif /* CONFIG_VIDEO_IPUV3 */ > > -int board_early_init_f(void) > -{ > - setup_iomux_uart(); > - return 0; > -} > - > #ifdef CONFIG_CMD_BMODE > static const struct boot_mode board_boot_modes[] =3D { > /* 4 bit bus width */ > diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig > index 8a3316056408..63a778a45f0b 100644 > --- a/configs/tbs2910_defconfig > +++ b/configs/tbs2910_defconfig > @@ -23,7 +23,6 @@ CONFIG_USE_PREBOOT=3Dy > CONFIG_PREBOOT=3D"echo PCI:; pci enum; pci 1; usb start; if hdmidet; t= hen run set_con_hdmi; else run set_con_serial; fi" > CONFIG_DEFAULT_FDT_FILE=3D"imx6q-tbs2910.dtb" > CONFIG_PRE_CONSOLE_BUFFER=3Dy > -CONFIG_BOARD_EARLY_INIT_F=3Dy > CONFIG_HUSH_PARSER=3Dy > CONFIG_SYS_PROMPT=3D"Matrix U-Boot> " > # CONFIG_CMD_BDI is not set > @@ -81,6 +80,7 @@ CONFIG_PINCTRL=3Dy > CONFIG_PINCTRL_IMX6=3Dy > CONFIG_DM_RTC=3Dy > CONFIG_RTC_DS1307=3Dy > +CONFIG_DM_SERIAL=3Dy > CONFIG_MXC_UART=3Dy > CONFIG_DM_THERMAL=3Dy > CONFIG_IMX_THERMAL=3Dy