From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A70C54E76 for ; Mon, 20 Nov 2023 12:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232475AbjKTMAu (ORCPT ); Mon, 20 Nov 2023 07:00:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbjKTMAr (ORCPT ); Mon, 20 Nov 2023 07:00:47 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E9E8E for ; Mon, 20 Nov 2023 04:00:44 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-543456dbd7bso10228920a12.1 for ; Mon, 20 Nov 2023 04:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700481643; x=1701086443; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sjQoDu2espA/DfyPs5NRMbvJF9ab6oxweEuJ9vmOymk=; b=ch2KhcdqzcOQ5yfhEq0U0Jta9luyp0Js4cirvGj52p11ZX3EkDnQi0DD9baIqpnUvf kjW93wVEeYejPB9KkH+Icb3HCeWKAH/bjzIwF5XqyzKJzd41u6WaJB5+O8l+lheVb+2V pEc4/81FzHoQ9UF/5n//Hn/vve+/Th7yiYBWdYWdmdPTgjsI9zFbT2p9g82yHyasr3Qq c5ftIWMsY9d+RQrtVOpk92GvDh8JKEijbDljIUZNbO8sddH7kgiCDxVki+yvPS9qffrP K9D0gCx4sIX3K7jCfgyijF6Hbx1TRr47Q1nAxf3H3TUt7icT+5q05d8jUknQtZkXFEHX pxMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700481643; x=1701086443; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sjQoDu2espA/DfyPs5NRMbvJF9ab6oxweEuJ9vmOymk=; b=OiekChWnKI4HsV7Pqni/fwUxrg98H6bcH2DD6iMvp6OuVj9+IKyVGvDjQgzNaw9SUB Z1dgTwfOWjQe9aYObviQBHUGoq+PBg47JHNwinxLh2q7FYgZ++TDyEIBABHYKpb5X67R 0t8SFvS0iXxZryF7iHBmP0wDberJgXnK5PoAsVMXdWDk6n6LyiRdHZ6iwZ4tZOLr0cyH k3pCe5ALMIH9EpMK9yQkTU9yREkA97jek3zpFH0Fgdqv11+00C+w7syRtp5kVnYalDm/ 4u8+VCzEEy4nzsMWSq52fIHBB0IdFpw93sgQ+C9jh7SV+mKSXqkxWNkjODgsCk7JfPHZ BhuA== X-Gm-Message-State: AOJu0YwQotDjeL3WWQHZjRhgdOAM0SSTASP10z76eTgWjK0kKOK5m8zA LYc9ASacIJbSzHVVmiWuvA3GhQ== X-Google-Smtp-Source: AGHT+IEGSzMI75iQxFYNWOV/kb9Dv4sZmqfv+pBqswKoug6sgFP47kbo/NInWu7mOCU4xNf0dB0aOA== X-Received: by 2002:a17:906:c111:b0:9ee:9d98:7d8c with SMTP id do17-20020a170906c11100b009ee9d987d8cmr1700646ejc.6.1700481642741; Mon, 20 Nov 2023 04:00:42 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id o9-20020a509b09000000b0053deb97e8e6sm3671902edi.28.2023.11.20.04.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 04:00:42 -0800 (PST) Date: Mon, 20 Nov 2023 07:00:39 -0500 From: Dan Carpenter To: Kent Overstreet Cc: David Laight , Colin Ian King , Brian Foster , "linux-bcachefs@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][next] bcachefs: remove redundant initialization of variable level Message-ID: References: <20231111204528.339603-1-colin.i.king@gmail.com> <20231111210208.qra7xhf2nd4pqvst@moria.home.lan> <184af6778ab64b3eb6a4a6071974d5e8@AcuMS.aculab.com> <20231111233904.zxgqyw3epefiqiro@moria.home.lan> <20231112191249.srvcmay2yeewy7ql@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231112191249.srvcmay2yeewy7ql@moria.home.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 12, 2023 at 02:12:49PM -0500, Kent Overstreet wrote: > David, I don't want you giving this kind of advice here, and if finding > declarations is something you have trouble with - perhaps find something > easier to do. David is correct. Putting declarations in the middle of code is still frowned on. It's necessary for the __cleanup work and it's okay in for loop iterators but it's generally frowned on. Please don't force people to redo patches in non-standard style. regards, dan carpenter