All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrice CHOTARD <patrice.chotard@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 9/9] pinctrl: sandbox: Add get_pin_muxing ops support
Date: Tue, 9 Oct 2018 09:31:24 +0000	[thread overview]
Message-ID: <eccb055c-bb4b-83ae-c8a1-ae04971447f5@st.com> (raw)
In-Reply-To: <0d17efb9-6ae2-cc50-3181-007cdb10ab45@microchip.com>

Hi Eugen

On 10/01/2018 03:26 PM, Eugen Hristev wrote:
> 
> 
> On 01.10.2018 14:59, Patrice Chotard wrote:
>> Add get_pin_mux ops support to display the pin muxing
>> description of the sandbox_pins[]
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> ---
>>
>> Changes in v2: None
>>
>>   drivers/pinctrl/pinctrl-sandbox.c | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/pinctrl/pinctrl-sandbox.c
>> b/drivers/pinctrl/pinctrl-sandbox.c
>> index 755ac08bdf72..5c92acbff8e0 100644
>> --- a/drivers/pinctrl/pinctrl-sandbox.c
>> +++ b/drivers/pinctrl/pinctrl-sandbox.c
>> @@ -17,6 +17,14 @@ static const char * const sandbox_pins[] = {
>>       "W1"
>>   };
>>   +static const char * const sandbox_pins_muxing[] = {
>> +    "I2C SCL",
>> +    "I2C SDA",
>> +    "Uart TX",
>> +    "Uart RX",
>> +    "Onwire gpio",
> 
> You have a typo here, its "Onewire", but can name it "1-wire gpio" as it
> fits the most used naming.

Ok

Thanks

Patrice

> 
>> +};
>> +
>>   static const char * const sandbox_groups[] = {
>>       "i2c",
>>       "serial_a",
>> @@ -56,6 +64,12 @@ static const char *sandbox_get_pin_name(struct
>> udevice *dev, unsigned selector)
>>       return sandbox_pins[selector];
>>   }
>>   +static const char *sandbox_get_pin_muxing(struct udevice *dev,
>> +                      unsigned int selector)
>> +{
>> +    return sandbox_pins_muxing[selector];
>> +}
>> +
>>   static int sandbox_get_groups_count(struct udevice *dev)
>>   {
>>       return ARRAY_SIZE(sandbox_groups);
>> @@ -123,6 +137,7 @@ static int sandbox_pinconf_group_set(struct
>> udevice *dev,
>>   const struct pinctrl_ops sandbox_pinctrl_ops = {
>>       .get_pins_count = sandbox_get_pins_count,
>>       .get_pin_name = sandbox_get_pin_name,
>> +    .get_pin_muxing = sandbox_get_pin_muxing,
>>       .get_groups_count = sandbox_get_groups_count,
>>       .get_group_name = sandbox_get_group_name,
>>       .get_functions_count = sandbox_get_functions_count,
>>

  reply	other threads:[~2018-10-09  9:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01 11:59 [U-Boot] [PATCH v2 0/9] Add pinmux command Patrice Chotard
2018-10-01 11:59 ` [U-Boot] [PATCH v2 1/9] dm: pinctrl: Add get_pin_muxing() ops Patrice Chotard
2018-10-01 11:59 ` [U-Boot] [PATCH v2 2/9] dm: pinctrl: Add pinctrl_get_pin_name and pinctrl_get_pins_count Patrice Chotard
2018-10-01 11:59 ` [U-Boot] [PATCH v2 3/9] dm: uclass: Add uclass_foreach_dev_probe Patrice Chotard
2018-10-06 21:45   ` Simon Glass
2018-10-01 11:59 ` [U-Boot] [PATCH v2 4/9] cmd: pinmux: Add pinmux command Patrice Chotard
2018-10-01 11:59 ` [U-Boot] [PATCH v2 5/9] pinctrl: stm32: Add get_pins_count() ops Patrice Chotard
2018-10-01 11:59 ` [U-Boot] [PATCH v2 6/9] pinctrl: stm32: Add get_pin_name() ops Patrice Chotard
2018-10-01 11:59 ` [U-Boot] [PATCH v2 7/9] pinctrl: stm32: Add get_pin_muxing() ops Patrice Chotard
2018-10-01 11:59 ` [U-Boot] [PATCH v2 8/9] gpio: stm32f7: Add ops get_function Patrice Chotard
2018-10-01 11:59 ` [U-Boot] [PATCH v2 9/9] pinctrl: sandbox: Add get_pin_muxing ops support Patrice Chotard
2018-10-01 13:26   ` Eugen Hristev
2018-10-09  9:31     ` Patrice CHOTARD [this message]
2018-10-04  1:13 ` [U-Boot] [PATCH v2 0/9] Add pinmux command Simon Glass
2018-10-09 13:17   ` Patrice CHOTARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eccb055c-bb4b-83ae-c8a1-ae04971447f5@st.com \
    --to=patrice.chotard@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.