From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEA8EC28CBC for ; Sat, 9 May 2020 12:00:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 794BA21473 for ; Sat, 9 May 2020 12:00:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JeyW2ojX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 794BA21473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXOA3-0007Qf-Hr for qemu-devel@archiver.kernel.org; Sat, 09 May 2020 08:00:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXO97-0006ia-8C for qemu-devel@nongnu.org; Sat, 09 May 2020 07:59:57 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:42125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXO95-0005IL-Vy for qemu-devel@nongnu.org; Sat, 09 May 2020 07:59:56 -0400 Received: by mail-wr1-x441.google.com with SMTP id s8so4987673wrt.9 for ; Sat, 09 May 2020 04:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+zwjzSck4OKa6mXxFynV8f6GvgDnEVsR2Fn0QLx/3oU=; b=JeyW2ojXyClDLxeVnuhml+PSNGQQWCzclKjQOT4rPGrtVzrs3Jer4OjIGrOfDyV+ll PtmPsLB0SebKpdmD9otFgONYNFWwZqxqfV/oYVkKa+iZkXWqRZc5XmWUEWQUTle0UwWP 1MBDBdIHph0i3I+kqDFsRspwGdO1U7+EnkVqwQTAoY8MQ/G3NvcfF1vjy+ePkuE3QUe4 YL5o2zfM39VV7qONKp3PeRmHbYGhKQd78QZf0lQDVV4OocYOGJtx73/HvZzsHx1i317S T0TMG4HGlBvlPytiNRNIYaPBiaL16/K/vIOLc18nNdLRU88OzsrLMM1pOIHPBDXb+goP R5GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+zwjzSck4OKa6mXxFynV8f6GvgDnEVsR2Fn0QLx/3oU=; b=qCrMTP1i1u6flaToVsYWvgsNqgGzNGpUU9rAgPXHXRAY5yDhsZpp/99j78i90HEp6K G2YFaenTcWQ/+nUlNxyq1q6TxH2IxvIf5f80uV33+eQeTM5ews+hVwtn0ECoD7Yiyask AwJxKgYK2zw8j/rQ1R5QoGZ+3MVZkBb2p25gKmBzmc11dJfZ745o9XpdCP9kihEYx8Qm oUWmnIa5J/3Ifdd3Kkl2fD6V6hK7qasQvCj0ibF9kn/v2hZgdXn2l819iyK+hpEaM5jb yjua5CrKO9cWtAv6UZg6ZBoc7bMS0NXnIpEXSLHdgM7KF3HLR+hn0hFZEoYZuNPIQZkI 17/A== X-Gm-Message-State: AGi0PuY+wNUDKBT2GZSntyyrBXmbZdIbBjS4w0117ESu19CMRmFB0rJT IqBc7sDM/LxneInXdli2PJM= X-Google-Smtp-Source: APiQypLC6ugyRg/a+DCi3l7dGsvjSMsVPqrPRnHeBvMlv6zDOLmrN1jiIK895w47QJek5/649yEYxA== X-Received: by 2002:adf:dd01:: with SMTP id a1mr4302986wrm.224.1589025594340; Sat, 09 May 2020 04:59:54 -0700 (PDT) Received: from [192.168.1.38] (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id f26sm17552208wmj.11.2020.05.09.04.59.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 04:59:53 -0700 (PDT) Subject: Re: [PATCH v5 02/19] exec: Fix cpu_watchpoint_address_matches address length To: Richard Henderson , qemu-devel@nongnu.org References: <20200508154359.7494-1-richard.henderson@linaro.org> <20200508154359.7494-3-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Sat, 9 May 2020 13:59:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200508154359.7494-3-richard.henderson@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::441; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/8/20 5:43 PM, Richard Henderson wrote: > The only caller of cpu_watchpoint_address_matches passes > TARGET_PAGE_SIZE, so the bug is not currently visible. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/exec.c b/exec.c > index 2874bb5088..5162f0d12f 100644 > --- a/exec.c > +++ b/exec.c > @@ -1127,7 +1127,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len) > int ret = 0; > > QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { > - if (watchpoint_address_matches(wp, addr, TARGET_PAGE_SIZE)) { > + if (watchpoint_address_matches(wp, addr, len)) { > ret |= wp->flags; > } > } > Reviewed-by: Philippe Mathieu-Daudé