From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C416C54EE9 for ; Tue, 20 Sep 2022 07:07:05 +0000 (UTC) Received: from localhost ([::1]:41190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaXLT-0003K2-Oo for qemu-devel@archiver.kernel.org; Tue, 20 Sep 2022 03:07:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaXF9-0001Hz-2e for qemu-devel@nongnu.org; Tue, 20 Sep 2022 03:00:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:42236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaXF6-0003NX-5g for qemu-devel@nongnu.org; Tue, 20 Sep 2022 03:00:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663657226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SGwX909Gb+syIQD2vf4rn9A/9C8ljwxBynEmiGkdZe0=; b=LPUsmY4+K8ddr9Ktqr4Gqmj6kg8fLFEfxbzuWMcgBwVnQLb/DIlNYMgezyK9ZnQTaBhRCD x4Av8Z+MQiQR2PXxhh+EWXofvjaoTP00/L3SQLPbny385gyaykE2HgALUR7Sh47dvdMpkI cz6/AwPdlLxaBE+3wK9j1AotLjX049o= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-407-s2SnLZOONMKQg3YEq3TYnw-1; Tue, 20 Sep 2022 03:00:24 -0400 X-MC-Unique: s2SnLZOONMKQg3YEq3TYnw-1 Received: by mail-wr1-f71.google.com with SMTP id d30-20020adfa41e000000b00228c0e80c49so746732wra.21 for ; Tue, 20 Sep 2022 00:00:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=SGwX909Gb+syIQD2vf4rn9A/9C8ljwxBynEmiGkdZe0=; b=ffhrjvx4GcJipKzFI0UzxtUguFZ/mcKcmxlGbtkylYhMNv5eXhyRAo25zPLWnZ+DGO sHdX45bsJolU0kLL4/jV5JEIV+YBU8Yw3v6OyJiHVtUD8no2cEfDdsKDE/JMWxTj5ztM gms7Rhy0Oi7hIMMqFrG+syqsRt0S5apAY2ZhvvqKEL88nnh9xJussydA80yNnVOcqlQV bBUVk4JSCOMAs4RsJdi4PVwFbaPzLtrBuSo0EXowc4uQMeeGMHzoE+eSOwZDIdd2YHH+ u6ROjmbogn0ZMym/LsRkqDBBAG5PixogbhXXTwrgpdl+uLNp5l1RG8PGbgcZfZVQ/qso Z10Q== X-Gm-Message-State: ACrzQf2qr41q3iarmUNSv6gaK3c9IKnLlLp3sHtMExm9C/nsWHFf7FwC rAHMp6O9ztqz6JsrHHgIm/GOVJ3CH7DNlFwK7khm194seg6b2gDhKS5tJu5BOA1A+tjKR8fCPP8 c8T1TDKXNhCY0E9A= X-Received: by 2002:a05:600c:3595:b0:3b4:8378:98d2 with SMTP id p21-20020a05600c359500b003b4837898d2mr1260535wmq.64.1663657223042; Tue, 20 Sep 2022 00:00:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5/zBNl202/6MnWvixiklypCOVQUHxBJBUDs1kPuIy9liy/zddyMp8CjX7hQVEB1hHXhbug5A== X-Received: by 2002:a05:600c:3595:b0:3b4:8378:98d2 with SMTP id p21-20020a05600c359500b003b4837898d2mr1260511wmq.64.1663657222846; Tue, 20 Sep 2022 00:00:22 -0700 (PDT) Received: from [192.168.0.5] (ip-109-43-177-8.web.vodafone.de. [109.43.177.8]) by smtp.gmail.com with ESMTPSA id o17-20020a05600c511100b003b4935f04a4sm1581955wms.5.2022.09.20.00.00.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 00:00:22 -0700 (PDT) Message-ID: Date: Tue, 20 Sep 2022 09:00:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC Content-Language: en-US To: Patrick Venture Cc: Laurent Vivier , Havard Skinnemoen , CS20 KFTing , qemu-arm , QEMU Developers , Hao Wu References: <20220906163138.2831353-1-venture@google.com> <98b23697-00ec-2952-31c1-258419bd5440@redhat.com> From: Thomas Huth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.952, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20/09/2022 00.37, Patrick Venture wrote: > > > On Mon, Sep 19, 2022 at 5:44 AM Thomas Huth > wrote: > > On 06/09/2022 18.31, Patrick Venture wrote: > > The register tests walks all the registers to verify they are initially > > 0 when appropriate.  However, if the MAC address is set in the register > >    space, this should not be checked against 0. > > > > Reviewed-by: Hao Wu > > > Change-Id: I02426e39bdab33ceedd42c49d233e8680d4ec058 > > What's that change-id good for? > > > Oops, sorry about that.  I can send out a v2 without it, or during > application someone can nicely trim it? :) I can take the patch through my qtest branch - I'll drop the line there. > Basically ack, but one question: Where should that non-zero MAC address > come > from / when did you hit a problem here? If QEMU is started without any mac > settings at all (like it is done here), the register never contains a > non-zero value, does it? > > > So, there's a bug in the emc device presently where that value isn't set > when it should be.  I have that bug fixed, but for whatever reason, probably > not enough caffeine, I didn't bundle the two patches together. OK, makes sense now, thanks for the explanation! Thomas