From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A64FC433EF for ; Mon, 15 Nov 2021 12:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 003E8619E5 for ; Mon, 15 Nov 2021 12:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231405AbhKOMiQ (ORCPT ); Mon, 15 Nov 2021 07:38:16 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:61462 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230438AbhKOMh4 (ORCPT ); Mon, 15 Nov 2021 07:37:56 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AFBrtdq011652; Mon, 15 Nov 2021 12:34:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=iY1Col5FMwaQrAzLqIT+kCvknRgj+GHBiwaP932CpAc=; b=rHm01J9/yZtsmLfgZWnmsAXOyv63fwmQu1nqKqVaZlS5njoWrYRB+hOWtRj2Q4zgX3iJ KbHu6bkbviPkKCNV3rZCPKXpd/qhIqKCAJ3xqrihYkCuYSvLcrCHeW5fkwzbf/b2O6nk ci+a50UTTB+kf0KxKePW3kBsMXDSO8WWnVmc7Gl+uY5n9RbydndMz7JdfMYBF6S6pWbC asEE8oJ3tp6R90J06aKYMEwlc3FKXQQMaRPxakufQawFkceGX6aTveYZG31Q8Pvn2zQ9 APDMX22OYR3NE7AKukdevwffNueZNTjR3EQiFbWRkgfUWtH3faMIlNIpr3lW2h7Jo8it Yg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3cbq348tva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 12:34:04 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1AFBsE1K016059; Mon, 15 Nov 2021 12:34:03 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0b-001b2d01.pphosted.com with ESMTP id 3cbq348tup-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 12:34:03 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1AFCJ8oN002492; Mon, 15 Nov 2021 12:34:01 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma01fra.de.ibm.com with ESMTP id 3ca509cqq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 12:34:01 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1AFCXwha27787704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Nov 2021 12:33:58 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53F7E4204D; Mon, 15 Nov 2021 12:33:58 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 72B9D4205F; Mon, 15 Nov 2021 12:33:57 +0000 (GMT) Received: from [9.171.56.111] (unknown [9.171.56.111]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 15 Nov 2021 12:33:57 +0000 (GMT) Message-ID: Date: Mon, 15 Nov 2021 13:33:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 0/5] KVM: Cap KVM_CAP_NR_VCPUS by KVM_CAP_MAX_VCPUS and re-purpose it on x86 Content-Language: en-US To: Paolo Bonzini , Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Eduardo Habkost , Marc Zyngier , Andrew Jones , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Mackerras , Michael Ellerman , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211111162746.100598-1-vkuznets@redhat.com> <4a3c7be7-12fa-6e47-64eb-02e6c5be5dbc@redhat.com> From: Christian Borntraeger In-Reply-To: <4a3c7be7-12fa-6e47-64eb-02e6c5be5dbc@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: F_7VLECjtzfz58UlopgCykV9hLKIwLBB X-Proofpoint-GUID: Xk7vY1f_lcFudvzcJVI-5_sBZtDokgNi Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-15_10,2021-11-15_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 clxscore=1015 bulkscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111150070 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 11.11.21 um 17:32 schrieb Paolo Bonzini: > On 11/11/21 17:27, Vitaly Kuznetsov wrote: >> This is a comtinuation of "KVM: x86: Drop arbitraty KVM_SOFT_MAX_VCPUS" >> (https://lore.kernel.org/kvm/20211111134733.86601-1-vkuznets@redhat.com/) >> work. >> >> 1) Enforce KVM_CAP_NR_VCPUS <= KVM_CAP_MAX_VCPUS rule on all >>   architectures. [Sean Christopherson] >> 2) Make KVM_CAP_NR_VCPUS return num_online_cpus() and not an arbitrary >>   value of '710' on x86. >> >> Everything but x86 was only 'eyeball tested', the change is trivial >> but sorry in advance if I screwed up) > > Christian, can you look at this for s390?  Returning a fixed value seems wrong for KVM_CAP_NR_VCPUS. If we talk about recommended number, then num_online_cpus() also seems to make sense on s390 so if you change that for s390 as well I can ACK this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B6BC433F5 for ; Mon, 15 Nov 2021 12:35:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B99A619E5 for ; Mon, 15 Nov 2021 12:35:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8B99A619E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=de.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7AifxyNYAehrBnLnfcLabVHYvll41T7bI7zoCWZDisw=; b=et//FQnRZugYyQ3kxHm5WLPvZx UtUZgNPaf+ojQ9BHtX7HrWYlDER5Sc93pbXT2Nt4tiJdZgAPwkvZnAmcc2GJ3N9NKmSv+tnDv7JS9 fvagVm086usHKPXTcX+xuzeuPHCzAv2fQLupoqfhB/JvuQUWaEKeGObjm3M2whxNFxmpQcaxOqaJb CgXI634W0UoNlpFWAf4P0VDa1KM+VjGCUOu1yoAG/Z6FR2qRa8umDc+aGtTlMEONbI9eCoLXmqIjT OF/Vb616hNj9K6J3Ruk3wIP2zh37sO83rbXKB49ER1bdmsA0hALGzz7RFXzU8x+dtQjHrKFBd7kcW 6QnovmhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmbBj-00FWQA-Qc; Mon, 15 Nov 2021 12:34:20 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmbBf-00FWPg-2M; Mon, 15 Nov 2021 12:34:17 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AFBrtdq011652; Mon, 15 Nov 2021 12:34:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=iY1Col5FMwaQrAzLqIT+kCvknRgj+GHBiwaP932CpAc=; b=rHm01J9/yZtsmLfgZWnmsAXOyv63fwmQu1nqKqVaZlS5njoWrYRB+hOWtRj2Q4zgX3iJ KbHu6bkbviPkKCNV3rZCPKXpd/qhIqKCAJ3xqrihYkCuYSvLcrCHeW5fkwzbf/b2O6nk ci+a50UTTB+kf0KxKePW3kBsMXDSO8WWnVmc7Gl+uY5n9RbydndMz7JdfMYBF6S6pWbC asEE8oJ3tp6R90J06aKYMEwlc3FKXQQMaRPxakufQawFkceGX6aTveYZG31Q8Pvn2zQ9 APDMX22OYR3NE7AKukdevwffNueZNTjR3EQiFbWRkgfUWtH3faMIlNIpr3lW2h7Jo8it Yg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3cbq348tva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 12:34:04 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1AFBsE1K016059; Mon, 15 Nov 2021 12:34:03 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0b-001b2d01.pphosted.com with ESMTP id 3cbq348tup-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 12:34:03 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1AFCJ8oN002492; Mon, 15 Nov 2021 12:34:01 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma01fra.de.ibm.com with ESMTP id 3ca509cqq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 12:34:01 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1AFCXwha27787704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Nov 2021 12:33:58 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53F7E4204D; Mon, 15 Nov 2021 12:33:58 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 72B9D4205F; Mon, 15 Nov 2021 12:33:57 +0000 (GMT) Received: from [9.171.56.111] (unknown [9.171.56.111]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 15 Nov 2021 12:33:57 +0000 (GMT) Message-ID: Date: Mon, 15 Nov 2021 13:33:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 0/5] KVM: Cap KVM_CAP_NR_VCPUS by KVM_CAP_MAX_VCPUS and re-purpose it on x86 Content-Language: en-US To: Paolo Bonzini , Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Eduardo Habkost , Marc Zyngier , Andrew Jones , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Mackerras , Michael Ellerman , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211111162746.100598-1-vkuznets@redhat.com> <4a3c7be7-12fa-6e47-64eb-02e6c5be5dbc@redhat.com> From: Christian Borntraeger In-Reply-To: <4a3c7be7-12fa-6e47-64eb-02e6c5be5dbc@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: F_7VLECjtzfz58UlopgCykV9hLKIwLBB X-Proofpoint-GUID: Xk7vY1f_lcFudvzcJVI-5_sBZtDokgNi X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-15_10,2021-11-15_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 clxscore=1015 bulkscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111150070 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211115_043415_668116_F61A0924 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gMTEuMTEuMjEgdW0gMTc6MzIgc2NocmllYiBQYW9sbyBCb256aW5pOgo+IE9uIDExLzExLzIx IDE3OjI3LCBWaXRhbHkgS3V6bmV0c292IHdyb3RlOgo+PiBUaGlzIGlzIGEgY29tdGludWF0aW9u IG9mICJLVk06IHg4NjogRHJvcCBhcmJpdHJhdHkgS1ZNX1NPRlRfTUFYX1ZDUFVTIgo+PiAoaHR0 cHM6Ly9sb3JlLmtlcm5lbC5vcmcva3ZtLzIwMjExMTExMTM0NzMzLjg2NjAxLTEtdmt1em5ldHNA cmVkaGF0LmNvbS8pCj4+IHdvcmsuCj4+Cj4+IDEpIEVuZm9yY2UgS1ZNX0NBUF9OUl9WQ1BVUyA8 PSBLVk1fQ0FQX01BWF9WQ1BVUyBydWxlIG9uIGFsbAo+PiDCoCBhcmNoaXRlY3R1cmVzLiBbU2Vh biBDaHJpc3RvcGhlcnNvbl0KPj4gMikgTWFrZSBLVk1fQ0FQX05SX1ZDUFVTIHJldHVybiBudW1f b25saW5lX2NwdXMoKSBhbmQgbm90IGFuIGFyYml0cmFyeQo+PiDCoCB2YWx1ZSBvZiAnNzEwJyBv biB4ODYuCj4+Cj4+IEV2ZXJ5dGhpbmcgYnV0IHg4NiB3YXMgb25seSAnZXllYmFsbCB0ZXN0ZWQn LCB0aGUgY2hhbmdlIGlzIHRyaXZpYWwKPj4gYnV0IHNvcnJ5IGluIGFkdmFuY2UgaWYgSSBzY3Jl d2VkIHVwKQo+IAo+IENocmlzdGlhbiwgY2FuIHlvdSBsb29rIGF0IHRoaXMgZm9yIHMzOTA/wqAg UmV0dXJuaW5nIGEgZml4ZWQgdmFsdWUgc2VlbXMgd3JvbmcgZm9yIEtWTV9DQVBfTlJfVkNQVVMu CgpJZiB3ZSB0YWxrIGFib3V0IHJlY29tbWVuZGVkIG51bWJlciwgdGhlbiBudW1fb25saW5lX2Nw dXMoKSBhbHNvIHNlZW1zIHRvIG1ha2Ugc2Vuc2Ugb24gczM5MCBzbwppZiB5b3UgY2hhbmdlIHRo YXQgZm9yIHMzOTAgYXMgd2VsbCBJIGNhbiBBQ0sgdGhpcy4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Date: Mon, 15 Nov 2021 12:33:56 +0000 Subject: Re: [PATCH 0/5] KVM: Cap KVM_CAP_NR_VCPUS by KVM_CAP_MAX_VCPUS and re-purpose it on x86 Message-Id: List-Id: References: <20211111162746.100598-1-vkuznets@redhat.com> <4a3c7be7-12fa-6e47-64eb-02e6c5be5dbc@redhat.com> In-Reply-To: <4a3c7be7-12fa-6e47-64eb-02e6c5be5dbc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Paolo Bonzini , Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Eduardo Habkost , Marc Zyngier , Andrew Jones , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Mackerras , Michael Ellerman , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Am 11.11.21 um 17:32 schrieb Paolo Bonzini: > On 11/11/21 17:27, Vitaly Kuznetsov wrote: >> This is a comtinuation of "KVM: x86: Drop arbitraty KVM_SOFT_MAX_VCPUS" >> (https://lore.kernel.org/kvm/20211111134733.86601-1-vkuznets@redhat.com/) >> work. >> >> 1) Enforce KVM_CAP_NR_VCPUS <= KVM_CAP_MAX_VCPUS rule on all >>   architectures. [Sean Christopherson] >> 2) Make KVM_CAP_NR_VCPUS return num_online_cpus() and not an arbitrary >>   value of '710' on x86. >> >> Everything but x86 was only 'eyeball tested', the change is trivial >> but sorry in advance if I screwed up) > > Christian, can you look at this for s390?  Returning a fixed value seems wrong for KVM_CAP_NR_VCPUS. If we talk about recommended number, then num_online_cpus() also seems to make sense on s390 so if you change that for s390 as well I can ACK this.