From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Geliang Tang <geliang.tang@suse.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v12 07/10] mptcp: add last_snd write access
Date: Wed, 20 Apr 2022 18:23:26 +0200 [thread overview]
Message-ID: <ecdf9234-ad37-0bb5-6a73-870f31b11a26@tessares.net> (raw)
In-Reply-To: <396f8edcbf8e4f65a1d76c228dc3d12aa4dd2f11.1650430389.git.geliang.tang@suse.com>
Hi Geliang,
On 20/04/2022 06:57, Geliang Tang wrote:
> This patch exports the member last_snd of struct mptcp_sock in
> bpf_mptcp_helpers.h, and adds BPF write access to it.
Do we really need the have the different schedulers modifying it? Could
we not let the caller of "sched->get_subflow()" setting it?
I mean: 'last_snd' should always be the same as what get_subflow() will
return, no? If yes, why not setting it in mptcp_sched_get_subflow()?
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2022-04-20 16:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 4:56 [PATCH mptcp-next v12 00/10] BPF packet scheduler Geliang Tang
2022-04-20 4:57 ` [PATCH mptcp-next v12 01/10] mptcp: add struct mptcp_sched_ops Geliang Tang
2022-04-20 16:22 ` Matthieu Baerts
2022-04-20 4:57 ` [PATCH mptcp-next v12 02/10] mptcp: register default scheduler Geliang Tang
2022-04-20 4:57 ` [PATCH mptcp-next v12 03/10] mptcp: add a new sysctl scheduler Geliang Tang
2022-04-20 4:57 ` [PATCH mptcp-next v12 04/10] mptcp: add sched in mptcp_sock Geliang Tang
2022-04-20 4:57 ` [PATCH mptcp-next v12 05/10] mptcp: add get_subflow wrapper Geliang Tang
2022-04-20 4:57 ` [PATCH mptcp-next v12 06/10] mptcp: add bpf_mptcp_sched_ops Geliang Tang
2022-04-20 4:57 ` [PATCH mptcp-next v12 07/10] mptcp: add last_snd write access Geliang Tang
2022-04-20 16:23 ` Matthieu Baerts [this message]
2022-04-20 16:44 ` Matthieu Baerts
2022-04-21 6:42 ` kernel test robot
2022-04-20 4:57 ` [PATCH mptcp-next v12 08/10] mptcp: add call_me_again flag Geliang Tang
2022-04-20 16:40 ` Matthieu Baerts
2022-04-20 4:57 ` [PATCH mptcp-next v12 09/10] selftests: bpf: add bpf_first scheduler Geliang Tang
2022-04-20 4:57 ` [PATCH mptcp-next v12 10/10] selftests: bpf: add bpf_first test Geliang Tang
2022-04-20 5:14 ` selftests: bpf: add bpf_first test: Build Failure MPTCP CI
2022-04-20 6:49 ` selftests: bpf: add bpf_first test: Tests Results MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecdf9234-ad37-0bb5-6a73-870f31b11a26@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.