Re: [RFC PATCH 3/6] ASoC: Intel: common: move parts of NHLT code to new module - Pierre-Louis Bossart

From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Hui Wang <hui.wang@canonical.com>,
	Curtis Malainey <cujomalainey@google.com>,
	alsa-devel@alsa-project.org, broonie@kernel.org,
	Daniel Drake <drake@endlessm.com>
Subject: Re: [RFC PATCH 3/6] ASoC: Intel: common: move parts of NHLT code to new module
Date: Fri, 24 May 2019 08:16:05 -0500	[thread overview]
Message-ID: <ece1c28e-183e-71b0-22cf-148047ae23c0@linux.intel.com> (raw)
In-Reply-To: <s5hmujce18j.wl-tiwai@suse.de>

On 5/24/19 2:54 AM, Takashi Iwai wrote:
> On Fri, 24 May 2019 01:39:48 +0200,
> Pierre-Louis Bossart wrote:
>>
>> Move parts of the code outside of the Skylake driver to help detect
>> the presence of DMICs (which are not supported by the HDaudio legacy
>> driver).
>>
>> No functionality change, only indentation and checkpatch fixes, and making sure that the code compiles without ACPI
>>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> This is no ASoC-specific code, which will be called from the legacy
> HDA driver, too.  So better to drop SOC_ prefix.

ok.
I also thought about the location of the code, I am not sure this works 
if SND_SOC is not selected.

If SND_SOC is not selected, there is also no conflict with another 
driver so we may want to bypass this code. Or use it, flag that the 
config will prevent capture from working but continue the probe so that 
the playback works at least.