From: Sinan Kaya <email@example.com> To: Lukas Wunner <firstname.lastname@example.org>, Bjorn Helgaas <email@example.com> Cc: Mika Westerberg <firstname.lastname@example.org>, Yehezkel Bernat <email@example.com>, Michael Jamet <firstname.lastname@example.org>, email@example.com Subject: Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown Date: Fri, 12 Jan 2018 09:26:48 -0500 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20180112104929.GA10599@wunner.de> Hi Lukas, On 1/12/2018 5:49 AM, Lukas Wunner wrote: > Hi Sinan, > > I updated to 4.15 this week and noticed a regression (if one may call it > that, it's more like a very noticeable annoyance) affecting machines > with Thunderbolt controllers wherein a reboot or shutdown is delayed by > 8 seconds, caused by Sorry for that. I wonder if we can separate remove from shutdown and just disable the IRQs in shutdown case rather than turning off the slot power etc. Let me see if I can come up with a quick patch. > On the one hand, your commit message sounds as though the change merely > addresses a *potential* issue, so one could argue that if it causes > *real* issues such as delayed reboots, it's probably not a good idea. > On the other hand I do see your point since a user might surprise-remove > a device from a hotplug slot during shutdown, and we clearly wouldn't want > to act on that. We are seeing the problem on our platform (QDF2400). It is just sporadic. That's why, the commit message was loosely worded. Sinan -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-01-12 14:26 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-12 10:49 Lukas Wunner 2018-01-12 11:03 ` Lukas Wunner 2018-01-12 14:26 ` Sinan Kaya [this message] 2018-01-12 15:12 ` Lukas Wunner 2018-01-12 15:31 ` Sinan Kaya 2018-01-13 7:32 ` Lukas Wunner 2018-01-13 17:58 ` okaya 2018-01-13 19:39 ` Lukas Wunner 2018-01-13 20:49 ` okaya 2018-01-12 16:34 ` Mika Westerberg 2018-01-13 7:14 ` Lukas Wunner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Regression (sort of): PCI/portdrv: Turn off PCIe services during shutdown' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.