From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq262-0006NX-DG for qemu-devel@nongnu.org; Fri, 30 Sep 2016 13:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bq260-00030J-Eu for qemu-devel@nongnu.org; Fri, 30 Sep 2016 13:59:41 -0400 References: <1475246744-29302-1-git-send-email-berrange@redhat.com> <1475246744-29302-10-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: Date: Fri, 30 Sep 2016 12:59:30 -0500 MIME-Version: 1.0 In-Reply-To: <1475246744-29302-10-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VlIi5WxX7IexODwk0kr6FC5UHCwnxNLm1" Subject: Re: [Qemu-devel] [PATCH v14 09/21] qapi: permit auto-creating single element lists List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Markus Armbruster , Max Reitz , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VlIi5WxX7IexODwk0kr6FC5UHCwnxNLm1 From: Eric Blake To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Markus Armbruster , Max Reitz , Paolo Bonzini , =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: Subject: Re: [PATCH v14 09/21] qapi: permit auto-creating single element lists References: <1475246744-29302-1-git-send-email-berrange@redhat.com> <1475246744-29302-10-git-send-email-berrange@redhat.com> In-Reply-To: <1475246744-29302-10-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/30/2016 09:45 AM, Daniel P. Berrange wrote: > When converting QemuOpts to a QObject, there is no information > about compound types available, so when visiting a list, the > corresponding QObject is not guaranteed to be a QList. We > therefore need to be able to auto-create a single element QList > from whatever type we find. >=20 > This mode should only be enabled if you have compatibility > requirements for >=20 > -arg foo=3Dhello,foo=3Dworld >=20 > to be treated as equivalent to the preferred syntax: >=20 > -arg foo.0=3Dhello,foo.1=3Dworld >=20 > Signed-off-by: Daniel P. Berrange > --- > include/qapi/qobject-input-visitor.h | 20 +++++++- > qapi/qobject-input-visitor.c | 27 +++++++++-- > tests/test-qobject-input-visitor.c | 88 ++++++++++++++++++++++++++++= +++----- > 3 files changed, 117 insertions(+), 18 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VlIi5WxX7IexODwk0kr6FC5UHCwnxNLm1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX7qgCAAoJEKeha0olJ0NqwlAH/2YdirKF1VKecpak6KuuTU7d pCY8tDcM43MY9UnbqDBdkR/5yhwv6Lnn/qGXCFQQX21mZFjrF9pBYw1CJWZND38X hMdjxC++QHEq0g80GbFa+FsIJobva9ES6dx2pHThA8HEr4clxOiFXdb56BYPkh2A oKqQzLtK5HC5+rhnxGTegvKYY07WATDp5cdv1o6TOoKuulKx4+1L1xTP4YtlqCMT Toi8/mbWpPtYfpbfBd/A+iIky0KIRRByNsiPSQnD/R59RiKVDL5JlUVvpu3IkIlT qv4+SfFuik8eORNL1PnZL4allZT/euqmt9vxzMmmxOtIbP82FM16z/IL/RGxcuY= =xqkj -----END PGP SIGNATURE----- --VlIi5WxX7IexODwk0kr6FC5UHCwnxNLm1--