Re: linux-next: Signed-off-by missing for commits in the staging tree

[Christian Gromm <christian.gromm@microchip.com>]

On 28.11.2017 20:41, Greg KH wrote:
> On Tue, Nov 28, 2017 at 08:16:51AM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> Commits
>>
>>    2525ef557c73 ("staging: most: update driver usage file")
>>    e7e3ce04588c ("staging: most: core: fix list traversing")
>>
>> are missing a Signed-off-by from their author.
> 
> Ugh, I missed that.  Christian, please be more careful.
> 

Hmm, am I missing something here? I have it in.
Here are copies of the patches in question and both have
a "Signed-off-by" line in.

---snip---
Received: from muaddib.microchip.com (10.10.76.4) by 
chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id 
14.3.352.0; Tue, 21 Nov 2017 07:05:31 -0700
From: Christian Gromm <christian.gromm@microchip.com>
To: gregkh@linuxfoundation.org
CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov 
<andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
Subject: [PATCH 48/50] staging: most: core: fix list traversing
Date: Tue, 21 Nov 2017 15:05:22 +0100
Message-ID: 
<1511273124-7840-49-git-send-email-christian.gromm@microchip.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: 
<1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
Content-Type: text/plain
Return-Path: christian.gromm@microchip.com
X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
X-MS-Exchange-Organization-AuthAs: Internal
X-MS-Exchange-Organization-AuthMechanism: 10
X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
MIME-Version: 1.0

From: Andrey Shvetsov <andrey.shvetsov@k2l.de>
This patch fixes the offset and data handling when traversing
the list of devices that are attached to the bus.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
---
  drivers/staging/most/core.c | 17 +++++++++++++----
  1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index d03ff97..9729206 100644
--- a/drivers/staging/most/core.c
+++ b/drivers/staging/most/core.c
@@ -535,10 +535,16 @@ static struct core_component *match_component(char 
*name)
  	return NULL;
  }

+struct show_links_data {
+	int offs;
+	char *buf;
+};
+
  int print_links(struct device *dev, void *data)
  {
-	int offs = 0;
-	char *buf = data;
+	struct show_links_data *d = data;
+	int offs = d->offs;
+	char *buf = d->buf;
  	struct most_channel *c;
  	struct most_interface *iface = to_most_interface(dev);

@@ -560,13 +566,16 @@ int print_links(struct device *dev, void *data)
  					 dev_name(&c->dev));
  		}
  	}
+	d->offs = offs;
  	return 0;
  }

  static ssize_t links_show(struct device_driver *drv, char *buf)
  {
-	bus_for_each_dev(&mc.bus, NULL, buf, print_links);
-	return strlen(buf);
+	struct show_links_data d = { .buf = buf };
+
+	bus_for_each_dev(&mc.bus, NULL, &d, print_links);
+	return d.offs;
  }

  static ssize_t components_show(struct device_driver *drv, char *buf)
-- 
2.7.4


and


Received: from muaddib.microchip.com (10.10.76.4) by 
chn-sv-exch05.mchp-main.com (10.10.76.106) with Microsoft SMTP Server id 
14.3.352.0; Tue, 21 Nov 2017 07:05:26 -0700
From: Christian Gromm <christian.gromm@microchip.com>
To: gregkh@linuxfoundation.org
CC: driverdev-devel@linuxdriverproject.org, Andrey Shvetsov 
<andrey.shvetsov@k2l.de>, Christian Gromm <christian.gromm@microchip.com>
Subject: [PATCH 44/50] staging: most: update driver usage file
Date: Tue, 21 Nov 2017 15:05:18 +0100
Message-ID: 
<1511273124-7840-45-git-send-email-christian.gromm@microchip.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: 
<1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
References: <1511273124-7840-1-git-send-email-christian.gromm@microchip.com>
Content-Type: text/plain
Return-Path: christian.gromm@microchip.com
X-MS-Exchange-Organization-AuthSource: CHN-SV-EXCH05.mchp-main.com
X-MS-Exchange-Organization-AuthAs: Internal
X-MS-Exchange-Organization-AuthMechanism: 10
X-MS-Exchange-Organization-AVStamp-Mailbox: SYMANTEC;628359232;0;info
MIME-Version: 1.0

From: Andrey Shvetsov <andrey.shvetsov@k2l.de>

This patch keeps the usage file up to date.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
---
  .../staging/most/Documentation/driver_usage.txt    | 192 
+++++++++++----------
  1 file changed, 105 insertions(+), 87 deletions(-)

diff --git a/drivers/staging/most/Documentation/driver_usage.txt 
b/drivers/staging/most/Documentation/driver_usage.txt
index a4dc0c3..bb9b4e8 100644
--- a/drivers/staging/most/Documentation/driver_usage.txt
+++ b/drivers/staging/most/Documentation/driver_usage.txt
@@ -23,20 +23,29 @@ audio/video streaming. Therefore, the driver 
perfectly fits to the mission
  of Automotive Grade Linux to create open source software solutions for
  automotive applications.

-The driver consists basically of three layers. The hardware layer, the
-core layer and the application layer. The core layer consists of the core
-module only. This module handles the communication flow through all three
-layers, the configuration of the driver, the configuration interface
-representation in sysfs, and the buffer management.
-For each of the other two layers a selection of modules is provided. These
-modules can arbitrarily be combined to meet the needs of the desired
-system architecture. A module of the hardware layer is referred to as an
-HDM (hardware dependent module). Each module of this layer handles exactly
-one of the peripheral interfaces of a network interface controller (e.g.
-USB, MediaLB, I2C). A module of the application layer is referred to as an
-AIM (application interfacing module). The modules of this layer give access
-to MOST via one the following ways: character devices, ALSA, Networking or
..........

regards,
Chris


> I need to set up a git hook for this :(
> 
> greg k-h
>