From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLBi5-0004LK-UI for qemu-devel@nongnu.org; Thu, 07 Jul 2016 11:59:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLBi3-0007Z3-VX for qemu-devel@nongnu.org; Thu, 07 Jul 2016 11:59:28 -0400 Sender: Paolo Bonzini References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-5-git-send-email-clord@redhat.com> <20160705154925.GA6553@redhat.com> <32a142e7-8e46-9ae7-30b0-df42876601cb@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 7 Jul 2016 17:59:14 +0200 MIME-Version: 1.0 In-Reply-To: <32a142e7-8e46-9ae7-30b0-df42876601cb@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 04/32] blockdev: Move bochs probe into separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , "Daniel P. Berrange" , Colin Lord Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com On 05/07/2016 22:50, John Snow wrote: > So, something like: > > block/drivers/bochs/ > > bochs.c > probe.c (or bochs-probe.c) > > and > > include/block/drivers/bochs/ > > common.h (or internal.h) > > > Any objections from the gallery? I guess I'm missing why it is useful to modularize drivers that don't need any external libraries; those that do in general are protocols and need no probe function. Sorry if I haven't noticed this in a previous discussion. Paolo