From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89871C433EF for ; Wed, 27 Oct 2021 14:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E69560E73 for ; Wed, 27 Oct 2021 14:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242654AbhJ0O7i (ORCPT ); Wed, 27 Oct 2021 10:59:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:24484 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237296AbhJ0O7e (ORCPT ); Wed, 27 Oct 2021 10:59:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635346629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1kiv1BZf6xFogujw6ml5Mx2cj+xKDQFeYDEEPX1GMOs=; b=A/5DhUG7viz9Q20XNQp3R6VBeocsmcHHxyZnXNKlXb2LeOhxQD3FBuD/IHfg64yyzpTE88 Yd8E9nyDnQNDrL+TNML6kaLLWBbIi9CoNgujO3/B3q1sUlM+l6HfFeY3ZfaIrwEUtixyJM rsyKtuYm24TO6HmYojVtsAYztUdbfaM= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-151-j3wZ0yMQOlmC7TFLszKgDQ-1; Wed, 27 Oct 2021 10:57:07 -0400 X-MC-Unique: j3wZ0yMQOlmC7TFLszKgDQ-1 Received: by mail-ed1-f69.google.com with SMTP id u10-20020a50d94a000000b003dc51565894so2527558edj.21 for ; Wed, 27 Oct 2021 07:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1kiv1BZf6xFogujw6ml5Mx2cj+xKDQFeYDEEPX1GMOs=; b=Y6OQRJqZoCbl9TVJKVAwD09WcsqwgmENFMQ+LBNLB9+N7W2fteBNddl54QeyA9q5+K E9xnBWRKdNd66/UDVOGiXOzIEs0qzjl8Lpl8EEvHjWSAbVvjEdy7AYUY4Q/Hj2ycW8tE AHfP2k80isPQRS3flPM6amivIuIZuFt5ctrW7xBBdt/UdsBUIf793pFh24Qbr7tmv1G9 PNjOdnv9rQkG8I1NkRWJXKd2BvpExEjFoH7lm/4CEd00B16Yg0Z4No3OHi1xuRfBg5bT nrbAfoFIPTMACCaJoRTipRu4d2rmq8IsDojkOVjuSxFn4H3Tb5hJVfh11AQtCBageTbs Hkrg== X-Gm-Message-State: AOAM533WfOOqULM48/sPa2ZglBghGDIkgl38eUI1TFc/POz5AnbuKsdI xv6fUjTNi5pNqS3o6QFQj+c/aw/j8fdFpdZpZV8dzuYqS3C2MdwGZwG03W/MGSF/vrXrdKvet/a ONfqPeYRv4ksVSUvoniMTwe9p X-Received: by 2002:a17:907:7d94:: with SMTP id oz20mr38999431ejc.98.1635346626749; Wed, 27 Oct 2021 07:57:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytn7bu+kBLh9LVQ/1pex7gMJDdz0Rr/buTYBO2a2VZJzJDbs6skZyshVLbERw1F1K5YyM70Q== X-Received: by 2002:a17:907:7d94:: with SMTP id oz20mr38999381ejc.98.1635346626512; Wed, 27 Oct 2021 07:57:06 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t15sm67707ejx.75.2021.10.27.07.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 07:57:05 -0700 (PDT) Message-ID: Date: Wed, 27 Oct 2021 16:57:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 00/43] KVM: Halt-polling and x86 APICv overhaul Content-Language: en-US To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <614858dd-106c-64cc-04bc-f1887b2054d1@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/21 16:41, Sean Christopherson wrote: > The other thing I don't like about having the WARN in the loop is that it suggests > that something other than the vCPU can modify the NDST and SN fields, which is > wrong and confusing (for me). Yeah, I can agree with that. Can you add it in a comment above the cmpxchg loop, it can be as simple as /* The processor can set ON concurrently. */ when you respin patch 21 and the rest of the series? Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE4BC433F5 for ; Wed, 27 Oct 2021 14:57:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B28860E05 for ; Wed, 27 Oct 2021 14:57:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B28860E05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q0hKlz4X2eDJ2B23o8J2v3T7ZZMh2RNbwvjzmyPA2SQ=; b=Fhk/tbPjm8AEJx v4AFGlBmdqmi1huZi7iJsdYoVUlWKa4UABVndc8Qtf6EPT1zb+af9pv+exonRtnIyMs0rzXWYgY0+ YnifdDz7oGdm8dww1v3CkNcjhMUh2XvynX5LbRdOOJ3yAzYf8EN+6cfW+mf7SwelYStRwFUvXv52K 5CIUZ3lLa72t9QwDkxfT6neMi5PsZg/WnQ5q6Nj5a3MiNZ9Df41/2wzg2blK6o+8qUZdbYDSTyZ9a beVSYKHaD13xxGlNyxb869r4TAOzsJbHiD81ogRvWOZ6XPTEn3QgqUGmIWNHFPmwBw6NiJa56F5ZH yR3iEGsggeEo/jlDWuQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfkMl-005DhH-QP; Wed, 27 Oct 2021 14:57:23 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfkMa-005DfY-I9 for linux-riscv@lists.infradead.org; Wed, 27 Oct 2021 14:57:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635346631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1kiv1BZf6xFogujw6ml5Mx2cj+xKDQFeYDEEPX1GMOs=; b=CYIxKjpCTRPNFwO45rfZcvEc5EOw8tCFGcoyb0alw/fDelPLybQDHQEqIrVRABJJyJ9+V4 9kJnhjfAN4puV4BMQiNSm/pMoitg4FHReFDclaqPE9F30URNuZWBhCKBYAgpvI1A3vyOOg fRtn2aYUvc2FHgnk8EyPJ4dsT0eujC4= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-MU1zY_w6PR2EltCE9Bm3tQ-1; Wed, 27 Oct 2021 10:57:07 -0400 X-MC-Unique: MU1zY_w6PR2EltCE9Bm3tQ-1 Received: by mail-ed1-f69.google.com with SMTP id m16-20020a056402431000b003dd2005af01so2585250edc.5 for ; Wed, 27 Oct 2021 07:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1kiv1BZf6xFogujw6ml5Mx2cj+xKDQFeYDEEPX1GMOs=; b=CNebTcMFbSyaDCcadCpNexBuJ7g+IY2UWzh74BleX+ZTwH2QA5cIzx6IFmHt5ZNDMm +XVNnoLYLqHDnC6OA+iQUYdSt31J3T7PmtwD3qABTlv2G0pFkOPRaE7q15bhx9rD0ULQ HKCAKCGXSxNICYTKOqRfT9hi5rGigra0RUEzgnHvKZcB7CQ6wMH59ldJ88RBufB8/C5h 2RqMQ1zvR3CyWAZ4mVHT5UlQXu+LuqEnwa4KkEqNPQ0TD68O8g3cVZI2iQaPt5ZeLaL8 klgs3JDuHMZFPlWDvrPvrRFnayNBwZTOp2dlYXlvy/eLff8BKjsU8/2dRSXGnMOw8sOZ vjcQ== X-Gm-Message-State: AOAM532BdNzvjigoDDF2bDC4jyR+Vz6T3R07JBAr1c7l5kWinnr3ETZW CYcW7mo+Io6g+2+4+PXimUKnYv3Xkp4+8W4eZS+QB1K9G9huH8NI3n4aV4vSIB2gRDV/kcgSDYJ 3yEiVJOnRcRLtpJLS6le3ZMA8xVBE X-Received: by 2002:a17:907:7d94:: with SMTP id oz20mr38999423ejc.98.1635346626741; Wed, 27 Oct 2021 07:57:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytn7bu+kBLh9LVQ/1pex7gMJDdz0Rr/buTYBO2a2VZJzJDbs6skZyshVLbERw1F1K5YyM70Q== X-Received: by 2002:a17:907:7d94:: with SMTP id oz20mr38999381ejc.98.1635346626512; Wed, 27 Oct 2021 07:57:06 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t15sm67707ejx.75.2021.10.27.07.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 07:57:05 -0700 (PDT) Message-ID: Date: Wed, 27 Oct 2021 16:57:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 00/43] KVM: Halt-polling and x86 APICv overhaul To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <614858dd-106c-64cc-04bc-f1887b2054d1@redhat.com> From: Paolo Bonzini In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_075712_685649_47463A93 X-CRM114-Status: UNSURE ( 8.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 27/10/21 16:41, Sean Christopherson wrote: > The other thing I don't like about having the WARN in the loop is that it suggests > that something other than the vCPU can modify the NDST and SN fields, which is > wrong and confusing (for me). Yeah, I can agree with that. Can you add it in a comment above the cmpxchg loop, it can be as simple as /* The processor can set ON concurrently. */ when you respin patch 21 and the rest of the series? Paolo _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 803CBC433FE for ; Wed, 27 Oct 2021 14:57:14 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id E70BF60724 for ; Wed, 27 Oct 2021 14:57:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E70BF60724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 67FFD4B172; Wed, 27 Oct 2021 10:57:13 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D-9Alsn-G0PC; Wed, 27 Oct 2021 10:57:12 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3D3394B183; Wed, 27 Oct 2021 10:57:12 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 428464B121 for ; Wed, 27 Oct 2021 10:57:10 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tINoOjQd7qvE for ; Wed, 27 Oct 2021 10:57:09 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4088B4A4BE for ; Wed, 27 Oct 2021 10:57:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635346629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1kiv1BZf6xFogujw6ml5Mx2cj+xKDQFeYDEEPX1GMOs=; b=A/5DhUG7viz9Q20XNQp3R6VBeocsmcHHxyZnXNKlXb2LeOhxQD3FBuD/IHfg64yyzpTE88 Yd8E9nyDnQNDrL+TNML6kaLLWBbIi9CoNgujO3/B3q1sUlM+l6HfFeY3ZfaIrwEUtixyJM rsyKtuYm24TO6HmYojVtsAYztUdbfaM= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-5Dimra96PXuPKvU3ewk6Qg-1; Wed, 27 Oct 2021 10:57:07 -0400 X-MC-Unique: 5Dimra96PXuPKvU3ewk6Qg-1 Received: by mail-ed1-f72.google.com with SMTP id h16-20020a05640250d000b003dd8167857aso2631179edb.0 for ; Wed, 27 Oct 2021 07:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1kiv1BZf6xFogujw6ml5Mx2cj+xKDQFeYDEEPX1GMOs=; b=3wxxo2QNOwEPdy0b9+//REUAR1hWTy2YwfnD5S8mkJ7eQGriH+Hv128v+9igYaDyud jbKyvuVz/y6qkr0vJX3ANzjGS8Fm+EFm9Rz5GUKl30dzOwC47NZ/DnSm9X9iDkQ8kp5y A/TuOaa3nftNKQJoIk/jGaugJ1KEJmjjFGP/gNPh9S44r/89cf2jkH4Qkz6rdy/reejS I+yFeVCHJsOLDLKxrnHNJwgWdNt9BNToKFBtWQzCeg6oqeUvLK8nortXIrPSHepda5l/ j7FMbTD8BHgBVN2lAvNM6jayJTIo2TGkAjMw9MadDKCUxevIJjeQ2RoJFH0g3Ucx7Hir IsJA== X-Gm-Message-State: AOAM533Xwd+W9PvJiLsx2MoJxObThBqOuAUC+zt07U0ra10XYODptj07 CHVELMRrYmpze7hiiSW1cTnPoSfV9EC7SdgzxQ2py0Df6SUHVfRT7R7uxIl1xzmnYRLB7ao9/eu xabPClHSjsvqPtVuS9u8iyBzf X-Received: by 2002:a17:907:7d94:: with SMTP id oz20mr38999419ejc.98.1635346626741; Wed, 27 Oct 2021 07:57:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytn7bu+kBLh9LVQ/1pex7gMJDdz0Rr/buTYBO2a2VZJzJDbs6skZyshVLbERw1F1K5YyM70Q== X-Received: by 2002:a17:907:7d94:: with SMTP id oz20mr38999381ejc.98.1635346626512; Wed, 27 Oct 2021 07:57:06 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t15sm67707ejx.75.2021.10.27.07.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 07:57:05 -0700 (PDT) Message-ID: Date: Wed, 27 Oct 2021 16:57:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 00/43] KVM: Halt-polling and x86 APICv overhaul To: Sean Christopherson References: <20211009021236.4122790-1-seanjc@google.com> <614858dd-106c-64cc-04bc-f1887b2054d1@redhat.com> From: Paolo Bonzini In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Cornelia Huck , Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, Paul Mackerras , Atish Patra , linux-riscv@lists.infradead.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Janosch Frank , Marc Zyngier , Joerg Roedel , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , Albert Ou , kvm-ppc@vger.kernel.org, Paul Walmsley , David Matlack , linux-arm-kernel@lists.infradead.org, Jim Mattson , Anup Patel , linux-mips@vger.kernel.org, Palmer Dabbelt , kvm-riscv@lists.infradead.org, Vitaly Kuznetsov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 27/10/21 16:41, Sean Christopherson wrote: > The other thing I don't like about having the WARN in the loop is that it suggests > that something other than the vCPU can modify the NDST and SN fields, which is > wrong and confusing (for me). Yeah, I can agree with that. Can you add it in a comment above the cmpxchg loop, it can be as simple as /* The processor can set ON concurrently. */ when you respin patch 21 and the rest of the series? Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF1D1C433EF for ; Wed, 27 Oct 2021 14:58:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9296A60E73 for ; Wed, 27 Oct 2021 14:58:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9296A60E73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ha+n+reF/hV4M7F2TvSRyCCd3f4eoSRNlGPHaUlX640=; b=uGqJW//YmcipX4 p07clQ2PTSN5RxBhfUOizImCJpNtt2VF6SOEQKAIsFWlQVLremcfI97x08ClzxAy+jK5QaqLTv3hu /yYsT6Q69LXEZxb3MNbb4xlD8lpKb3s0g7/25tcLqExFPnelE3yG35vnimZG/WoAcKSKdGFkT80Au +fSRjVHvshqQkWb54wyvBGGhHFVUDP9Rl94NkfC0OZnIpZXAR4C//QWwwb5pqVnhUE2OZJ99hLzRf 7h5BsSjftUNfw91a1fqVVOA9LDu98siy4dTXCylnrfB2heozrICacqitVM0lFFeAeLlBzeSvX9fNI rV38lX44eczFD3lnCRsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfkMc-005DgE-Pa; Wed, 27 Oct 2021 14:57:15 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfkMY-005Dep-4X for linux-arm-kernel@lists.infradead.org; Wed, 27 Oct 2021 14:57:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635346629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1kiv1BZf6xFogujw6ml5Mx2cj+xKDQFeYDEEPX1GMOs=; b=A/5DhUG7viz9Q20XNQp3R6VBeocsmcHHxyZnXNKlXb2LeOhxQD3FBuD/IHfg64yyzpTE88 Yd8E9nyDnQNDrL+TNML6kaLLWBbIi9CoNgujO3/B3q1sUlM+l6HfFeY3ZfaIrwEUtixyJM rsyKtuYm24TO6HmYojVtsAYztUdbfaM= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-539-t_MslbpLMhegD4pwM6uwdg-1; Wed, 27 Oct 2021 10:57:07 -0400 X-MC-Unique: t_MslbpLMhegD4pwM6uwdg-1 Received: by mail-ed1-f72.google.com with SMTP id z1-20020a05640235c100b003dcf0fbfbd8so2588122edc.6 for ; Wed, 27 Oct 2021 07:57:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1kiv1BZf6xFogujw6ml5Mx2cj+xKDQFeYDEEPX1GMOs=; b=GDA30fbCgHW0CpD1KDEHCWORbp4Gi6d4G4M2kauORSYPmRNsjc0nCgFBbzH5yOtZuj Kli0JvFGo/HCBcS5cHs0NGw42RmJbZKIRX75K09xH7xyuvyNZp6DZcnkTW4hLuA1FlT/ uznez7tYn6PaPswwaO/2JMF5apMuYOW66gIbpcGLXRenHkgwfTCtSZm75uaJL9RwVGRU IXjoxVE+w84xZ2UUNu21nLrSjtR6Rrjri4Zj91dF/hnmW6II5WmWzVX8mB8JZuW0oQqF RKVbacPp+bx8N5avCu9bcSGSi76ChJbKfZmMFEqNmY7NrJNvHjR7KKsyJrNTsV0yt4Bb 6ClQ== X-Gm-Message-State: AOAM532Tf7Ihl+s825R33ngT6JcR+Zj0zhTk2bKOwHOMalz3wmvbrT1d VEa47IuQadV0AkvVv5W6UFAR10SDztkH2XyakcDX7ixETPZhEJNCK4sk7bK/rTNh8o7nmlPP+o9 LoIS30J9XFKQLLfZrbd2r/FuG+HTtV/FkFIU= X-Received: by 2002:a17:907:7d94:: with SMTP id oz20mr38999414ejc.98.1635346626737; Wed, 27 Oct 2021 07:57:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytn7bu+kBLh9LVQ/1pex7gMJDdz0Rr/buTYBO2a2VZJzJDbs6skZyshVLbERw1F1K5YyM70Q== X-Received: by 2002:a17:907:7d94:: with SMTP id oz20mr38999381ejc.98.1635346626512; Wed, 27 Oct 2021 07:57:06 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t15sm67707ejx.75.2021.10.27.07.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 07:57:05 -0700 (PDT) Message-ID: Date: Wed, 27 Oct 2021 16:57:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 00/43] KVM: Halt-polling and x86 APICv overhaul To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <614858dd-106c-64cc-04bc-f1887b2054d1@redhat.com> From: Paolo Bonzini In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_075710_289389_538F801E X-CRM114-Status: GOOD ( 10.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/10/21 16:41, Sean Christopherson wrote: > The other thing I don't like about having the WARN in the loop is that it suggests > that something other than the vCPU can modify the NDST and SN fields, which is > wrong and confusing (for me). Yeah, I can agree with that. Can you add it in a comment above the cmpxchg loop, it can be as simple as /* The processor can set ON concurrently. */ when you respin patch 21 and the rest of the series? Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Wed, 27 Oct 2021 14:57:00 +0000 Subject: Re: [PATCH v2 00/43] KVM: Halt-polling and x86 APICv overhaul Message-Id: List-Id: References: <20211009021236.4122790-1-seanjc@google.com> <614858dd-106c-64cc-04bc-f1887b2054d1@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang On 27/10/21 16:41, Sean Christopherson wrote: > The other thing I don't like about having the WARN in the loop is that it suggests > that something other than the vCPU can modify the NDST and SN fields, which is > wrong and confusing (for me). Yeah, I can agree with that. Can you add it in a comment above the cmpxchg loop, it can be as simple as /* The processor can set ON concurrently. */ when you respin patch 21 and the rest of the series? Paolo