From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7492C282C0 for ; Fri, 25 Jan 2019 12:34:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF47F2146E for ; Fri, 25 Jan 2019 12:34:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728770AbfAYMed (ORCPT ); Fri, 25 Jan 2019 07:34:33 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:56616 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728648AbfAYMeZ (ORCPT ); Fri, 25 Jan 2019 07:34:25 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92-RC4) (envelope-from ) id 1gn0gh-0000P6-Mr; Fri, 25 Jan 2019 13:34:23 +0100 Message-ID: Subject: Re: [PATCH 2/3] mac80211: store tx power value from user to station From: Johannes Berg To: Balaji Pothunoori , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Ashok Raj Nagarajan Date: Fri, 25 Jan 2019 13:34:21 +0100 In-Reply-To: <1547724247-11481-1-git-send-email-bpothuno@codeaurora.org> References: <1547724247-11481-1-git-send-email-bpothuno@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2019-01-17 at 16:54 +0530, Balaji Pothunoori wrote: > > + * @txpwr: indicates the tx power, in mBm, to be used when sending data frames > + * to the STA. > + * @type: In particular if TPC %type is NL80211_TX_POWER_LIMITED then txpwr will > + * be less than or equal to specified from userspace, whereas if TPC %type > + * is NL80211_TX_POWER_AUTOMATIC then it indicates default txpwr. > + * NL80211_TX_POWER_FIXED is not a valid configuration option for > + * per peer TPC. Same comment here wrt. txpower_type or so. > +TRACE_EVENT(drv_sta_set_txpwr, > + TP_PROTO(struct ieee80211_local *local, > + struct ieee80211_sub_if_data *sdata, > + struct ieee80211_sta *sta), > + > + TP_ARGS(local, sdata, sta), > + > + TP_STRUCT__entry( > + LOCAL_ENTRY > + VIF_ENTRY > + STA_ENTRY > + __field(s16, txpwr) > + ), > + > + TP_fast_assign( > + LOCAL_ASSIGN; > + VIF_ASSIGN; > + STA_ASSIGN; > + __entry->txpwr = sta->txpwr; > + ), Include the type as well? OTOH, is this whole business with the type even needed everywhere? johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gn0gj-0003fe-4u for ath10k@lists.infradead.org; Fri, 25 Jan 2019 12:34:26 +0000 Message-ID: Subject: Re: [PATCH 2/3] mac80211: store tx power value from user to station From: Johannes Berg Date: Fri, 25 Jan 2019 13:34:21 +0100 In-Reply-To: <1547724247-11481-1-git-send-email-bpothuno@codeaurora.org> References: <1547724247-11481-1-git-send-email-bpothuno@codeaurora.org> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Balaji Pothunoori , ath10k@lists.infradead.org Cc: Ashok Raj Nagarajan , linux-wireless@vger.kernel.org On Thu, 2019-01-17 at 16:54 +0530, Balaji Pothunoori wrote: > > + * @txpwr: indicates the tx power, in mBm, to be used when sending data frames > + * to the STA. > + * @type: In particular if TPC %type is NL80211_TX_POWER_LIMITED then txpwr will > + * be less than or equal to specified from userspace, whereas if TPC %type > + * is NL80211_TX_POWER_AUTOMATIC then it indicates default txpwr. > + * NL80211_TX_POWER_FIXED is not a valid configuration option for > + * per peer TPC. Same comment here wrt. txpower_type or so. > +TRACE_EVENT(drv_sta_set_txpwr, > + TP_PROTO(struct ieee80211_local *local, > + struct ieee80211_sub_if_data *sdata, > + struct ieee80211_sta *sta), > + > + TP_ARGS(local, sdata, sta), > + > + TP_STRUCT__entry( > + LOCAL_ENTRY > + VIF_ENTRY > + STA_ENTRY > + __field(s16, txpwr) > + ), > + > + TP_fast_assign( > + LOCAL_ASSIGN; > + VIF_ASSIGN; > + STA_ASSIGN; > + __entry->txpwr = sta->txpwr; > + ), Include the type as well? OTOH, is this whole business with the type even needed everywhere? johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k