From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2132DC43387 for ; Fri, 18 Jan 2019 02:02:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAB3D20855 for ; Fri, 18 Jan 2019 02:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726919AbfARCCI (ORCPT ); Thu, 17 Jan 2019 21:02:08 -0500 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:55069 "EHLO tama50.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfARCCI (ORCPT ); Thu, 17 Jan 2019 21:02:08 -0500 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x0I21xOv000650; Fri, 18 Jan 2019 11:01:59 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 4AF186385E2; Fri, 18 Jan 2019 11:01:59 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 3C385638535; Fri, 18 Jan 2019 11:01:59 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.182]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 30189400ABB; Fri, 18 Jan 2019 11:01:59 +0900 (JST) Subject: Re: [PATCH net 0/7] virtio_net: Fix problems around XDP tx and napi_tx References: <1547724045-2726-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <20190117095243-mutt-send-email-mst@kernel.org> From: Toshiaki Makita Message-ID: Date: Fri, 18 Jan 2019 11:01:17 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190117095243-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: "Michael S. Tsirkin" Cc: "David S. Miller" , Jason Wang , netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, Willem de Bruijn , Jesper Dangaard Brouer X-TM-AS-MML: disable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/01/17 23:55, Michael S. Tsirkin wrote: > On Thu, Jan 17, 2019 at 08:20:38PM +0900, Toshiaki Makita wrote: >> While I'm looking into how to account standard tx counters on XDP tx >> processing, I found several bugs around XDP tx and napi_tx. >> >> Patch1: Fix oops on error path. Patch2 depends on this. >> Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled. >> Patch3: Minor fix patch5 depends on. >> Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled. >> Also patch5 depends on this. >> Patch5: Fix memory corruption on processing xdp_frames while XDP is being >> disabled. >> Patch6: Minor fix patch7 depends on. >> Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal >> queue is reused for XDP and vise versa. >> >> Signed-off-by: Toshiaki Makita > > Series: > > Acked-by: Michael S. Tsirkin Thanks for the review. > > I guess we need this stuff on stable? I think so. > I'm especially happy with Patch7 as it makes my BQL > work a bit easier. > >> Toshiaki Makita (7): >> virtio_net: Don't enable NAPI when interface is down >> virtio_net: Don't call free_old_xmit_skbs for xdp_frames >> virtio_net: Fix not restoring real_num_rx_queues >> virtio_net: Fix out of bounds access of sq >> virtio_net: Don't process redirected XDP frames when XDP is disabled >> virtio_net: Use xdp_return_frame to free xdp_frames on destroying vqs >> virtio_net: Differentiate sk_buff and xdp_frame on freeing >> >> drivers/net/virtio_net.c | 154 +++++++++++++++++++++++++++++++++-------------- >> 1 file changed, 109 insertions(+), 45 deletions(-) >> >> -- >> 1.8.3.1 >> > > -- Toshiaki Makita