All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/mlx5: removal already initialised mbuf fields
@ 2017-05-29  9:45 Nelio Laranjeiro
  2017-05-29 13:30 ` Adrien Mazarguil
  0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2017-05-29  9:45 UTC (permalink / raw)
  To: dev; +Cc: Adrien Mazarguil, Shahaf Shuler

Since commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"), some
fields are already initialised and do not need to be modified by the PMD
anymore.

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index de6e0fa..d4ab7a8 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -2054,9 +2054,7 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)
 		DATA_LEN(rep) = DATA_LEN(seg);
 		PKT_LEN(rep) = PKT_LEN(seg);
 		SET_DATA_OFF(rep, DATA_OFF(seg));
-		NB_SEGS(rep) = NB_SEGS(seg);
 		PORT(rep) = PORT(seg);
-		NEXT(rep) = NULL;
 		(*rxq->elts)[idx] = rep;
 		/*
 		 * Fill NIC descriptor with the new buffer.  The lkey and size
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/mlx5: removal already initialised mbuf fields
  2017-05-29  9:45 [PATCH] net/mlx5: removal already initialised mbuf fields Nelio Laranjeiro
@ 2017-05-29 13:30 ` Adrien Mazarguil
  2017-05-30 12:39   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2017-05-29 13:30 UTC (permalink / raw)
  To: Nelio Laranjeiro; +Cc: dev, Shahaf Shuler

On Mon, May 29, 2017 at 11:45:09AM +0200, Nelio Laranjeiro wrote:
> Since commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"), some
> fields are already initialised and do not need to be modified by the PMD
> anymore.
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Except for the title ("removal" => "remove"?),

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/mlx5: removal already initialised mbuf fields
  2017-05-29 13:30 ` Adrien Mazarguil
@ 2017-05-30 12:39   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-05-30 12:39 UTC (permalink / raw)
  To: Adrien Mazarguil, Nelio Laranjeiro; +Cc: dev, Shahaf Shuler

On 5/29/2017 2:30 PM, Adrien Mazarguil wrote:
> On Mon, May 29, 2017 at 11:45:09AM +0200, Nelio Laranjeiro wrote:
>> Since commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"), some
>> fields are already initialised and do not need to be modified by the PMD
>> anymore.
>>
>> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Except for the title ("removal" => "remove"?),
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to dpdk-next-net/master, thanks.

(fixed title)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-30 12:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-29  9:45 [PATCH] net/mlx5: removal already initialised mbuf fields Nelio Laranjeiro
2017-05-29 13:30 ` Adrien Mazarguil
2017-05-30 12:39   ` Ferruh Yigit

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.