From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2i5L-0000VK-LR for qemu-devel@nongnu.org; Tue, 17 May 2016 12:43:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2i5I-0005gQ-DG for qemu-devel@nongnu.org; Tue, 17 May 2016 12:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2i5I-0005gJ-7K for qemu-devel@nongnu.org; Tue, 17 May 2016 12:43:04 -0400 References: <1463412982-6681-1-git-send-email-pbonzini@redhat.com> <1463412982-6681-21-git-send-email-pbonzini@redhat.com> <20160517142444.GA4915@octofox.metropolis> From: Paolo Bonzini Message-ID: Date: Tue, 17 May 2016 18:42:09 +0200 MIME-Version: 1.0 In-Reply-To: <20160517142444.GA4915@octofox.metropolis> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 20/50] target-xtensa: make cpu-qom.h not target specific List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: qemu-devel@nongnu.org On 17/05/2016 16:24, Max Filippov wrote: >> > Make XtensaCPU an opaque type within cpu-qom.h, and move all definitions >> > of private methods, as well as all type definitions that require knowledge >> > of the layout to cpu.h. Conversely, move all definitions needed to >> > define a class to cpu-qom.h. This helps making files independent of >> > NEED_CPU_H if they only need to pass around CPU pointers. > XtensaCPUClass doesn't need definition of XtensaConfig that pulled a lot > of related structures, macros and enums from cpu.h. Mere > typedef struct XtensaConfig XtensaConfig; > above the XtensaCPUClass could be enough. How about the following? Fine, I'll test your patch and replace mine with it. Paolo