From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mario Kicherer <dev@kicherer.org>, linux-hwmon@vger.kernel.org
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, corbet@lwn.net,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: hwmon: add nxp,mc34vr500
Date: Wed, 18 Jan 2023 12:43:40 +0100 [thread overview]
Message-ID: <ecffda73-9c73-1dbe-3da1-93c205128277@linaro.org> (raw)
In-Reply-To: <20230117161340.1310936-3-dev@kicherer.org>
On 17/01/2023 17:13, Mario Kicherer wrote:
> This patch adds dt-bindings for the NXP MC34VR500 PMIC.
>
> Signed-off-by: Mario Kicherer <dev@kicherer.org>
> ---
Except being untested one more comment:
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mc34vr500@8 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-18 12:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 16:13 [PATCH v3 0/3] add initial NXP MC34VR500 PMIC monitoring support Mario Kicherer
2023-01-17 16:13 ` [PATCH v3 1/3] hwmon: " Mario Kicherer
2023-01-17 17:58 ` Guenter Roeck
2023-01-17 18:03 ` Guenter Roeck
2023-01-17 16:13 ` [PATCH v3 2/3] dt-bindings: hwmon: add nxp,mc34vr500 Mario Kicherer
2023-01-17 18:03 ` Guenter Roeck
2023-01-17 20:40 ` Rob Herring
2023-01-18 11:43 ` Krzysztof Kozlowski [this message]
2023-01-17 16:13 ` [PATCH v3 3/3] docs: hwmon: add docs for the NXP MC34VR500 PMIC Mario Kicherer
2023-01-17 18:01 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecffda73-9c73-1dbe-3da1-93c205128277@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=corbet@lwn.net \
--cc=dev@kicherer.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.